>>> Building on exopi-6 under emulators/simh BDEPENDS = [archivers/unzip;devel/gmake] DIST = [emulators/simh:simhv39-0.zip] FULLPKGNAME = simh-3.9.0p3 (Junk lock obtained for exopi-6 at 1764801494.04) >>> Running depends in emulators/simh at 1764801494.10 last junk was in x11/xfce4/mousepad /usr/sbin/pkg_add -aI -Drepair unzip-6.0p18 was: /usr/sbin/pkg_add -aI -Drepair gmake-4.4.1p0 unzip-6.0p18 /usr/sbin/pkg_add -aI -Drepair unzip-6.0p18 >>> Running show-prepare-results in emulators/simh at 1764801496.60 ===> emulators/simh ===> Building from scratch simh-3.9.0p3 ===> simh-3.9.0p3 depends on: gmake-* -> gmake-4.4.1p0 ===> simh-3.9.0p3 depends on: unzip-* -> unzip-6.0p18 ===> Verifying specs: c m pcap pthread ===> found c.102.2 m.10.1 pcap.10.0 pthread.28.1 gmake-4.4.1p0 unzip-6.0p18 Don't run junk because nojunk in x11/qt6/qtquick3d (Junk lock released for exopi-6 at 1764801497.23) distfiles size=3103657 >>> Running patch in emulators/simh at 1764801497.28 ===> emulators/simh ===> Checking files for simh-3.9.0p3 `/exopi-cvs/ports/distfiles/simhv39-0.zip' is up to date. >> (SHA256) all files: OK ===> Extracting for simh-3.9.0p3 ===> Patching for simh-3.9.0p3 ===> Applying OpenBSD patch patch-AltairZ80_i86_decode_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- AltairZ80/i86_decode.c.orig Thu Feb 18 15:20:53 2021 |+++ AltairZ80/i86_decode.c Thu Feb 18 15:21:15 2021 -------------------------- Patching file AltairZ80/i86_decode.c using Plan A... Hunk #1 succeeded at 46. done ===> Applying OpenBSD patch patch-AltairZ80_i86_h Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- AltairZ80/i86.h.orig Thu Feb 18 15:18:56 2021 |+++ AltairZ80/i86.h Thu Feb 18 15:19:43 2021 -------------------------- Patching file AltairZ80/i86.h using Plan A... Hunk #1 succeeded at 215. done ===> Applying OpenBSD patch patch-AltairZ80_i86_ops_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- AltairZ80/i86_ops.c.orig Thu Feb 18 15:22:11 2021 |+++ AltairZ80/i86_ops.c Thu Feb 18 15:22:29 2021 -------------------------- Patching file AltairZ80/i86_ops.c using Plan A... Hunk #1 succeeded at 110. done ===> Applying OpenBSD patch patch-PDP11_pdp11_hk_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- PDP11/pdp11_hk.c.orig Mon Mar 19 17:41:44 2012 |+++ PDP11/pdp11_hk.c Wed Jun 13 06:36:24 2012 -------------------------- Patching file PDP11/pdp11_hk.c using Plan A... Hunk #1 succeeded at 905. done ===> Applying OpenBSD patch patch-PDP11_pdp11_vh_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- PDP11/pdp11_vh.c.orig Mon Mar 19 18:15:14 2012 |+++ PDP11/pdp11_vh.c Wed Jun 13 06:37:14 2012 -------------------------- Patching file PDP11/pdp11_vh.c using Plan A... Hunk #1 succeeded at 95. done ===> Applying OpenBSD patch patch-VAX_vax780_sbi_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- VAX/vax780_sbi.c.orig Mon Mar 19 18:08:46 2012 |+++ VAX/vax780_sbi.c Wed Jun 13 06:39:29 2012 -------------------------- Patching file VAX/vax780_sbi.c using Plan A... Hunk #1 succeeded at 35. Hunk #2 succeeded at 690. done ===> Applying OpenBSD patch patch-VAX_vax_sysdev_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- VAX/vax_sysdev.c.orig Sun Apr 29 19:02:06 2012 |+++ VAX/vax_sysdev.c Wed Jun 13 06:36:24 2012 -------------------------- Patching file VAX/vax_sysdev.c using Plan A... Hunk #1 succeeded at 54. Hunk #2 succeeded at 1556. done ===> Applying OpenBSD patch patch-VAX_vaxmod_defs_h Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- VAX/vaxmod_defs.h.orig Wed Oct 24 10:15:03 2012 |+++ VAX/vaxmod_defs.h Wed Oct 24 10:16:25 2012 -------------------------- Patching file VAX/vaxmod_defs.h using Plan A... Hunk #1 succeeded at 114. done ===> Applying OpenBSD patch patch-makefile Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- makefile.orig Mon Apr 23 16:28:04 2012 |+++ makefile Fri Feb 19 07:57:30 2021 -------------------------- Patching file makefile using Plan A... Hunk #1 succeeded at 300. Hunk #2 succeeded at 523. Hunk #3 succeeded at 570. done ===> Applying OpenBSD patch patch-scp_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- scp.c.orig Sun Mar 25 11:57:18 2012 |+++ scp.c Fri Feb 19 07:08:06 2021 -------------------------- Patching file scp.c using Plan A... Hunk #1 succeeded at 269. Hunk #2 succeeded at 696. done ===> Applying OpenBSD patch patch-sim_console_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- sim_console.c.orig Sun Mar 18 08:40:08 2012 |+++ sim_console.c Wed Jun 13 06:36:24 2012 -------------------------- Patching file sim_console.c using Plan A... Hunk #1 succeeded at 112. done ===> Applying OpenBSD patch patch-sim_ether_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- sim_ether.c.orig Fri Mar 30 16:30:26 2012 |+++ sim_ether.c Wed Jun 13 06:47:21 2012 -------------------------- Patching file sim_ether.c using Plan A... Hunk #1 succeeded at 1750. done ===> Applying OpenBSD patch patch-sim_fio_c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- sim_fio.c.orig Sun Nov 20 03:55:26 2011 |+++ sim_fio.c Sun Nov 20 03:56:43 2011 -------------------------- Patching file sim_fio.c using Plan A... Hunk #1 succeeded at 302. done ===> Compiler link: clang -> /usr/bin/clang ===> Compiler link: clang++ -> /usr/bin/clang++ ===> Compiler link: cc -> /usr/bin/cc ===> Compiler link: c++ -> /usr/bin/c++ >>> Running configure in emulators/simh at 1764801498.19 ===> emulators/simh ===> Generating configure for simh-3.9.0p3 ===> Configuring for simh-3.9.0p3 >>> Running build in emulators/simh at 1764801498.44 ===> emulators/simh ===> Building for simh-3.9.0p3 lib paths are: /usr/lib /usr/X11R6/lib /usr/local/lib using libm: /usr/lib/libm.a using libpthread: /usr/lib/libpthread.a /usr/include/pthread.h using libdl: /usr/include/dlfcn.h using libpcap: /usr/lib/libpcap.a /usr/include/pcap.h *** *** all Simulators being built with: *** - compiler optimizations and no debugging support. GCC Version: . *** - static networking support using OpenBSD provided libpcap components. *** cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so PDP1/pdp1_lp.c PDP1/pdp1_cpu.c PDP1/pdp1_stddev.c PDP1/pdp1_sys.c PDP1/pdp1_dt.c PDP1/pdp1_drm.c PDP1/pdp1_clk.c PDP1/pdp1_dcs.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I PDP1 -o BIN/pdp1 -lm -lpthread -lpcap PDP1/pdp1_cpu.c:549:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 549 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ PDP1/pdp1_cpu.c:549:20: note: place parentheses around the assignment to silence this warning 549 | if (reason = sim_process_event ()) | ^ | ( ) PDP1/pdp1_cpu.c:549:20: note: use '==' to turn this assignment into an equality comparison 549 | if (reason = sim_process_event ()) | ^ | == PDP1/pdp1_cpu.c:613:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 613 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:613:20: note: place parentheses around the assignment to silence this warning 613 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:613:20: note: use '==' to turn this assignment into an equality comparison 613 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:615:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 615 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:615:20: note: place parentheses around the assignment to silence this warning 615 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:615:20: note: use '==' to turn this assignment into an equality comparison 615 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:621:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 621 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:621:20: note: place parentheses around the assignment to silence this warning 621 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:621:20: note: use '==' to turn this assignment into an equality comparison 621 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:623:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 623 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:623:20: note: place parentheses around the assignment to silence this warning 623 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:623:20: note: use '==' to turn this assignment into an equality comparison 623 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:629:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 629 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:629:20: note: place parentheses around the assignment to silence this warning 629 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:629:20: note: use '==' to turn this assignment into an equality comparison 629 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:631:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 631 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:631:20: note: place parentheses around the assignment to silence this warning 631 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:631:20: note: use '==' to turn this assignment into an equality comparison 631 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:641:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 641 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:641:20: note: place parentheses around the assignment to silence this warning 641 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:641:20: note: use '==' to turn this assignment into an equality comparison 641 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:643:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 643 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:643:20: note: place parentheses around the assignment to silence this warning 643 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:643:20: note: use '==' to turn this assignment into an equality comparison 643 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:651:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 651 | if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~ PDP1/pdp1_cpu.c:651:24: note: place parentheses around the assignment to silence this warning 651 | if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:651:24: note: use '==' to turn this assignment into an equality comparison 651 | if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:653:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 653 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:653:24: note: place parentheses around the assignment to silence this warning 653 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:653:24: note: use '==' to turn this assignment into an equality comparison 653 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:662:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 662 | if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~ PDP1/pdp1_cpu.c:662:24: note: place parentheses around the assignment to silence this warning 662 | if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:662:24: note: use '==' to turn this assignment into an equality comparison 662 | if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:664:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 664 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:664:24: note: place parentheses around the assignment to silence this warning 664 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:664:24: note: use '==' to turn this assignment into an equality comparison 664 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:686:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 686 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:686:20: note: place parentheses around the assignment to silence this warning 686 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:686:20: note: use '==' to turn this assignment into an equality comparison 686 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:688:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 688 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:688:20: note: place parentheses around the assignment to silence this warning 688 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:688:20: note: use '==' to turn this assignment into an equality comparison 688 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:694:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 694 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:694:20: note: place parentheses around the assignment to silence this warning 694 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:694:20: note: use '==' to turn this assignment into an equality comparison 694 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:696:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 696 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:696:20: note: place parentheses around the assignment to silence this warning 696 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:696:20: note: use '==' to turn this assignment into an equality comparison 696 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:702:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 702 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:702:20: note: place parentheses around the assignment to silence this warning 702 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:702:20: note: use '==' to turn this assignment into an equality comparison 702 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:709:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:709:20: note: place parentheses around the assignment to silence this warning 709 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:709:20: note: use '==' to turn this assignment into an equality comparison 709 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:711:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 711 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:711:20: note: place parentheses around the assignment to silence this warning 711 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:711:20: note: use '==' to turn this assignment into an equality comparison 711 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:718:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 718 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:718:20: note: place parentheses around the assignment to silence this warning 718 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:718:20: note: use '==' to turn this assignment into an equality comparison 718 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:720:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 720 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:720:20: note: place parentheses around the assignment to silence this warning 720 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:720:20: note: use '==' to turn this assignment into an equality comparison 720 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:727:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 727 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:727:20: note: place parentheses around the assignment to silence this warning 727 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:727:20: note: use '==' to turn this assignment into an equality comparison 727 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:734:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 734 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:734:20: note: place parentheses around the assignment to silence this warning 734 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:734:20: note: use '==' to turn this assignment into an equality comparison 734 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:758:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 758 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:758:24: note: place parentheses around the assignment to silence this warning 758 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:758:24: note: use '==' to turn this assignment into an equality comparison 758 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:760:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 760 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:760:24: note: place parentheses around the assignment to silence this warning 760 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:760:24: note: use '==' to turn this assignment into an equality comparison 760 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:772:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 772 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:772:20: note: place parentheses around the assignment to silence this warning 772 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:772:20: note: use '==' to turn this assignment into an equality comparison 772 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:774:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 774 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:774:20: note: place parentheses around the assignment to silence this warning 774 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:774:20: note: use '==' to turn this assignment into an equality comparison 774 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:787:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 787 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:787:20: note: place parentheses around the assignment to silence this warning 787 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:787:20: note: use '==' to turn this assignment into an equality comparison 787 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:789:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 789 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:789:20: note: place parentheses around the assignment to silence this warning 789 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:789:20: note: use '==' to turn this assignment into an equality comparison 789 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:801:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 801 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:801:20: note: place parentheses around the assignment to silence this warning 801 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:801:20: note: use '==' to turn this assignment into an equality comparison 801 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:803:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 803 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:803:20: note: place parentheses around the assignment to silence this warning 803 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:803:20: note: use '==' to turn this assignment into an equality comparison 803 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:813:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 813 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:813:20: note: place parentheses around the assignment to silence this warning 813 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:813:20: note: use '==' to turn this assignment into an equality comparison 813 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:815:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 815 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:815:20: note: place parentheses around the assignment to silence this warning 815 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:815:20: note: use '==' to turn this assignment into an equality comparison 815 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:827:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 827 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:827:20: note: place parentheses around the assignment to silence this warning 827 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:827:20: note: use '==' to turn this assignment into an equality comparison 827 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:829:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 829 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:829:20: note: place parentheses around the assignment to silence this warning 829 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:829:20: note: use '==' to turn this assignment into an equality comparison 829 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:836:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 836 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:836:20: note: place parentheses around the assignment to silence this warning 836 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:836:20: note: use '==' to turn this assignment into an equality comparison 836 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:838:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 838 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:838:20: note: place parentheses around the assignment to silence this warning 838 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:838:20: note: use '==' to turn this assignment into an equality comparison 838 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:866:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 866 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:866:24: note: place parentheses around the assignment to silence this warning 866 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:866:24: note: use '==' to turn this assignment into an equality comparison 866 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:874:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 874 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:874:20: note: place parentheses around the assignment to silence this warning 874 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:874:20: note: use '==' to turn this assignment into an equality comparison 874 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:892:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 892 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:892:20: note: place parentheses around the assignment to silence this warning 892 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:892:20: note: use '==' to turn this assignment into an equality comparison 892 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:894:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 894 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:894:20: note: place parentheses around the assignment to silence this warning 894 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:894:20: note: use '==' to turn this assignment into an equality comparison 894 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:922:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 922 | if (reason = Ea (IR)) /* MA <- eff addr */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:922:20: note: place parentheses around the assignment to silence this warning 922 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | ( ) PDP1/pdp1_cpu.c:922:20: note: use '==' to turn this assignment into an equality comparison 922 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^ | == PDP1/pdp1_cpu.c:924:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 924 | if (reason = Read ()) /* MB <- data */ | ~~~~~~~^~~~~~~~~ PDP1/pdp1_cpu.c:924:20: note: place parentheses around the assignment to silence this warning 924 | if (reason = Read ()) /* MB <- data */ | ^ | ( ) PDP1/pdp1_cpu.c:924:20: note: use '==' to turn this assignment into an equality comparison 924 | if (reason = Read ()) /* MB <- data */ | ^ | == PDP1/pdp1_cpu.c:1365:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1365 | if (r = Read ()) /* read; err? */ | ~~^~~~~~~~~ PDP1/pdp1_cpu.c:1365:15: note: place parentheses around the assignment to silence this warning 1365 | if (r = Read ()) /* read; err? */ | ^ | ( ) PDP1/pdp1_cpu.c:1365:15: note: use '==' to turn this assignment into an equality comparison 1365 | if (r = Read ()) /* read; err? */ | ^ | == PDP1/pdp1_cpu.c:1371:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1371 | if (r = Read ()) /* get ind word */ | ~~^~~~~~~~~ PDP1/pdp1_cpu.c:1371:19: note: place parentheses around the assignment to silence this warning 1371 | if (r = Read ()) /* get ind word */ | ^ | ( ) PDP1/pdp1_cpu.c:1371:19: note: use '==' to turn this assignment into an equality comparison 1371 | if (r = Read ()) /* get ind word */ | ^ | == PDP1/pdp1_cpu.c:1395:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1395 | if (r = Read ()) /* read; err? */ | ~~^~~~~~~~~ PDP1/pdp1_cpu.c:1395:11: note: place parentheses around the assignment to silence this warning 1395 | if (r = Read ()) /* read; err? */ | ^ | ( ) PDP1/pdp1_cpu.c:1395:11: note: use '==' to turn this assignment into an equality comparison 1395 | if (r = Read ()) /* read; err? */ | ^ | == PDP1/pdp1_cpu.c:1400:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1400 | if (r = Read ()) /* get ind word */ | ~~^~~~~~~~~ PDP1/pdp1_cpu.c:1400:15: note: place parentheses around the assignment to silence this warning 1400 | if (r = Read ()) /* get ind word */ | ^ | ( ) PDP1/pdp1_cpu.c:1400:15: note: use '==' to turn this assignment into an equality comparison 1400 | if (r = Read ()) /* get ind word */ | ^ | == 48 warnings generated. PDP1/pdp1_dcs.c:254:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 254 | if (c = tmxr_getc_ln (&dcs_ldsc[ln])) { /* get char */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP1/pdp1_dcs.c:254:15: note: place parentheses around the assignment to silence this warning 254 | if (c = tmxr_getc_ln (&dcs_ldsc[ln])) { /* get char */ | ^ | ( ) PDP1/pdp1_dcs.c:254:15: note: use '==' to turn this assignment into an equality comparison 254 | if (c = tmxr_getc_ln (&dcs_ldsc[ln])) { /* get char */ | ^ | == 1 warning generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-cb5ef7.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-cb5ef7.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-89581c.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP4 -I PDP18B -o BIN/pdp4 -lm -lpthread -lpcap PDP18B/pdp18b_cpu.c:607:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 607 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_cpu.c:607:20: note: place parentheses around the assignment to silence this warning 607 | if (reason = sim_process_event ()) | ^ | ( ) PDP18B/pdp18b_cpu.c:607:20: note: use '==' to turn this assignment into an equality comparison 607 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. PDP18B/pdp18b_mt.c:356:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:356:16: note: place parentheses around the assignment to silence this warning 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:356:16: note: use '==' to turn this assignment into an equality comparison 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^ | == PDP18B/pdp18b_mt.c:366:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:366:16: note: place parentheses around the assignment to silence this warning 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:366:16: note: use '==' to turn this assignment into an equality comparison 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP18B/pdp18b_mt.c:375:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:375:20: note: place parentheses around the assignment to silence this warning 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:375:20: note: use '==' to turn this assignment into an equality comparison 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == PDP18B/pdp18b_mt.c:385:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:385:20: note: place parentheses around the assignment to silence this warning 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:385:20: note: use '==' to turn this assignment into an equality comparison 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == 4 warnings generated. PDP18B/pdp18b_stddev.c:597:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 597 | while (temp = temp & (temp - 1)) | ~~~~~^~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_stddev.c:597:21: note: place parentheses around the assignment to silence this warning 597 | while (temp = temp & (temp - 1)) | ^ | ( ) PDP18B/pdp18b_stddev.c:597:21: note: use '==' to turn this assignment into an equality comparison 597 | while (temp = temp & (temp - 1)) | ^ | == 1 warning generated. PDP18B/pdp18b_sys.c:1012:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1012 | if (sp = (inst & 03730)) | ~~~^~~~~~~~~~~~~~~~ PDP18B/pdp18b_sys.c:1012:20: note: place parentheses around the assignment to silence this warning 1012 | if (sp = (inst & 03730)) | ^ | ( ) PDP18B/pdp18b_sys.c:1012:20: note: use '==' to turn this assignment into an equality comparison 1012 | if (sp = (inst & 03730)) | ^ | == 1 warning generated. PDP18B/pdp18b_tt1.c:225:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_tt1.c:225:18: note: place parentheses around the assignment to silence this warning 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | ( ) PDP18B/pdp18b_tt1.c:225:18: note: use '==' to turn this assignment into an equality comparison 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | == 1 warning generated. PDP18B/pdp18b_fpp.c:256:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:256:17: note: place parentheses around the assignment to silence this warning 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:256:17: note: use '==' to turn this assignment into an equality comparison 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:265:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:265:17: note: place parentheses around the assignment to silence this warning 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:265:17: note: use '==' to turn this assignment into an equality comparison 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:273:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:273:17: note: place parentheses around the assignment to silence this warning 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:273:17: note: use '==' to turn this assignment into an equality comparison 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:281:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:281:17: note: place parentheses around the assignment to silence this warning 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:281:17: note: use '==' to turn this assignment into an equality comparison 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:283:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:283:17: note: place parentheses around the assignment to silence this warning 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:283:17: note: use '==' to turn this assignment into an equality comparison 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:291:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:291:17: note: place parentheses around the assignment to silence this warning 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:291:17: note: use '==' to turn this assignment into an equality comparison 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:299:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:299:17: note: place parentheses around the assignment to silence this warning 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:299:17: note: use '==' to turn this assignment into an equality comparison 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:312:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:312:17: note: place parentheses around the assignment to silence this warning 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:312:17: note: use '==' to turn this assignment into an equality comparison 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:320:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:320:17: note: place parentheses around the assignment to silence this warning 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:320:17: note: use '==' to turn this assignment into an equality comparison 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:326:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:326:17: note: place parentheses around the assignment to silence this warning 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:326:17: note: use '==' to turn this assignment into an equality comparison 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:340:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 340 | if (sta = Read (ar, &dat, RD)) | ~~~~^~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:340:21: note: place parentheses around the assignment to silence this warning 340 | if (sta = Read (ar, &dat, RD)) | ^ | ( ) PDP18B/pdp18b_fpp.c:340:21: note: use '==' to turn this assignment into an equality comparison 340 | if (sta = Read (ar, &dat, RD)) | ^ | == PDP18B/pdp18b_fpp.c:348:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:348:17: note: place parentheses around the assignment to silence this warning 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:348:17: note: use '==' to turn this assignment into an equality comparison 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:432:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:432:13: note: place parentheses around the assignment to silence this warning 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^ | ( ) PDP18B/pdp18b_fpp.c:432:13: note: use '==' to turn this assignment into an equality comparison 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^ | == 13 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-e6bcdf.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-e6bcdf.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-362a3b.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP7 -I PDP18B -o BIN/pdp7 -lm -lpthread -lpcap PDP18B/pdp18b_cpu.c:607:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 607 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_cpu.c:607:20: note: place parentheses around the assignment to silence this warning 607 | if (reason = sim_process_event ()) | ^ | ( ) PDP18B/pdp18b_cpu.c:607:20: note: use '==' to turn this assignment into an equality comparison 607 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. PDP18B/pdp18b_mt.c:356:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:356:16: note: place parentheses around the assignment to silence this warning 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:356:16: note: use '==' to turn this assignment into an equality comparison 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^ | == PDP18B/pdp18b_mt.c:366:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:366:16: note: place parentheses around the assignment to silence this warning 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:366:16: note: use '==' to turn this assignment into an equality comparison 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP18B/pdp18b_mt.c:375:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:375:20: note: place parentheses around the assignment to silence this warning 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:375:20: note: use '==' to turn this assignment into an equality comparison 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == PDP18B/pdp18b_mt.c:385:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:385:20: note: place parentheses around the assignment to silence this warning 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:385:20: note: use '==' to turn this assignment into an equality comparison 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == 4 warnings generated. PDP18B/pdp18b_stddev.c:597:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 597 | while (temp = temp & (temp - 1)) | ~~~~~^~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_stddev.c:597:21: note: place parentheses around the assignment to silence this warning 597 | while (temp = temp & (temp - 1)) | ^ | ( ) PDP18B/pdp18b_stddev.c:597:21: note: use '==' to turn this assignment into an equality comparison 597 | while (temp = temp & (temp - 1)) | ^ | == 1 warning generated. PDP18B/pdp18b_sys.c:1012:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1012 | if (sp = (inst & 03730)) | ~~~^~~~~~~~~~~~~~~~ PDP18B/pdp18b_sys.c:1012:20: note: place parentheses around the assignment to silence this warning 1012 | if (sp = (inst & 03730)) | ^ | ( ) PDP18B/pdp18b_sys.c:1012:20: note: use '==' to turn this assignment into an equality comparison 1012 | if (sp = (inst & 03730)) | ^ | == 1 warning generated. PDP18B/pdp18b_tt1.c:225:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_tt1.c:225:18: note: place parentheses around the assignment to silence this warning 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | ( ) PDP18B/pdp18b_tt1.c:225:18: note: use '==' to turn this assignment into an equality comparison 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | == 1 warning generated. PDP18B/pdp18b_fpp.c:256:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:256:17: note: place parentheses around the assignment to silence this warning 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:256:17: note: use '==' to turn this assignment into an equality comparison 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:265:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:265:17: note: place parentheses around the assignment to silence this warning 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:265:17: note: use '==' to turn this assignment into an equality comparison 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:273:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:273:17: note: place parentheses around the assignment to silence this warning 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:273:17: note: use '==' to turn this assignment into an equality comparison 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:281:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:281:17: note: place parentheses around the assignment to silence this warning 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:281:17: note: use '==' to turn this assignment into an equality comparison 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:283:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:283:17: note: place parentheses around the assignment to silence this warning 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:283:17: note: use '==' to turn this assignment into an equality comparison 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:291:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:291:17: note: place parentheses around the assignment to silence this warning 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:291:17: note: use '==' to turn this assignment into an equality comparison 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:299:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:299:17: note: place parentheses around the assignment to silence this warning 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:299:17: note: use '==' to turn this assignment into an equality comparison 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:312:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:312:17: note: place parentheses around the assignment to silence this warning 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:312:17: note: use '==' to turn this assignment into an equality comparison 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:320:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:320:17: note: place parentheses around the assignment to silence this warning 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:320:17: note: use '==' to turn this assignment into an equality comparison 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:326:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:326:17: note: place parentheses around the assignment to silence this warning 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:326:17: note: use '==' to turn this assignment into an equality comparison 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:340:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 340 | if (sta = Read (ar, &dat, RD)) | ~~~~^~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:340:21: note: place parentheses around the assignment to silence this warning 340 | if (sta = Read (ar, &dat, RD)) | ^ | ( ) PDP18B/pdp18b_fpp.c:340:21: note: use '==' to turn this assignment into an equality comparison 340 | if (sta = Read (ar, &dat, RD)) | ^ | == PDP18B/pdp18b_fpp.c:348:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:348:17: note: place parentheses around the assignment to silence this warning 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:348:17: note: use '==' to turn this assignment into an equality comparison 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:432:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:432:13: note: place parentheses around the assignment to silence this warning 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^ | ( ) PDP18B/pdp18b_fpp.c:432:13: note: use '==' to turn this assignment into an equality comparison 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^ | == 13 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: sim_ether.c(/tmp/sim_ether-c3e014.o:(eth_mac_fmt)): warning: sprintf() is often misused, please use snprintf() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-eb46c3.o:(tmxr_attach)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: scp.c(/tmp/scp-f5358e.o:(main)): warning: strcat() is almost always misused, please use strlcat() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so PDP8/pdp8_cpu.c PDP8/pdp8_clk.c PDP8/pdp8_df.c PDP8/pdp8_dt.c PDP8/pdp8_lp.c PDP8/pdp8_mt.c PDP8/pdp8_pt.c PDP8/pdp8_rf.c PDP8/pdp8_rk.c PDP8/pdp8_rx.c PDP8/pdp8_sys.c PDP8/pdp8_tt.c PDP8/pdp8_ttx.c PDP8/pdp8_rl.c PDP8/pdp8_tsc.c PDP8/pdp8_td.c PDP8/pdp8_ct.c PDP8/pdp8_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I PDP8 -o BIN/pdp8 -lm -lpthread -lpcap PDP8/pdp8_cpu.c:347:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 347 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ PDP8/pdp8_cpu.c:347:20: note: place parentheses around the assignment to silence this warning 347 | if (reason = sim_process_event ()) | ^ | ( ) PDP8/pdp8_cpu.c:347:20: note: use '==' to turn this assignment into an equality comparison 347 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. PDP8/pdp8_dt.c:967:57: warning: '/*' within block comment [-Wcomment] 967 | /* /* ignore hdr */ | ^ 1 warning generated. PDP8/pdp8_mt.c:123:57: warning: '/*' within block comment [-Wcomment] 123 | /* #define STA_BAD 00020 /* bad tape?? */ | ^ PDP8/pdp8_mt.c:456:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP8/pdp8_mt.c:456:16: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ^ | ( ) PDP8/pdp8_mt.c:456:16: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ^ | == PDP8/pdp8_mt.c:464:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 464 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP8/pdp8_mt.c:464:16: note: place parentheses around the assignment to silence this warning 464 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP8/pdp8_mt.c:464:16: note: use '==' to turn this assignment into an equality comparison 464 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP8/pdp8_mt.c:471:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 471 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP8/pdp8_mt.c:471:20: note: place parentheses around the assignment to silence this warning 471 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) PDP8/pdp8_mt.c:471:20: note: use '==' to turn this assignment into an equality comparison 471 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == PDP8/pdp8_mt.c:481:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 481 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP8/pdp8_mt.c:481:20: note: place parentheses around the assignment to silence this warning 481 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) PDP8/pdp8_mt.c:481:20: note: use '==' to turn this assignment into an equality comparison 481 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == 5 warnings generated. PDP8/pdp8_ttx.c:236:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 236 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP8/pdp8_ttx.c:236:18: note: place parentheses around the assignment to silence this warning 236 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | ( ) PDP8/pdp8_ttx.c:236:18: note: use '==' to turn this assignment into an equality comparison 236 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | == 1 warning generated. PDP8/pdp8_ct.c:273:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 273 | if (uptr = ct_busy ()) /* op in progress? */ | ~~~~~^~~~~~~~~~~~ PDP8/pdp8_ct.c:273:18: note: place parentheses around the assignment to silence this warning 273 | if (uptr = ct_busy ()) /* op in progress? */ | ^ | ( ) PDP8/pdp8_ct.c:273:18: note: use '==' to turn this assignment into an equality comparison 273 | if (uptr = ct_busy ()) /* op in progress? */ | ^ | == PDP8/pdp8_ct.c:436:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 436 | if (st = sim_tape_wrrecf (uptr, ct_xb, ct_bptr)) /* write, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP8/pdp8_ct.c:436:19: note: place parentheses around the assignment to silence this warning 436 | if (st = sim_tape_wrrecf (uptr, ct_xb, ct_bptr)) /* write, err? */ | ^ | ( ) PDP8/pdp8_ct.c:436:19: note: use '==' to turn this assignment into an equality comparison 436 | if (st = sim_tape_wrrecf (uptr, ct_xb, ct_bptr)) /* write, err? */ | ^ | == PDP8/pdp8_ct.c:455:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 455 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP8/pdp8_ct.c:455:16: note: place parentheses around the assignment to silence this warning 455 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP8/pdp8_ct.c:455:16: note: use '==' to turn this assignment into an equality comparison 455 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP8/pdp8_ct.c:465:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 465 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP8/pdp8_ct.c:465:16: note: place parentheses around the assignment to silence this warning 465 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ^ | ( ) PDP8/pdp8_ct.c:465:16: note: use '==' to turn this assignment into an equality comparison 465 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ^ | == 4 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-fc64e2.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-fc64e2.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-95048b.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP9 -I PDP18B -o BIN/pdp9 -lm -lpthread -lpcap PDP18B/pdp18b_dt.c:1150:57: warning: '/*' within block comment [-Wcomment] 1150 | /* /* ignore hdr */ | ^ 1 warning generated. PDP18B/pdp18b_cpu.c:607:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 607 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_cpu.c:607:20: note: place parentheses around the assignment to silence this warning 607 | if (reason = sim_process_event ()) | ^ | ( ) PDP18B/pdp18b_cpu.c:607:20: note: use '==' to turn this assignment into an equality comparison 607 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. PDP18B/pdp18b_mt.c:356:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:356:16: note: place parentheses around the assignment to silence this warning 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:356:16: note: use '==' to turn this assignment into an equality comparison 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^ | == PDP18B/pdp18b_mt.c:366:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:366:16: note: place parentheses around the assignment to silence this warning 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:366:16: note: use '==' to turn this assignment into an equality comparison 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP18B/pdp18b_mt.c:375:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:375:20: note: place parentheses around the assignment to silence this warning 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:375:20: note: use '==' to turn this assignment into an equality comparison 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == PDP18B/pdp18b_mt.c:385:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:385:20: note: place parentheses around the assignment to silence this warning 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:385:20: note: use '==' to turn this assignment into an equality comparison 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == 4 warnings generated. PDP18B/pdp18b_stddev.c:597:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 597 | while (temp = temp & (temp - 1)) | ~~~~~^~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_stddev.c:597:21: note: place parentheses around the assignment to silence this warning 597 | while (temp = temp & (temp - 1)) | ^ | ( ) PDP18B/pdp18b_stddev.c:597:21: note: use '==' to turn this assignment into an equality comparison 597 | while (temp = temp & (temp - 1)) | ^ | == 1 warning generated. PDP18B/pdp18b_sys.c:1012:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1012 | if (sp = (inst & 03730)) | ~~~^~~~~~~~~~~~~~~~ PDP18B/pdp18b_sys.c:1012:20: note: place parentheses around the assignment to silence this warning 1012 | if (sp = (inst & 03730)) | ^ | ( ) PDP18B/pdp18b_sys.c:1012:20: note: use '==' to turn this assignment into an equality comparison 1012 | if (sp = (inst & 03730)) | ^ | == 1 warning generated. PDP18B/pdp18b_tt1.c:225:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_tt1.c:225:18: note: place parentheses around the assignment to silence this warning 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | ( ) PDP18B/pdp18b_tt1.c:225:18: note: use '==' to turn this assignment into an equality comparison 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | == 1 warning generated. PDP18B/pdp18b_fpp.c:256:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:256:17: note: place parentheses around the assignment to silence this warning 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:256:17: note: use '==' to turn this assignment into an equality comparison 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:265:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:265:17: note: place parentheses around the assignment to silence this warning 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:265:17: note: use '==' to turn this assignment into an equality comparison 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:273:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:273:17: note: place parentheses around the assignment to silence this warning 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:273:17: note: use '==' to turn this assignment into an equality comparison 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:281:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:281:17: note: place parentheses around the assignment to silence this warning 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:281:17: note: use '==' to turn this assignment into an equality comparison 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:283:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:283:17: note: place parentheses around the assignment to silence this warning 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:283:17: note: use '==' to turn this assignment into an equality comparison 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:291:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:291:17: note: place parentheses around the assignment to silence this warning 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:291:17: note: use '==' to turn this assignment into an equality comparison 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:299:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:299:17: note: place parentheses around the assignment to silence this warning 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:299:17: note: use '==' to turn this assignment into an equality comparison 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:312:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:312:17: note: place parentheses around the assignment to silence this warning 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:312:17: note: use '==' to turn this assignment into an equality comparison 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:320:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:320:17: note: place parentheses around the assignment to silence this warning 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:320:17: note: use '==' to turn this assignment into an equality comparison 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:326:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:326:17: note: place parentheses around the assignment to silence this warning 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:326:17: note: use '==' to turn this assignment into an equality comparison 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:340:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 340 | if (sta = Read (ar, &dat, RD)) | ~~~~^~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:340:21: note: place parentheses around the assignment to silence this warning 340 | if (sta = Read (ar, &dat, RD)) | ^ | ( ) PDP18B/pdp18b_fpp.c:340:21: note: use '==' to turn this assignment into an equality comparison 340 | if (sta = Read (ar, &dat, RD)) | ^ | == PDP18B/pdp18b_fpp.c:348:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:348:17: note: place parentheses around the assignment to silence this warning 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:348:17: note: use '==' to turn this assignment into an equality comparison 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:432:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:432:13: note: place parentheses around the assignment to silence this warning 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^ | ( ) PDP18B/pdp18b_fpp.c:432:13: note: use '==' to turn this assignment into an equality comparison 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^ | == 13 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-1e1770.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-3e0237.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() ld: warning: scp.c(/tmp/scp-1e1770.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP15 -I PDP18B -o BIN/pdp15 -lm -lpthread -lpcap PDP18B/pdp18b_dt.c:1150:57: warning: '/*' within block comment [-Wcomment] 1150 | /* /* ignore hdr */ | ^ 1 warning generated. PDP18B/pdp18b_cpu.c:607:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 607 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_cpu.c:607:20: note: place parentheses around the assignment to silence this warning 607 | if (reason = sim_process_event ()) | ^ | ( ) PDP18B/pdp18b_cpu.c:607:20: note: use '==' to turn this assignment into an equality comparison 607 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. PDP18B/pdp18b_mt.c:356:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:356:16: note: place parentheses around the assignment to silence this warning 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:356:16: note: use '==' to turn this assignment into an equality comparison 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^ | == PDP18B/pdp18b_mt.c:366:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:366:16: note: place parentheses around the assignment to silence this warning 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:366:16: note: use '==' to turn this assignment into an equality comparison 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP18B/pdp18b_mt.c:375:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:375:20: note: place parentheses around the assignment to silence this warning 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:375:20: note: use '==' to turn this assignment into an equality comparison 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == PDP18B/pdp18b_mt.c:385:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_mt.c:385:20: note: place parentheses around the assignment to silence this warning 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) PDP18B/pdp18b_mt.c:385:20: note: use '==' to turn this assignment into an equality comparison 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == 4 warnings generated. PDP18B/pdp18b_stddev.c:597:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 597 | while (temp = temp & (temp - 1)) | ~~~~~^~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_stddev.c:597:21: note: place parentheses around the assignment to silence this warning 597 | while (temp = temp & (temp - 1)) | ^ | ( ) PDP18B/pdp18b_stddev.c:597:21: note: use '==' to turn this assignment into an equality comparison 597 | while (temp = temp & (temp - 1)) | ^ | == 1 warning generated. PDP18B/pdp18b_sys.c:1012:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1012 | if (sp = (inst & 03730)) | ~~~^~~~~~~~~~~~~~~~ PDP18B/pdp18b_sys.c:1012:20: note: place parentheses around the assignment to silence this warning 1012 | if (sp = (inst & 03730)) | ^ | ( ) PDP18B/pdp18b_sys.c:1012:20: note: use '==' to turn this assignment into an equality comparison 1012 | if (sp = (inst & 03730)) | ^ | == 1 warning generated. PDP18B/pdp18b_tt1.c:225:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_tt1.c:225:18: note: place parentheses around the assignment to silence this warning 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | ( ) PDP18B/pdp18b_tt1.c:225:18: note: use '==' to turn this assignment into an equality comparison 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^ | == 1 warning generated. PDP18B/pdp18b_fpp.c:256:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:256:17: note: place parentheses around the assignment to silence this warning 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:256:17: note: use '==' to turn this assignment into an equality comparison 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:265:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:265:17: note: place parentheses around the assignment to silence this warning 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:265:17: note: use '==' to turn this assignment into an equality comparison 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:273:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:273:17: note: place parentheses around the assignment to silence this warning 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:273:17: note: use '==' to turn this assignment into an equality comparison 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:281:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:281:17: note: place parentheses around the assignment to silence this warning 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:281:17: note: use '==' to turn this assignment into an equality comparison 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:283:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:283:17: note: place parentheses around the assignment to silence this warning 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:283:17: note: use '==' to turn this assignment into an equality comparison 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:291:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:291:17: note: place parentheses around the assignment to silence this warning 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:291:17: note: use '==' to turn this assignment into an equality comparison 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:299:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:299:17: note: place parentheses around the assignment to silence this warning 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:299:17: note: use '==' to turn this assignment into an equality comparison 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:312:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:312:17: note: place parentheses around the assignment to silence this warning 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:312:17: note: use '==' to turn this assignment into an equality comparison 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:320:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:320:17: note: place parentheses around the assignment to silence this warning 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:320:17: note: use '==' to turn this assignment into an equality comparison 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:326:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:326:17: note: place parentheses around the assignment to silence this warning 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | ( ) PDP18B/pdp18b_fpp.c:326:17: note: use '==' to turn this assignment into an equality comparison 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^ | == PDP18B/pdp18b_fpp.c:340:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 340 | if (sta = Read (ar, &dat, RD)) | ~~~~^~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:340:21: note: place parentheses around the assignment to silence this warning 340 | if (sta = Read (ar, &dat, RD)) | ^ | ( ) PDP18B/pdp18b_fpp.c:340:21: note: use '==' to turn this assignment into an equality comparison 340 | if (sta = Read (ar, &dat, RD)) | ^ | == PDP18B/pdp18b_fpp.c:348:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:348:17: note: place parentheses around the assignment to silence this warning 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | ( ) PDP18B/pdp18b_fpp.c:348:17: note: use '==' to turn this assignment into an equality comparison 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^ | == PDP18B/pdp18b_fpp.c:432:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP18B/pdp18b_fpp.c:432:13: note: place parentheses around the assignment to silence this warning 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^ | ( ) PDP18B/pdp18b_fpp.c:432:13: note: use '==' to turn this assignment into an equality comparison 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^ | == 13 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-8f256d.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-8f256d.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-ac40eb.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so PDP11/pdp11_fp.c PDP11/pdp11_cpu.c PDP11/pdp11_dz.c PDP11/pdp11_cis.c PDP11/pdp11_lp.c PDP11/pdp11_rk.c PDP11/pdp11_rl.c PDP11/pdp11_rp.c PDP11/pdp11_rx.c PDP11/pdp11_stddev.c PDP11/pdp11_sys.c PDP11/pdp11_tc.c PDP11/pdp11_tm.c PDP11/pdp11_ts.c PDP11/pdp11_io.c PDP11/pdp11_rq.c PDP11/pdp11_tq.c PDP11/pdp11_pclk.c PDP11/pdp11_ry.c PDP11/pdp11_pt.c PDP11/pdp11_hk.c PDP11/pdp11_xq.c PDP11/pdp11_xu.c PDP11/pdp11_vh.c PDP11/pdp11_rh.c PDP11/pdp11_tu.c PDP11/pdp11_cpumod.c PDP11/pdp11_cr.c PDP11/pdp11_rf.c PDP11/pdp11_dl.c PDP11/pdp11_ta.c PDP11/pdp11_rc.c PDP11/pdp11_kg.c PDP11/pdp11_ke.c PDP11/pdp11_dc.c PDP11/pdp11_io_lib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_PDP11 -I PDP11 -DUSE_NETWORK -I/usr/include/ -DUSE_TAP_NETWORK -DUSE_BSDTUNTAP -o BIN/pdp11 -lm -lpthread -lpcap PDP11/pdp11_fp.c:441:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 441 | if (sign = GET_SIGN_L (fac.l)) | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_fp.c:441:22: note: place parentheses around the assignment to silence this warning 441 | if (sign = GET_SIGN_L (fac.l)) | ^ | ( ) PDP11/pdp11_fp.c:441:22: note: use '==' to turn this assignment into an equality comparison 441 | if (sign = GET_SIGN_L (fac.l)) | ^ | == 1 warning generated. PDP11/pdp11_cpu.c:735:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 735 | if (t = trap_req & TRAP_ALL) { /* if a trap */ | ~~^~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cpu.c:735:15: note: place parentheses around the assignment to silence this warning 735 | if (t = trap_req & TRAP_ALL) { /* if a trap */ | ^ | ( ) PDP11/pdp11_cpu.c:735:15: note: use '==' to turn this assignment into an equality comparison 735 | if (t = trap_req & TRAP_ALL) { /* if a trap */ | ^ | == 1 warning generated. PDP11/pdp11_cis.c:1137:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1137 | if (dst.sign = GET_SIGN_L (result)) | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cis.c:1137:22: note: place parentheses around the assignment to silence this warning 1137 | if (dst.sign = GET_SIGN_L (result)) | ^ | ( ) PDP11/pdp11_cis.c:1137:22: note: use '==' to turn this assignment into an equality comparison 1137 | if (dst.sign = GET_SIGN_L (result)) | ^ | == PDP11/pdp11_cis.c:1270:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1270 | if (dst->val[i] = dst->val[i] & ~mask) /* test nz */ | ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cis.c:1270:21: note: place parentheses around the assignment to silence this warning 1270 | if (dst->val[i] = dst->val[i] & ~mask) /* test nz */ | ^ | ( ) PDP11/pdp11_cis.c:1270:21: note: use '==' to turn this assignment into an equality comparison 1270 | if (dst->val[i] = dst->val[i] & ~mask) /* test nz */ | ^ | == PDP11/pdp11_cis.c:1526:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1526 | if (s = sc * 4) { | ~~^~~~~~~~ PDP11/pdp11_cis.c:1526:7: note: place parentheses around the assignment to silence this warning 1526 | if (s = sc * 4) { | ^ | ( ) PDP11/pdp11_cis.c:1526:7: note: use '==' to turn this assignment into an equality comparison 1526 | if (s = sc * 4) { | ^ | == PDP11/pdp11_cis.c:1551:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1551 | if (s = sc * 4) { | ~~^~~~~~~~ PDP11/pdp11_cis.c:1551:7: note: place parentheses around the assignment to silence this warning 1551 | if (s = sc * 4) { | ^ | ( ) PDP11/pdp11_cis.c:1551:7: note: use '==' to turn this assignment into an equality comparison 1551 | if (s = sc * 4) { | ^ | == 4 warnings generated. PDP11/pdp11_rk.c:548:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 548 | if (t = Map_WriteW (ma, 2, &rkxb[wc - 1])) { /* store last */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rk.c:548:19: note: place parentheses around the assignment to silence this warning 548 | if (t = Map_WriteW (ma, 2, &rkxb[wc - 1])) { /* store last */ | ^ | ( ) PDP11/pdp11_rk.c:548:19: note: use '==' to turn this assignment into an equality comparison 548 | if (t = Map_WriteW (ma, 2, &rkxb[wc - 1])) { /* store last */ | ^ | == PDP11/pdp11_rk.c:554:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 554 | if (t = Map_WriteW (ma, wc << 1, rkxb)) { /* store buf */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rk.c:554:19: note: place parentheses around the assignment to silence this warning 554 | if (t = Map_WriteW (ma, wc << 1, rkxb)) { /* store buf */ | ^ | ( ) PDP11/pdp11_rk.c:554:19: note: use '==' to turn this assignment into an equality comparison 554 | if (t = Map_WriteW (ma, wc << 1, rkxb)) { /* store buf */ | ^ | == PDP11/pdp11_rk.c:563:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 563 | if (t = Map_ReadW (ma, 2, &comp)) { /* get 1st word */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rk.c:563:19: note: place parentheses around the assignment to silence this warning 563 | if (t = Map_ReadW (ma, 2, &comp)) { /* get 1st word */ | ^ | ( ) PDP11/pdp11_rk.c:563:19: note: use '==' to turn this assignment into an equality comparison 563 | if (t = Map_ReadW (ma, 2, &comp)) { /* get 1st word */ | ^ | == PDP11/pdp11_rk.c:571:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 571 | if (t = Map_ReadW (ma, wc << 1, rkxb)) { /* get buf */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rk.c:571:19: note: place parentheses around the assignment to silence this warning 571 | if (t = Map_ReadW (ma, wc << 1, rkxb)) { /* get buf */ | ^ | ( ) PDP11/pdp11_rk.c:571:19: note: use '==' to turn this assignment into an equality comparison 571 | if (t = Map_ReadW (ma, wc << 1, rkxb)) { /* get buf */ | ^ | == PDP11/pdp11_rk.c:587:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 587 | if (err = ferror (uptr->fileref)) { /* read error? */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rk.c:587:17: note: place parentheses around the assignment to silence this warning 587 | if (err = ferror (uptr->fileref)) { /* read error? */ | ^ | ( ) PDP11/pdp11_rk.c:587:17: note: use '==' to turn this assignment into an equality comparison 587 | if (err = ferror (uptr->fileref)) { /* read error? */ | ^ | == 5 warnings generated. PDP11/pdp11_sys.c:1074:56: warning: for loop has empty body [-Wempty-body] 1074 | (strcmp (opcode[i], gbuf) != 0) ; i++) ; | ^ PDP11/pdp11_sys.c:1074:56: note: put the semicolon on a separate line to silence this warning 1 warning generated. PDP11/pdp11_tc.c:995:57: warning: '/*' within block comment [-Wcomment] 995 | /* else /* ignore hdr */ | ^ 1 warning generated. PDP11/pdp11_tm.c:380:9: warning: '/*' within block comment [-Wcomment] 380 | /* else /* uncomment this else if rewind/unload don't set done */ | ^ PDP11/pdp11_tm.c:442:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 442 | if (t = Map_WriteB (xma, cbc, tmxb)) { /* copy buf to mem */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tm.c:442:15: note: place parentheses around the assignment to silence this warning 442 | if (t = Map_WriteB (xma, cbc, tmxb)) { /* copy buf to mem */ | ^ | ( ) PDP11/pdp11_tm.c:442:15: note: use '==' to turn this assignment into an equality comparison 442 | if (t = Map_WriteB (xma, cbc, tmxb)) { /* copy buf to mem */ | ^ | == PDP11/pdp11_tm.c:452:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 452 | if (t = Map_ReadB (xma, cbc, tmxb)) { /* copy mem to buf */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tm.c:452:15: note: place parentheses around the assignment to silence this warning 452 | if (t = Map_ReadB (xma, cbc, tmxb)) { /* copy mem to buf */ | ^ | ( ) PDP11/pdp11_tm.c:452:15: note: use '==' to turn this assignment into an equality comparison 452 | if (t = Map_ReadB (xma, cbc, tmxb)) { /* copy mem to buf */ | ^ | == PDP11/pdp11_tm.c:458:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 458 | if (st = sim_tape_wrrecf (uptr, tmxb, cbc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tm.c:458:16: note: place parentheses around the assignment to silence this warning 458 | if (st = sim_tape_wrrecf (uptr, tmxb, cbc)) /* write rec, err? */ | ^ | ( ) PDP11/pdp11_tm.c:458:16: note: use '==' to turn this assignment into an equality comparison 458 | if (st = sim_tape_wrrecf (uptr, tmxb, cbc)) /* write rec, err? */ | ^ | == PDP11/pdp11_tm.c:467:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 467 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tm.c:467:16: note: place parentheses around the assignment to silence this warning 467 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP11/pdp11_tm.c:467:16: note: use '==' to turn this assignment into an equality comparison 467 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP11/pdp11_tm.c:474:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 474 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* spc rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tm.c:474:20: note: place parentheses around the assignment to silence this warning 474 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* spc rec fwd, err? */ | ^ | ( ) PDP11/pdp11_tm.c:474:20: note: use '==' to turn this assignment into an equality comparison 474 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* spc rec fwd, err? */ | ^ | == PDP11/pdp11_tm.c:484:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 484 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* spc rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tm.c:484:20: note: place parentheses around the assignment to silence this warning 484 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* spc rec rev, err? */ | ^ | ( ) PDP11/pdp11_tm.c:484:20: note: use '==' to turn this assignment into an equality comparison 484 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* spc rec rev, err? */ | ^ | == 7 warnings generated. PDP11/pdp11_ts.c:493:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:493:12: note: place parentheses around the assignment to silence this warning 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | ( ) PDP11/pdp11_ts.c:493:12: note: use '==' to turn this assignment into an equality comparison 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | == PDP11/pdp11_ts.c:536:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:536:12: note: place parentheses around the assignment to silence this warning 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | ( ) PDP11/pdp11_ts.c:536:12: note: use '==' to turn this assignment into an equality comparison 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | == PDP11/pdp11_ts.c:669:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:669:8: note: place parentheses around the assignment to silence this warning 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ^ | ( ) PDP11/pdp11_ts.c:669:8: note: use '==' to turn this assignment into an equality comparison 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ^ | == PDP11/pdp11_ts.c:682:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:682:8: note: place parentheses around the assignment to silence this warning 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP11/pdp11_ts.c:682:8: note: use '==' to turn this assignment into an equality comparison 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == 4 warnings generated. PDP11/pdp11_io.c:376:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 376 | if (r = cpu_build_dib ()) /* build CPU entries */ | ~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_io.c:376:7: note: place parentheses around the assignment to silence this warning 376 | if (r = cpu_build_dib ()) /* build CPU entries */ | ^ | ( ) PDP11/pdp11_io.c:376:7: note: use '==' to turn this assignment into an equality comparison 376 | if (r = cpu_build_dib ()) /* build CPU entries */ | ^ | == PDP11/pdp11_io.c:382:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 382 | if (r = build_mbus_tab (dptr, dibp)) /* add to Mbus tab */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_io.c:382:19: note: place parentheses around the assignment to silence this warning 382 | if (r = build_mbus_tab (dptr, dibp)) /* add to Mbus tab */ | ^ | ( ) PDP11/pdp11_io.c:382:19: note: use '==' to turn this assignment into an equality comparison 382 | if (r = build_mbus_tab (dptr, dibp)) /* add to Mbus tab */ | ^ | == PDP11/pdp11_io.c:386:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 386 | if (r = build_ubus_tab (dptr, dibp)) /* add to Unibus tab */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_io.c:386:19: note: place parentheses around the assignment to silence this warning 386 | if (r = build_ubus_tab (dptr, dibp)) /* add to Unibus tab */ | ^ | ( ) PDP11/pdp11_io.c:386:19: note: use '==' to turn this assignment into an equality comparison 386 | if (r = build_ubus_tab (dptr, dibp)) /* add to Unibus tab */ | ^ | == 3 warnings generated. In file included from PDP11/pdp11_rq.c:99: PDP11/pdp11_mscp.h:213:57: warning: '/*' within block comment [-Wcomment] 213 | /* 5 /* reserved */ | ^ PDP11/pdp11_mscp.h:258:57: warning: '/*' within block comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:265:57: warning: '/*' within block comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:401:57: warning: '/*' within block comment [-Wcomment] 401 | /* 14 /* reserved */ | ^ PDP11/pdp11_mscp.h:402:57: warning: '/*' within block comment [-Wcomment] 402 | /* 15 /* reserved */ | ^ PDP11/pdp11_rq.c:1355:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1355:10: note: place parentheses around the assignment to silence this warning 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ^ | ( ) PDP11/pdp11_rq.c:1355:10: note: use '==' to turn this assignment into an equality comparison 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ^ | == PDP11/pdp11_rq.c:1368:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ~~~~^~~~~~~~~~~~ PDP11/pdp11_rq.c:1368:18: note: place parentheses around the assignment to silence this warning 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | ( ) PDP11/pdp11_rq.c:1368:18: note: use '==' to turn this assignment into an equality comparison 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | == PDP11/pdp11_rq.c:1369:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ~~~~~^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1369:21: note: place parentheses around the assignment to silence this warning 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ^ | ( ) PDP11/pdp11_rq.c:1369:21: note: use '==' to turn this assignment into an equality comparison 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ^ | == PDP11/pdp11_rq.c:1396:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1396:10: note: place parentheses around the assignment to silence this warning 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1396:10: note: use '==' to turn this assignment into an equality comparison 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1450:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1450:10: note: place parentheses around the assignment to silence this warning 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1450:10: note: use '==' to turn this assignment into an equality comparison 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1485:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1485:10: note: place parentheses around the assignment to silence this warning 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1485:10: note: use '==' to turn this assignment into an equality comparison 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1523:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1523:18: note: place parentheses around the assignment to silence this warning 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ^ | ( ) PDP11/pdp11_rq.c:1523:18: note: use '==' to turn this assignment into an equality comparison 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ^ | == PDP11/pdp11_rq.c:1550:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1550:10: note: place parentheses around the assignment to silence this warning 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1550:10: note: use '==' to turn this assignment into an equality comparison 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1579:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1579:10: note: place parentheses around the assignment to silence this warning 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1579:10: note: use '==' to turn this assignment into an equality comparison 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1613:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1613:10: note: place parentheses around the assignment to silence this warning 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1613:10: note: use '==' to turn this assignment into an equality comparison 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1657:57: warning: '/*' within block comment [-Wcomment] 1657 | /* if (lbn & 0xF0000000) return (ST_CMD | I_LBN); /* 'reasonable' lbn? */ | ^ PDP11/pdp11_rq.c:1728:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1728 | if (abc = tbc - t) { /* any xfer? */ | ~~~~^~~~~~~~~ PDP11/pdp11_rq.c:1728:13: note: place parentheses around the assignment to silence this warning 1728 | if (abc = tbc - t) { /* any xfer? */ | ^ | ( ) PDP11/pdp11_rq.c:1728:13: note: use '==' to turn this assignment into an equality comparison 1728 | if (abc = tbc - t) { /* any xfer? */ | ^ | == PDP11/pdp11_rq.c:1755:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1755:15: note: place parentheses around the assignment to silence this warning 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ^ | ( ) PDP11/pdp11_rq.c:1755:15: note: use '==' to turn this assignment into an equality comparison 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ^ | == PDP11/pdp11_rq.c:2589:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2589 | if (pkt = uptr->pktq) { | ~~~~^~~~~~~~~~~~ PDP11/pdp11_rq.c:2589:13: note: place parentheses around the assignment to silence this warning 2589 | if (pkt = uptr->pktq) { | ^ | ( ) PDP11/pdp11_rq.c:2589:13: note: use '==' to turn this assignment into an equality comparison 2589 | if (pkt = uptr->pktq) { | ^ | == PDP11/pdp11_rq.c:2593:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2593 | } while (pkt = cp->pak[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:2593:26: note: place parentheses around the assignment to silence this warning 2593 | } while (pkt = cp->pak[pkt].link); | ^ | ( ) PDP11/pdp11_rq.c:2593:26: note: use '==' to turn this assignment into an equality comparison 2593 | } while (pkt = cp->pak[pkt].link); | ^ | == PDP11/pdp11_rq.c:2620:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2620 | if (pkt = cp->freq) { | ~~~~^~~~~~~~~~ PDP11/pdp11_rq.c:2620:13: note: place parentheses around the assignment to silence this warning 2620 | if (pkt = cp->freq) { | ^ | ( ) PDP11/pdp11_rq.c:2620:13: note: use '==' to turn this assignment into an equality comparison 2620 | if (pkt = cp->freq) { | ^ | == PDP11/pdp11_rq.c:2633:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2633 | if (pkt = cp->rspq) { | ~~~~^~~~~~~~~~ PDP11/pdp11_rq.c:2633:13: note: place parentheses around the assignment to silence this warning 2633 | if (pkt = cp->rspq) { | ^ | ( ) PDP11/pdp11_rq.c:2633:13: note: use '==' to turn this assignment into an equality comparison 2633 | if (pkt = cp->rspq) { | ^ | == PDP11/pdp11_rq.c:2637:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2637 | } while (pkt = cp->pak[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:2637:26: note: place parentheses around the assignment to silence this warning 2637 | } while (pkt = cp->pak[pkt].link); | ^ | ( ) PDP11/pdp11_rq.c:2637:26: note: use '==' to turn this assignment into an equality comparison 2637 | } while (pkt = cp->pak[pkt].link); | ^ | == 23 warnings generated. In file included from PDP11/pdp11_tq.c:85: PDP11/pdp11_mscp.h:213:57: warning: '/*' within block comment [-Wcomment] 213 | /* 5 /* reserved */ | ^ PDP11/pdp11_mscp.h:258:57: warning: '/*' within block comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:265:57: warning: '/*' within block comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:401:57: warning: '/*' within block comment [-Wcomment] 401 | /* 14 /* reserved */ | ^ PDP11/pdp11_mscp.h:402:57: warning: '/*' within block comment [-Wcomment] 402 | /* 15 /* reserved */ | ^ PDP11/pdp11_tq.c:783:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:783:14: note: place parentheses around the assignment to silence this warning 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ^ | ( ) PDP11/pdp11_tq.c:783:14: note: use '==' to turn this assignment into an equality comparison 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ^ | == PDP11/pdp11_tq.c:789:57: warning: '/*' within block comment [-Wcomment] 789 | /* if (tq_cmf[cmd] & MD_CDL) /* clr cch lost? */ | ^ PDP11/pdp11_tq.c:861:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:861:10: note: place parentheses around the assignment to silence this warning 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ^ | ( ) PDP11/pdp11_tq.c:861:10: note: use '==' to turn this assignment into an equality comparison 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ^ | == PDP11/pdp11_tq.c:874:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ~~~~^~~~~~~~~~~~ PDP11/pdp11_tq.c:874:18: note: place parentheses around the assignment to silence this warning 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | ( ) PDP11/pdp11_tq.c:874:18: note: use '==' to turn this assignment into an equality comparison 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | == PDP11/pdp11_tq.c:875:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ~~~~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:875:21: note: place parentheses around the assignment to silence this warning 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ^ | ( ) PDP11/pdp11_tq.c:875:21: note: use '==' to turn this assignment into an equality comparison 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ^ | == PDP11/pdp11_tq.c:903:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:903:10: note: place parentheses around the assignment to silence this warning 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:903:10: note: use '==' to turn this assignment into an equality comparison 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:958:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:958:10: note: place parentheses around the assignment to silence this warning 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:958:10: note: use '==' to turn this assignment into an equality comparison 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:983:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:983:10: note: place parentheses around the assignment to silence this warning 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:983:10: note: use '==' to turn this assignment into an equality comparison 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1012:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1012:17: note: place parentheses around the assignment to silence this warning 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ^ | ( ) PDP11/pdp11_tq.c:1012:17: note: use '==' to turn this assignment into an equality comparison 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ^ | == PDP11/pdp11_tq.c:1036:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1036:10: note: place parentheses around the assignment to silence this warning 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1036:10: note: use '==' to turn this assignment into an equality comparison 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1058:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1058:10: note: place parentheses around the assignment to silence this warning 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1058:10: note: use '==' to turn this assignment into an equality comparison 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1074:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1074:10: note: place parentheses around the assignment to silence this warning 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1074:10: note: use '==' to turn this assignment into an equality comparison 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1095:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1095:10: note: place parentheses around the assignment to silence this warning 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1095:10: note: use '==' to turn this assignment into an equality comparison 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1118:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1118:10: note: place parentheses around the assignment to silence this warning 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1118:10: note: use '==' to turn this assignment into an equality comparison 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1150:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1150:10: note: place parentheses around the assignment to silence this warning 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1150:10: note: use '==' to turn this assignment into an equality comparison 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1254:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1254:19: note: place parentheses around the assignment to silence this warning 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ^ | ( ) PDP11/pdp11_tq.c:1254:19: note: use '==' to turn this assignment into an equality comparison 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ^ | == PDP11/pdp11_tq.c:1291:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1291:15: note: place parentheses around the assignment to silence this warning 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ^ | ( ) PDP11/pdp11_tq.c:1291:15: note: use '==' to turn this assignment into an equality comparison 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ^ | == PDP11/pdp11_tq.c:2236:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2236 | if (pkt = uptr->pktq) { | ~~~~^~~~~~~~~~~~ PDP11/pdp11_tq.c:2236:13: note: place parentheses around the assignment to silence this warning 2236 | if (pkt = uptr->pktq) { | ^ | ( ) PDP11/pdp11_tq.c:2236:13: note: use '==' to turn this assignment into an equality comparison 2236 | if (pkt = uptr->pktq) { | ^ | == PDP11/pdp11_tq.c:2240:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2240 | } while (pkt = tq_pkt[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:2240:26: note: place parentheses around the assignment to silence this warning 2240 | } while (pkt = tq_pkt[pkt].link); | ^ | ( ) PDP11/pdp11_tq.c:2240:26: note: use '==' to turn this assignment into an equality comparison 2240 | } while (pkt = tq_pkt[pkt].link); | ^ | == PDP11/pdp11_tq.c:2265:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2265 | if (pkt = tq_freq) { | ~~~~^~~~~~~~~ PDP11/pdp11_tq.c:2265:13: note: place parentheses around the assignment to silence this warning 2265 | if (pkt = tq_freq) { | ^ | ( ) PDP11/pdp11_tq.c:2265:13: note: use '==' to turn this assignment into an equality comparison 2265 | if (pkt = tq_freq) { | ^ | == PDP11/pdp11_tq.c:2278:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2278 | if (pkt = tq_rspq) { | ~~~~^~~~~~~~~ PDP11/pdp11_tq.c:2278:13: note: place parentheses around the assignment to silence this warning 2278 | if (pkt = tq_rspq) { | ^ | ( ) PDP11/pdp11_tq.c:2278:13: note: use '==' to turn this assignment into an equality comparison 2278 | if (pkt = tq_rspq) { | ^ | == PDP11/pdp11_tq.c:2282:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2282 | } while (pkt = tq_pkt[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:2282:26: note: place parentheses around the assignment to silence this warning 2282 | } while (pkt = tq_pkt[pkt].link); | ^ | ( ) PDP11/pdp11_tq.c:2282:26: note: use '==' to turn this assignment into an equality comparison 2282 | } while (pkt = tq_pkt[pkt].link); | ^ | == 27 warnings generated. PDP11/pdp11_hk.c:890:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 890 | if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_hk.c:890:23: note: place parentheses around the assignment to silence this warning 890 | if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ | ^ | ( ) PDP11/pdp11_hk.c:890:23: note: use '==' to turn this assignment into an equality comparison 890 | if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ | ^ | == PDP11/pdp11_hk.c:898:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 898 | if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_hk.c:898:23: note: place parentheses around the assignment to silence this warning 898 | if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ | ^ | ( ) PDP11/pdp11_hk.c:898:23: note: use '==' to turn this assignment into an equality comparison 898 | if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ | ^ | == PDP11/pdp11_hk.c:918:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 918 | if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_hk.c:918:23: note: place parentheses around the assignment to silence this warning 918 | if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { | ^ | ( ) PDP11/pdp11_hk.c:918:23: note: use '==' to turn this assignment into an equality comparison 918 | if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { | ^ | == PDP11/pdp11_hk.c:924:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 924 | if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_hk.c:924:23: note: place parentheses around the assignment to silence this warning 924 | if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ | ^ | ( ) PDP11/pdp11_hk.c:924:23: note: use '==' to turn this assignment into an equality comparison 924 | if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ | ^ | == 4 warnings generated. PDP11/pdp11_xq.c:1190:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1190 | if (led = (len & XQ_SETUP_LD) >> 2) { | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_xq.c:1190:13: note: place parentheses around the assignment to silence this warning 1190 | if (led = (len & XQ_SETUP_LD) >> 2) { | ^ | ( ) PDP11/pdp11_xq.c:1190:13: note: use '==' to turn this assignment into an equality comparison 1190 | if (led = (len & XQ_SETUP_LD) >> 2) { | ^ | == PDP11/pdp11_xq.c:2046:11: warning: enumeration values 'XQ_T_DELQA' and 'XQ_T_DELQA_PLUS' not handled in switch [-Wswitch] 2046 | switch (xq->var->type) { | ^~~~~~~~~~~~~ PDP11/pdp11_xq.c:2537:7: warning: add explicit braces to avoid dangling else [-Wdangling-else] 2537 | else { /* DELQA-T Host Inactivity Timer expiration means switch out of DELQA-T mode */ | ^ 3 warnings generated. PDP11/pdp11_xu.c:1044:24: warning: '/*' within block comment [-Wcomment] 1044 | /* xu_dump_rxring(xu); /* debug receive ring */ | ^ PDP11/pdp11_xu.c:1216:24: warning: '/*' within block comment [-Wcomment] 1216 | /* xu_dump_txring(xu); /* debug receive ring */ | ^ 2 warnings generated. PDP11/pdp11_vh.c:296:60: warning: '/*' within block comment [-Wcomment] 296 | /* #define DBG_XMT TMXR_DBG_XMT /* display Transmitted Data */ | ^ PDP11/pdp11_vh.c:297:60: warning: '/*' within block comment [-Wcomment] 297 | /* #define DBG_RCV TMXR_DBG_RCV /* display Received Data */ | ^ 2 warnings generated. PDP11/pdp11_tu.c:650:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 650 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:650:20: note: place parentheses around the assignment to silence this warning 650 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) PDP11/pdp11_tu.c:650:20: note: use '==' to turn this assignment into an equality comparison 650 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == PDP11/pdp11_tu.c:663:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 663 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:663:20: note: place parentheses around the assignment to silence this warning 663 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) PDP11/pdp11_tu.c:663:20: note: use '==' to turn this assignment into an equality comparison 663 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == PDP11/pdp11_tu.c:674:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 674 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:674:16: note: place parentheses around the assignment to silence this warning 674 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP11/pdp11_tu.c:674:16: note: use '==' to turn this assignment into an equality comparison 674 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP11/pdp11_tu.c:690:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 690 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:690:16: note: place parentheses around the assignment to silence this warning 690 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ^ | ( ) PDP11/pdp11_tu.c:690:16: note: use '==' to turn this assignment into an equality comparison 690 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ^ | == PDP11/pdp11_tu.c:742:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 742 | if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:742:16: note: place parentheses around the assignment to silence this warning 742 | if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ | ^ | ( ) PDP11/pdp11_tu.c:742:16: note: use '==' to turn this assignment into an equality comparison 742 | if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ | ^ | == PDP11/pdp11_tu.c:754:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 754 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:754:16: note: place parentheses around the assignment to silence this warning 754 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ^ | ( ) PDP11/pdp11_tu.c:754:16: note: use '==' to turn this assignment into an equality comparison 754 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ^ | == 6 warnings generated. PDP11/pdp11_cpumod.c:1078:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1078 | if (r = build_ubus_tab (&cpu_dev, cnf_tab[i].dib)) /* add to dispatch tab */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cpumod.c:1078:15: note: place parentheses around the assignment to silence this warning 1078 | if (r = build_ubus_tab (&cpu_dev, cnf_tab[i].dib)) /* add to dispatch tab */ | ^ | ( ) PDP11/pdp11_cpumod.c:1078:15: note: use '==' to turn this assignment into an equality comparison 1078 | if (r = build_ubus_tab (&cpu_dev, cnf_tab[i].dib)) /* add to dispatch tab */ | ^ | == 1 warning generated. PDP11/pdp11_cr.c:458:30: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 458 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cr.c:544:34: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 544 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cr.c:619:38: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 619 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ 3 warnings generated. PDP11/pdp11_dl.c:349:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 349 | if (temp = tmxr_getc_ln (&dlx_ldsc[ln])) { /* get char */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_dl.c:349:18: note: place parentheses around the assignment to silence this warning 349 | if (temp = tmxr_getc_ln (&dlx_ldsc[ln])) { /* get char */ | ^ | ( ) PDP11/pdp11_dl.c:349:18: note: use '==' to turn this assignment into an equality comparison 349 | if (temp = tmxr_getc_ln (&dlx_ldsc[ln])) { /* get char */ | ^ | == 1 warning generated. PDP11/pdp11_ta.c:400:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 400 | if (st = sim_tape_wrrecf (uptr, ta_xb, ta_bptr)) /* write, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ta.c:400:19: note: place parentheses around the assignment to silence this warning 400 | if (st = sim_tape_wrrecf (uptr, ta_xb, ta_bptr)) /* write, err? */ | ^ | ( ) PDP11/pdp11_ta.c:400:19: note: use '==' to turn this assignment into an equality comparison 400 | if (st = sim_tape_wrrecf (uptr, ta_xb, ta_bptr)) /* write, err? */ | ^ | == PDP11/pdp11_ta.c:406:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 406 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ta.c:406:16: note: place parentheses around the assignment to silence this warning 406 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP11/pdp11_ta.c:406:16: note: use '==' to turn this assignment into an equality comparison 406 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP11/pdp11_ta.c:416:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 416 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ta.c:416:16: note: place parentheses around the assignment to silence this warning 416 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ^ | ( ) PDP11/pdp11_ta.c:416:16: note: use '==' to turn this assignment into an equality comparison 416 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ^ | == PDP11/pdp11_ta.c:428:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 428 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ta.c:428:16: note: place parentheses around the assignment to silence this warning 428 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rev, err? */ | ^ | ( ) PDP11/pdp11_ta.c:428:16: note: use '==' to turn this assignment into an equality comparison 428 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rev, err? */ | ^ | == 4 warnings generated. PDP11/pdp11_ke.c:255:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 255 | if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ke.c:255:22: note: place parentheses around the assignment to silence this warning 255 | if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ | ^ | ( ) PDP11/pdp11_ke.c:255:22: note: use '==' to turn this assignment into an equality comparison 255 | if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ | ^ | == PDP11/pdp11_ke.c:285:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 285 | if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ke.c:285:22: note: place parentheses around the assignment to silence this warning 285 | if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ | ^ | ( ) PDP11/pdp11_ke.c:285:22: note: use '==' to turn this assignment into an equality comparison 285 | if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ | ^ | == 2 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_ether.c:1336:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ sim_ether.c:1336:13: note: place parentheses around the assignment to silence this warning 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ^ | ( ) sim_ether.c:1336:13: note: use '==' to turn this assignment into an equality comparison 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ^ | == sim_ether.c:1522:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1522 | while (request = dev->write_requests) { | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ sim_ether.c:1522:18: note: place parentheses around the assignment to silence this warning 1522 | while (request = dev->write_requests) { | ^ | ( ) sim_ether.c:1522:18: note: use '==' to turn this assignment into an equality comparison 1522 | while (request = dev->write_requests) { | ^ | == sim_ether.c:1835:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1835 | while (buffer = dev->write_buffers) { | ~~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_ether.c:1835:18: note: place parentheses around the assignment to silence this warning 1835 | while (buffer = dev->write_buffers) { | ^ | ( ) sim_ether.c:1835:18: note: use '==' to turn this assignment into an equality comparison 1835 | while (buffer = dev->write_buffers) { | ^ | == sim_ether.c:1839:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1839 | while (buffer = dev->write_requests) { | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~ sim_ether.c:1839:17: note: place parentheses around the assignment to silence this warning 1839 | while (buffer = dev->write_requests) { | ^ | ( ) sim_ether.c:1839:17: note: use '==' to turn this assignment into an equality comparison 1839 | while (buffer = dev->write_requests) { | ^ | == sim_ether.c:2092:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2092 | if (request = dev->write_buffers) | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_ether.c:2092:13: note: place parentheses around the assignment to silence this warning 2092 | if (request = dev->write_buffers) | ^ | ( ) sim_ether.c:2092:13: note: use '==' to turn this assignment into an equality comparison 2092 | if (request = dev->write_buffers) | ^ | == 5 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: pdp11_rk.c(/tmp/pdp11_rk-0bd9bb.o:(rk_rd)): warning: rand() may return deterministic values, is that what you want? ld: warning: pdp11_xq.c(/tmp/pdp11_xq-20b252.o:(xq_attach)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: pdp11_xq.c(/tmp/pdp11_xq-20b252.o:(xq_debug_turbo_setup)): warning: sprintf() is often misused, please use snprintf() ld: warning: scp.c(/tmp/scp-098b1b.o:(main)): warning: strcat() is almost always misused, please use strlcat() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so PDP10/pdp10_fe.c PDP11/pdp11_dz.c PDP10/pdp10_cpu.c PDP10/pdp10_ksio.c PDP10/pdp10_lp20.c PDP10/pdp10_mdfp.c PDP10/pdp10_pag.c PDP10/pdp10_rp.c PDP10/pdp10_sys.c PDP10/pdp10_tim.c PDP10/pdp10_tu.c PDP10/pdp10_xtnd.c PDP11/pdp11_pt.c PDP11/pdp11_ry.c PDP11/pdp11_cr.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_PDP10 -DUSE_INT64 -I PDP10 -I PDP11 -o BIN/pdp10 -lm -lpthread -lpcap In file included from PDP10/pdp10_fe.c:41: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ 2 warnings generated. In file included from PDP11/pdp11_dz.c:62: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ 2 warnings generated. In file included from PDP10/pdp10_cpu.c:136: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ PDP10/pdp10_cpu.c:708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 708 | if (i = sim_process_event ()) /* error? stop sim */ | ~~^~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_cpu.c:708:11: note: place parentheses around the assignment to silence this warning 708 | if (i = sim_process_event ()) /* error? stop sim */ | ^ | ( ) PDP10/pdp10_cpu.c:708:11: note: use '==' to turn this assignment into an equality comparison 708 | if (i = sim_process_event ()) /* error? stop sim */ | ^ | == PDP10/pdp10_cpu.c:722:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 722 | if (vec = pi_ub_vec (qintr, &uba)) { /* Unibus interrupt? */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_cpu.c:722:13: note: place parentheses around the assignment to silence this warning 722 | if (vec = pi_ub_vec (qintr, &uba)) { /* Unibus interrupt? */ | ^ | ( ) PDP10/pdp10_cpu.c:722:13: note: use '==' to turn this assignment into an equality comparison 722 | if (vec = pi_ub_vec (qintr, &uba)) { /* Unibus interrupt? */ | ^ | == PDP10/pdp10_cpu.c:868:57: warning: '/*' within block comment [-Wcomment] 868 | /* case 0100: MUUO /* UJEN */ | ^ PDP10/pdp10_cpu.c:869:57: warning: '/*' within block comment [-Wcomment] 869 | /* case 0101: MUUO /* unassigned */ | ^ PDP10/pdp10_cpu.c:882:57: warning: '/*' within block comment [-Wcomment] 882 | /* case 0104: MUUO /* JSYS (T20) */ | ^ PDP10/pdp10_cpu.c:884:57: warning: '/*' within block comment [-Wcomment] 884 | /* case 0106: MUUO /* GFMP (KL)*/ | ^ PDP10/pdp10_cpu.c:885:57: warning: '/*' within block comment [-Wcomment] 885 | /* case 0107: MUUO /* GFDV (KL) */ | ^ PDP10/pdp10_cpu.c:912:57: warning: '/*' within block comment [-Wcomment] 912 | /* case 0130: MUUO /* UFA */ | ^ PDP10/pdp10_cpu.c:913:57: warning: '/*' within block comment [-Wcomment] 913 | /* case 0131: MUUO /* DFN */ | ^ PDP10/pdp10_cpu.c:923:57: warning: '/*' within block comment [-Wcomment] 923 | /* case 0141: MUUO /* FADL */ | ^ PDP10/pdp10_cpu.c:931:57: warning: '/*' within block comment [-Wcomment] 931 | /* case 0151: MUUO /* FSBL */ | ^ PDP10/pdp10_cpu.c:939:57: warning: '/*' within block comment [-Wcomment] 939 | /* case 0161: MUUO /* FMPL */ | ^ PDP10/pdp10_cpu.c:947:57: warning: '/*' within block comment [-Wcomment] 947 | /* case 0171: MUUO /* FDVL */ | ^ PDP10/pdp10_cpu.c:1011:17: warning: '/*' within block comment [-Wcomment] 1011 | /* case 0254: /* shown later /* JRST */ | ^ PDP10/pdp10_cpu.c:1011:57: warning: '/*' within block comment [-Wcomment] 1011 | /* case 0254: /* shown later /* JRST */ | ^ PDP10/pdp10_cpu.c:2022:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2022 | if (t = sim_process_event ()) /* IO event? */ | ~~^~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_cpu.c:2022:11: note: place parentheses around the assignment to silence this warning 2022 | if (t = sim_process_event ()) /* IO event? */ | ^ | ( ) PDP10/pdp10_cpu.c:2022:11: note: use '==' to turn this assignment into an equality comparison 2022 | if (t = sim_process_event ()) /* IO event? */ | ^ | == 18 warnings generated. In file included from PDP10/pdp10_ksio.c:72: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ PDP10/pdp10_ksio.c:404:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 404 | for (i = 0; dibp = dib_tab[i]; i++ ) { | ~~~~~^~~~~~~~~~~~ PDP10/pdp10_ksio.c:404:18: note: place parentheses around the assignment to silence this warning 404 | for (i = 0; dibp = dib_tab[i]; i++ ) { | ^ | ( ) PDP10/pdp10_ksio.c:404:18: note: use '==' to turn this assignment into an equality comparison 404 | for (i = 0; dibp = dib_tab[i]; i++ ) { | ^ | == PDP10/pdp10_ksio.c:421:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 421 | for (i = 0; dibp = dib_tab[i]; i++ ) { | ~~~~~^~~~~~~~~~~~ PDP10/pdp10_ksio.c:421:18: note: place parentheses around the assignment to silence this warning 421 | for (i = 0; dibp = dib_tab[i]; i++ ) { | ^ | ( ) PDP10/pdp10_ksio.c:421:18: note: use '==' to turn this assignment into an equality comparison 421 | for (i = 0; dibp = dib_tab[i]; i++ ) { | ^ | == 4 warnings generated. In file included from PDP10/pdp10_lp20.c:42: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ PDP10/pdp10_lp20.c:61:57: warning: '/*' within block comment [-Wcomment] 61 | /* define TX_INTR 04000 /* interrupt */ | ^ PDP10/pdp10_lp20.c:63:57: warning: '/*' within block comment [-Wcomment] 63 | /* define TX_XLAT 01000 /* translate */ | ^ PDP10/pdp10_lp20.c:64:57: warning: '/*' within block comment [-Wcomment] 64 | /* define TX_DVFU 00400 /* DAVFU */ | ^ PDP10/pdp10_lp20.c:566:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 566 | if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_lp20.c:566:16: note: place parentheses around the assignment to silence this warning 566 | if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ | ^ | ( ) PDP10/pdp10_lp20.c:566:16: note: use '==' to turn this assignment into an equality comparison 566 | if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ | ^ | == PDP10/pdp10_lp20.c:595:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 595 | if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_lp20.c:595:20: note: place parentheses around the assignment to silence this warning 595 | if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ | ^ | ( ) PDP10/pdp10_lp20.c:595:20: note: use '==' to turn this assignment into an equality comparison 595 | if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ | ^ | == 7 warnings generated. In file included from PDP10/pdp10_mdfp.c:101: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ PDP10/pdp10_mdfp.c:496:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 496 | if (savhi = a.fhi) { /* dvd = 0? quo = 0 */ | ~~~~~~^~~~~~~ PDP10/pdp10_mdfp.c:496:11: note: place parentheses around the assignment to silence this warning 496 | if (savhi = a.fhi) { /* dvd = 0? quo = 0 */ | ^ | ( ) PDP10/pdp10_mdfp.c:496:11: note: use '==' to turn this assignment into an equality comparison 496 | if (savhi = a.fhi) { /* dvd = 0? quo = 0 */ | ^ | == 3 warnings generated. In file included from PDP10/pdp10_pag.c:79: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ 2 warnings generated. In file included from PDP10/pdp10_rp.c:71: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ PDP10/pdp10_rp.c:954:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 954 | if (fc10 = twc10 & (RP_NUMWD - 1)) { /* fill? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_rp.c:954:22: note: place parentheses around the assignment to silence this warning 954 | if (fc10 = twc10 & (RP_NUMWD - 1)) { /* fill? */ | ^ | ( ) PDP10/pdp10_rp.c:954:22: note: use '==' to turn this assignment into an equality comparison 954 | if (fc10 = twc10 & (RP_NUMWD - 1)) { /* fill? */ | ^ | == 3 warnings generated. In file included from PDP10/pdp10_sys.c:42: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ PDP10/pdp10_sys.c:123:1: warning: '/*' within block comment [-Wcomment] 123 | /* RIM10 loader | ^ 3 warnings generated. In file included from PDP10/pdp10_tim.c:41: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ 2 warnings generated. In file included from PDP10/pdp10_tu.c:93: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ PDP10/pdp10_tu.c:677:16: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare] 677 | tutc = TC_RIP; /* density = 800 */ | ^ PDP10/pdp10_tu.c:261:34: note: expanded from macro 'TC_RIP' 261 | #define TC_RIP ((TC_800 << TC_V_DEN) || (TC_10C << TC_V_FMT)) | ^ PDP10/pdp10_tu.c:677:16: warning: converting the result of '<<' to a boolean always evaluates to false [-Wtautological-constant-compare] PDP10/pdp10_tu.c:261:58: note: expanded from macro 'TC_RIP' 261 | #define TC_RIP ((TC_800 << TC_V_DEN) || (TC_10C << TC_V_FMT)) | ^ PDP10/pdp10_tu.c:836:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 836 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_tu.c:836:20: note: place parentheses around the assignment to silence this warning 836 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) PDP10/pdp10_tu.c:836:20: note: use '==' to turn this assignment into an equality comparison 836 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == PDP10/pdp10_tu.c:850:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 850 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_tu.c:850:20: note: place parentheses around the assignment to silence this warning 850 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) PDP10/pdp10_tu.c:850:20: note: use '==' to turn this assignment into an equality comparison 850 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == PDP10/pdp10_tu.c:862:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 862 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_tu.c:862:16: note: place parentheses around the assignment to silence this warning 862 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP10/pdp10_tu.c:862:16: note: use '==' to turn this assignment into an equality comparison 862 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP10/pdp10_tu.c:892:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 892 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_tu.c:892:16: note: place parentheses around the assignment to silence this warning 892 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ^ | ( ) PDP10/pdp10_tu.c:892:16: note: use '==' to turn this assignment into an equality comparison 892 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ^ | == PDP10/pdp10_tu.c:939:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 939 | if (st = sim_tape_wrrecf (uptr, xbuf, fc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_tu.c:939:16: note: place parentheses around the assignment to silence this warning 939 | if (st = sim_tape_wrrecf (uptr, xbuf, fc)) /* write rec, err? */ | ^ | ( ) PDP10/pdp10_tu.c:939:16: note: use '==' to turn this assignment into an equality comparison 939 | if (st = sim_tape_wrrecf (uptr, xbuf, fc)) /* write rec, err? */ | ^ | == PDP10/pdp10_tu.c:954:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 954 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP10/pdp10_tu.c:954:16: note: place parentheses around the assignment to silence this warning 954 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ^ | ( ) PDP10/pdp10_tu.c:954:16: note: use '==' to turn this assignment into an equality comparison 954 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ^ | == 10 warnings generated. In file included from PDP10/pdp10_xtnd.c:66: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ 2 warnings generated. In file included from PDP11/pdp11_pt.c:36: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ 2 warnings generated. In file included from PDP11/pdp11_ry.c:45: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ 2 warnings generated. In file included from PDP11/pdp11_cr.c:168: PDP10/pdp10_defs.h:590:57: warning: '/*' within block comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | ^ PDP10/pdp10_defs.h:592:57: warning: '/*' within block comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | ^ PDP11/pdp11_cr.c:458:30: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 458 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cr.c:544:34: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 544 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cr.c:619:38: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 619 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ 5 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: pdp10_tim.c(/tmp/pdp10_tim-7ba99c.o:(tim_svc)): warning: rand() may return deterministic values, is that what you want? ld: warning: scp.c(/tmp/scp-5277d3.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-5277d3.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_ether.c(/tmp/sim_ether-2c055f.o:(eth_mac_fmt)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so VAX/vax_cpu.c VAX/vax_cpu1.c VAX/vax_fpa.c VAX/vax_io.c VAX/vax_cis.c VAX/vax_octa.c VAX/vax_cmode.c VAX/vax_mmu.c VAX/vax_stddev.c VAX/vax_sysdev.c VAX/vax_sys.c VAX/vax_syscm.c VAX/vax_syslist.c PDP11/pdp11_rl.c PDP11/pdp11_rq.c PDP11/pdp11_ts.c PDP11/pdp11_dz.c PDP11/pdp11_lp.c PDP11/pdp11_tq.c PDP11/pdp11_xq.c PDP11/pdp11_ry.c PDP11/pdp11_vh.c PDP11/pdp11_cr.c PDP11/pdp11_io_lib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_VAX -DUSE_INT64 -DUSE_ADDR64 -I VAX -I PDP11 -DUSE_NETWORK -I/usr/include/ -DUSE_TAP_NETWORK -DUSE_BSDTUNTAP -o BIN/vax -lm -lpthread -lpcap In file included from VAX/vax_cpu.c:182: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_cpu.c:182: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ VAX/vax_cpu.c:645:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 645 | if (temp = GET_TRAP (trpirq)) { /* trap? */ | ~~~~~^~~~~~~~~~~~~~~~~~~ VAX/vax_cpu.c:645:18: note: place parentheses around the assignment to silence this warning 645 | if (temp = GET_TRAP (trpirq)) { /* trap? */ | ^ | ( ) VAX/vax_cpu.c:645:18: note: use '==' to turn this assignment into an equality comparison 645 | if (temp = GET_TRAP (trpirq)) { /* trap? */ | ^ | == VAX/vax_cpu.c:653:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 653 | else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ | ~~~~~^~~~~~~~~~~~~~~~~~~ VAX/vax_cpu.c:653:23: note: place parentheses around the assignment to silence this warning 653 | else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ | ^ | ( ) VAX/vax_cpu.c:653:23: note: use '==' to turn this assignment into an equality comparison 653 | else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ | ^ | == 4 warnings generated. In file included from VAX/vax_cpu1.c:72: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_cpu1.c:72: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from VAX/vax_fpa.c:59: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_fpa.c:59: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from VAX/vax_io.c:52: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_io.c:52: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ VAX/vax_io.c:795:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 795 | if (r = build_ubus_tab (dptr, dibp)) /* add to bus tab */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ VAX/vax_io.c:795:15: note: place parentheses around the assignment to silence this warning 795 | if (r = build_ubus_tab (dptr, dibp)) /* add to bus tab */ | ^ | ( ) VAX/vax_io.c:795:15: note: use '==' to turn this assignment into an equality comparison 795 | if (r = build_ubus_tab (dptr, dibp)) /* add to bus tab */ | ^ | == 3 warnings generated. In file included from VAX/vax_cis.c:53: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_cis.c:53: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from VAX/vax_octa.c:47: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_octa.c:47: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from VAX/vax_cmode.c:40: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_cmode.c:40: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from VAX/vax_mmu.c:50: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_mmu.c:50: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from VAX/vax_stddev.c:48: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_stddev.c:48: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from VAX/vax_sysdev.c:55: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_sysdev.c:55: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from VAX/vax_sys.c:47: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_sys.c:47: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ VAX/vax_sys.c:1176:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1176 | if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ VAX/vax_sys.c:1176:10: note: place parentheses around the assignment to silence this warning 1176 | if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ | ^ | ( ) VAX/vax_sys.c:1176:10: note: use '==' to turn this assignment into an equality comparison 1176 | if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ | ^ | == 3 warnings generated. In file included from VAX/vax_syscm.c:34: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_syscm.c:34: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from VAX/vax_syslist.c:31: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from VAX/vax_syslist.c:31: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from PDP11/pdp11_rl.c:93: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_rl.c:93: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from PDP11/pdp11_rq.c:77: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_rq.c:77: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ In file included from PDP11/pdp11_rq.c:99: PDP11/pdp11_mscp.h:213:57: warning: '/*' within block comment [-Wcomment] 213 | /* 5 /* reserved */ | ^ PDP11/pdp11_mscp.h:258:57: warning: '/*' within block comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:265:57: warning: '/*' within block comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:401:57: warning: '/*' within block comment [-Wcomment] 401 | /* 14 /* reserved */ | ^ PDP11/pdp11_mscp.h:402:57: warning: '/*' within block comment [-Wcomment] 402 | /* 15 /* reserved */ | ^ PDP11/pdp11_rq.c:1355:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1355:10: note: place parentheses around the assignment to silence this warning 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ^ | ( ) PDP11/pdp11_rq.c:1355:10: note: use '==' to turn this assignment into an equality comparison 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ^ | == PDP11/pdp11_rq.c:1368:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ~~~~^~~~~~~~~~~~ PDP11/pdp11_rq.c:1368:18: note: place parentheses around the assignment to silence this warning 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | ( ) PDP11/pdp11_rq.c:1368:18: note: use '==' to turn this assignment into an equality comparison 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | == PDP11/pdp11_rq.c:1369:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ~~~~~^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1369:21: note: place parentheses around the assignment to silence this warning 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ^ | ( ) PDP11/pdp11_rq.c:1369:21: note: use '==' to turn this assignment into an equality comparison 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ^ | == PDP11/pdp11_rq.c:1396:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1396:10: note: place parentheses around the assignment to silence this warning 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1396:10: note: use '==' to turn this assignment into an equality comparison 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1450:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1450:10: note: place parentheses around the assignment to silence this warning 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1450:10: note: use '==' to turn this assignment into an equality comparison 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1485:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1485:10: note: place parentheses around the assignment to silence this warning 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1485:10: note: use '==' to turn this assignment into an equality comparison 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1523:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1523:18: note: place parentheses around the assignment to silence this warning 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ^ | ( ) PDP11/pdp11_rq.c:1523:18: note: use '==' to turn this assignment into an equality comparison 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ^ | == PDP11/pdp11_rq.c:1550:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1550:10: note: place parentheses around the assignment to silence this warning 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1550:10: note: use '==' to turn this assignment into an equality comparison 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1579:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1579:10: note: place parentheses around the assignment to silence this warning 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1579:10: note: use '==' to turn this assignment into an equality comparison 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1613:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1613:10: note: place parentheses around the assignment to silence this warning 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1613:10: note: use '==' to turn this assignment into an equality comparison 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1657:57: warning: '/*' within block comment [-Wcomment] 1657 | /* if (lbn & 0xF0000000) return (ST_CMD | I_LBN); /* 'reasonable' lbn? */ | ^ PDP11/pdp11_rq.c:1728:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1728 | if (abc = tbc - t) { /* any xfer? */ | ~~~~^~~~~~~~~ PDP11/pdp11_rq.c:1728:13: note: place parentheses around the assignment to silence this warning 1728 | if (abc = tbc - t) { /* any xfer? */ | ^ | ( ) PDP11/pdp11_rq.c:1728:13: note: use '==' to turn this assignment into an equality comparison 1728 | if (abc = tbc - t) { /* any xfer? */ | ^ | == PDP11/pdp11_rq.c:1755:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1755:15: note: place parentheses around the assignment to silence this warning 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ^ | ( ) PDP11/pdp11_rq.c:1755:15: note: use '==' to turn this assignment into an equality comparison 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ^ | == PDP11/pdp11_rq.c:2589:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2589 | if (pkt = uptr->pktq) { | ~~~~^~~~~~~~~~~~ PDP11/pdp11_rq.c:2589:13: note: place parentheses around the assignment to silence this warning 2589 | if (pkt = uptr->pktq) { | ^ | ( ) PDP11/pdp11_rq.c:2589:13: note: use '==' to turn this assignment into an equality comparison 2589 | if (pkt = uptr->pktq) { | ^ | == PDP11/pdp11_rq.c:2593:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2593 | } while (pkt = cp->pak[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:2593:26: note: place parentheses around the assignment to silence this warning 2593 | } while (pkt = cp->pak[pkt].link); | ^ | ( ) PDP11/pdp11_rq.c:2593:26: note: use '==' to turn this assignment into an equality comparison 2593 | } while (pkt = cp->pak[pkt].link); | ^ | == PDP11/pdp11_rq.c:2620:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2620 | if (pkt = cp->freq) { | ~~~~^~~~~~~~~~ PDP11/pdp11_rq.c:2620:13: note: place parentheses around the assignment to silence this warning 2620 | if (pkt = cp->freq) { | ^ | ( ) PDP11/pdp11_rq.c:2620:13: note: use '==' to turn this assignment into an equality comparison 2620 | if (pkt = cp->freq) { | ^ | == PDP11/pdp11_rq.c:2633:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2633 | if (pkt = cp->rspq) { | ~~~~^~~~~~~~~~ PDP11/pdp11_rq.c:2633:13: note: place parentheses around the assignment to silence this warning 2633 | if (pkt = cp->rspq) { | ^ | ( ) PDP11/pdp11_rq.c:2633:13: note: use '==' to turn this assignment into an equality comparison 2633 | if (pkt = cp->rspq) { | ^ | == PDP11/pdp11_rq.c:2637:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2637 | } while (pkt = cp->pak[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:2637:26: note: place parentheses around the assignment to silence this warning 2637 | } while (pkt = cp->pak[pkt].link); | ^ | ( ) PDP11/pdp11_rq.c:2637:26: note: use '==' to turn this assignment into an equality comparison 2637 | } while (pkt = cp->pak[pkt].link); | ^ | == 25 warnings generated. In file included from PDP11/pdp11_ts.c:93: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_ts.c:93: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ PDP11/pdp11_ts.c:493:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:493:12: note: place parentheses around the assignment to silence this warning 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | ( ) PDP11/pdp11_ts.c:493:12: note: use '==' to turn this assignment into an equality comparison 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | == PDP11/pdp11_ts.c:536:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:536:12: note: place parentheses around the assignment to silence this warning 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | ( ) PDP11/pdp11_ts.c:536:12: note: use '==' to turn this assignment into an equality comparison 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | == PDP11/pdp11_ts.c:669:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:669:8: note: place parentheses around the assignment to silence this warning 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ^ | ( ) PDP11/pdp11_ts.c:669:8: note: use '==' to turn this assignment into an equality comparison 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ^ | == PDP11/pdp11_ts.c:682:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:682:8: note: place parentheses around the assignment to silence this warning 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP11/pdp11_ts.c:682:8: note: use '==' to turn this assignment into an equality comparison 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == 6 warnings generated. In file included from PDP11/pdp11_dz.c:68: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_dz.c:68: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from PDP11/pdp11_lp.c:45: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_lp.c:45: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from PDP11/pdp11_tq.c:68: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_tq.c:68: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ In file included from PDP11/pdp11_tq.c:85: PDP11/pdp11_mscp.h:213:57: warning: '/*' within block comment [-Wcomment] 213 | /* 5 /* reserved */ | ^ PDP11/pdp11_mscp.h:258:57: warning: '/*' within block comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:265:57: warning: '/*' within block comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:401:57: warning: '/*' within block comment [-Wcomment] 401 | /* 14 /* reserved */ | ^ PDP11/pdp11_mscp.h:402:57: warning: '/*' within block comment [-Wcomment] 402 | /* 15 /* reserved */ | ^ PDP11/pdp11_tq.c:783:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:783:14: note: place parentheses around the assignment to silence this warning 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ^ | ( ) PDP11/pdp11_tq.c:783:14: note: use '==' to turn this assignment into an equality comparison 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ^ | == PDP11/pdp11_tq.c:789:57: warning: '/*' within block comment [-Wcomment] 789 | /* if (tq_cmf[cmd] & MD_CDL) /* clr cch lost? */ | ^ PDP11/pdp11_tq.c:861:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:861:10: note: place parentheses around the assignment to silence this warning 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ^ | ( ) PDP11/pdp11_tq.c:861:10: note: use '==' to turn this assignment into an equality comparison 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ^ | == PDP11/pdp11_tq.c:874:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ~~~~^~~~~~~~~~~~ PDP11/pdp11_tq.c:874:18: note: place parentheses around the assignment to silence this warning 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | ( ) PDP11/pdp11_tq.c:874:18: note: use '==' to turn this assignment into an equality comparison 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | == PDP11/pdp11_tq.c:875:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ~~~~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:875:21: note: place parentheses around the assignment to silence this warning 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ^ | ( ) PDP11/pdp11_tq.c:875:21: note: use '==' to turn this assignment into an equality comparison 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ^ | == PDP11/pdp11_tq.c:903:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:903:10: note: place parentheses around the assignment to silence this warning 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:903:10: note: use '==' to turn this assignment into an equality comparison 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:958:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:958:10: note: place parentheses around the assignment to silence this warning 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:958:10: note: use '==' to turn this assignment into an equality comparison 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:983:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:983:10: note: place parentheses around the assignment to silence this warning 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:983:10: note: use '==' to turn this assignment into an equality comparison 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1012:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1012:17: note: place parentheses around the assignment to silence this warning 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ^ | ( ) PDP11/pdp11_tq.c:1012:17: note: use '==' to turn this assignment into an equality comparison 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ^ | == PDP11/pdp11_tq.c:1036:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1036:10: note: place parentheses around the assignment to silence this warning 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1036:10: note: use '==' to turn this assignment into an equality comparison 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1058:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1058:10: note: place parentheses around the assignment to silence this warning 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1058:10: note: use '==' to turn this assignment into an equality comparison 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1074:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1074:10: note: place parentheses around the assignment to silence this warning 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1074:10: note: use '==' to turn this assignment into an equality comparison 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1095:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1095:10: note: place parentheses around the assignment to silence this warning 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1095:10: note: use '==' to turn this assignment into an equality comparison 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1118:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1118:10: note: place parentheses around the assignment to silence this warning 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1118:10: note: use '==' to turn this assignment into an equality comparison 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1150:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1150:10: note: place parentheses around the assignment to silence this warning 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1150:10: note: use '==' to turn this assignment into an equality comparison 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1254:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1254:19: note: place parentheses around the assignment to silence this warning 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ^ | ( ) PDP11/pdp11_tq.c:1254:19: note: use '==' to turn this assignment into an equality comparison 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ^ | == PDP11/pdp11_tq.c:1291:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1291:15: note: place parentheses around the assignment to silence this warning 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ^ | ( ) PDP11/pdp11_tq.c:1291:15: note: use '==' to turn this assignment into an equality comparison 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ^ | == PDP11/pdp11_tq.c:2236:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2236 | if (pkt = uptr->pktq) { | ~~~~^~~~~~~~~~~~ PDP11/pdp11_tq.c:2236:13: note: place parentheses around the assignment to silence this warning 2236 | if (pkt = uptr->pktq) { | ^ | ( ) PDP11/pdp11_tq.c:2236:13: note: use '==' to turn this assignment into an equality comparison 2236 | if (pkt = uptr->pktq) { | ^ | == PDP11/pdp11_tq.c:2240:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2240 | } while (pkt = tq_pkt[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:2240:26: note: place parentheses around the assignment to silence this warning 2240 | } while (pkt = tq_pkt[pkt].link); | ^ | ( ) PDP11/pdp11_tq.c:2240:26: note: use '==' to turn this assignment into an equality comparison 2240 | } while (pkt = tq_pkt[pkt].link); | ^ | == PDP11/pdp11_tq.c:2265:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2265 | if (pkt = tq_freq) { | ~~~~^~~~~~~~~ PDP11/pdp11_tq.c:2265:13: note: place parentheses around the assignment to silence this warning 2265 | if (pkt = tq_freq) { | ^ | ( ) PDP11/pdp11_tq.c:2265:13: note: use '==' to turn this assignment into an equality comparison 2265 | if (pkt = tq_freq) { | ^ | == PDP11/pdp11_tq.c:2278:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2278 | if (pkt = tq_rspq) { | ~~~~^~~~~~~~~ PDP11/pdp11_tq.c:2278:13: note: place parentheses around the assignment to silence this warning 2278 | if (pkt = tq_rspq) { | ^ | ( ) PDP11/pdp11_tq.c:2278:13: note: use '==' to turn this assignment into an equality comparison 2278 | if (pkt = tq_rspq) { | ^ | == PDP11/pdp11_tq.c:2282:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2282 | } while (pkt = tq_pkt[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:2282:26: note: place parentheses around the assignment to silence this warning 2282 | } while (pkt = tq_pkt[pkt].link); | ^ | ( ) PDP11/pdp11_tq.c:2282:26: note: use '==' to turn this assignment into an equality comparison 2282 | } while (pkt = tq_pkt[pkt].link); | ^ | == 29 warnings generated. In file included from PDP11/pdp11_xq.c:252: In file included from PDP11/pdp11_xq.h:72: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_xq.c:252: In file included from PDP11/pdp11_xq.h:72: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ PDP11/pdp11_xq.c:1190:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1190 | if (led = (len & XQ_SETUP_LD) >> 2) { | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_xq.c:1190:13: note: place parentheses around the assignment to silence this warning 1190 | if (led = (len & XQ_SETUP_LD) >> 2) { | ^ | ( ) PDP11/pdp11_xq.c:1190:13: note: use '==' to turn this assignment into an equality comparison 1190 | if (led = (len & XQ_SETUP_LD) >> 2) { | ^ | == PDP11/pdp11_xq.c:2537:7: warning: add explicit braces to avoid dangling else [-Wdangling-else] 2537 | else { /* DELQA-T Host Inactivity Timer expiration means switch out of DELQA-T mode */ | ^ 4 warnings generated. In file included from PDP11/pdp11_ry.c:50: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_ry.c:50: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from PDP11/pdp11_vh.c:75: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_vh.c:75: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ PDP11/pdp11_vh.c:296:60: warning: '/*' within block comment [-Wcomment] 296 | /* #define DBG_XMT TMXR_DBG_XMT /* display Transmitted Data */ | ^ PDP11/pdp11_vh.c:297:60: warning: '/*' within block comment [-Wcomment] 297 | /* #define DBG_RCV TMXR_DBG_RCV /* display Received Data */ | ^ 4 warnings generated. In file included from PDP11/pdp11_cr.c:175: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_cr.c:175: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ PDP11/pdp11_cr.c:458:30: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 458 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cr.c:544:34: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 544 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cr.c:619:38: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 619 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ 5 warnings generated. In file included from PDP11/pdp11_io_lib.c:31: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_io_lib.c:31: In file included from VAX/vax_defs.h:726: VAX/vaxmod_defs.h:181:57: warning: '/*' within block comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | ^ 2 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_ether.c:1336:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ sim_ether.c:1336:13: note: place parentheses around the assignment to silence this warning 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ^ | ( ) sim_ether.c:1336:13: note: use '==' to turn this assignment into an equality comparison 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ^ | == sim_ether.c:1522:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1522 | while (request = dev->write_requests) { | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ sim_ether.c:1522:18: note: place parentheses around the assignment to silence this warning 1522 | while (request = dev->write_requests) { | ^ | ( ) sim_ether.c:1522:18: note: use '==' to turn this assignment into an equality comparison 1522 | while (request = dev->write_requests) { | ^ | == sim_ether.c:1835:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1835 | while (buffer = dev->write_buffers) { | ~~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_ether.c:1835:18: note: place parentheses around the assignment to silence this warning 1835 | while (buffer = dev->write_buffers) { | ^ | ( ) sim_ether.c:1835:18: note: use '==' to turn this assignment into an equality comparison 1835 | while (buffer = dev->write_buffers) { | ^ | == sim_ether.c:1839:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1839 | while (buffer = dev->write_requests) { | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~ sim_ether.c:1839:17: note: place parentheses around the assignment to silence this warning 1839 | while (buffer = dev->write_requests) { | ^ | ( ) sim_ether.c:1839:17: note: use '==' to turn this assignment into an equality comparison 1839 | while (buffer = dev->write_requests) { | ^ | == sim_ether.c:2092:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2092 | if (request = dev->write_buffers) | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_ether.c:2092:13: note: place parentheses around the assignment to silence this warning 2092 | if (request = dev->write_buffers) | ^ | ( ) sim_ether.c:2092:13: note: use '==' to turn this assignment into an equality comparison 2092 | if (request = dev->write_buffers) | ^ | == 5 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: pdp11_xq.c(/tmp/pdp11_xq-9f993e.o:(xq_attach)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: pdp11_xq.c(/tmp/pdp11_xq-9f993e.o:(xq_debug_turbo_setup)): warning: sprintf() is often misused, please use snprintf() ld: warning: scp.c(/tmp/scp-4ead5f.o:(main)): warning: strcat() is almost always misused, please use strlcat() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so VAX/vax_cpu.c VAX/vax_cpu1.c VAX/vax_fpa.c VAX/vax_cis.c VAX/vax_octa.c VAX/vax_cmode.c VAX/vax_mmu.c VAX/vax_sys.c VAX/vax_syscm.c VAX/vax780_stddev.c VAX/vax780_sbi.c VAX/vax780_mem.c VAX/vax780_uba.c VAX/vax780_mba.c VAX/vax780_fload.c VAX/vax780_syslist.c PDP11/pdp11_rl.c PDP11/pdp11_rq.c PDP11/pdp11_ts.c PDP11/pdp11_dz.c PDP11/pdp11_lp.c PDP11/pdp11_tq.c PDP11/pdp11_xu.c PDP11/pdp11_ry.c PDP11/pdp11_cr.c PDP11/pdp11_rp.c PDP11/pdp11_tu.c PDP11/pdp11_hk.c PDP11/pdp11_io_lib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_VAX -DVAX_780 -DUSE_INT64 -DUSE_ADDR64 -I VAX -I PDP11 -DUSE_NETWORK -I/usr/include/ -DUSE_TAP_NETWORK -DUSE_BSDTUNTAP -o BIN/vax780 -lm -lpthread -lpcap In file included from VAX/vax_cpu.c:182: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ VAX/vax_cpu.c:645:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 645 | if (temp = GET_TRAP (trpirq)) { /* trap? */ | ~~~~~^~~~~~~~~~~~~~~~~~~ VAX/vax_cpu.c:645:18: note: place parentheses around the assignment to silence this warning 645 | if (temp = GET_TRAP (trpirq)) { /* trap? */ | ^ | ( ) VAX/vax_cpu.c:645:18: note: use '==' to turn this assignment into an equality comparison 645 | if (temp = GET_TRAP (trpirq)) { /* trap? */ | ^ | == VAX/vax_cpu.c:653:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 653 | else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ | ~~~~~^~~~~~~~~~~~~~~~~~~ VAX/vax_cpu.c:653:23: note: place parentheses around the assignment to silence this warning 653 | else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ | ^ | ( ) VAX/vax_cpu.c:653:23: note: use '==' to turn this assignment into an equality comparison 653 | else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ | ^ | == 3 warnings generated. In file included from VAX/vax_cpu1.c:72: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from VAX/vax_fpa.c:59: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from VAX/vax_cis.c:53: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ VAX/vax_cis.c:334:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 334 | if (r = sim_process_event ()) { /* presumably WRU */ | ~~^~~~~~~~~~~~~~~~~~~~~~ VAX/vax_cis.c:334:23: note: place parentheses around the assignment to silence this warning 334 | if (r = sim_process_event ()) { /* presumably WRU */ | ^ | ( ) VAX/vax_cis.c:334:23: note: use '==' to turn this assignment into an equality comparison 334 | if (r = sim_process_event ()) { /* presumably WRU */ | ^ | == VAX/vax_cis.c:1228:59: warning: '/*' within block comment [-Wcomment] 1228 | /* if (((c & 0xF0) > 0x90) || /* check hi digit */ | ^ VAX/vax_cis.c:1229:59: warning: '/*' within block comment [-Wcomment] 1229 | /* ((c & 0x0F) > 0x09)) /* check lo digit */ | ^ VAX/vax_cis.c:1553:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1553 | if (s = sc * 4) { | ~~^~~~~~~~ VAX/vax_cis.c:1553:7: note: place parentheses around the assignment to silence this warning 1553 | if (s = sc * 4) { | ^ | ( ) VAX/vax_cis.c:1553:7: note: use '==' to turn this assignment into an equality comparison 1553 | if (s = sc * 4) { | ^ | == VAX/vax_cis.c:1577:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1577 | if (s = sc * 4) { | ~~^~~~~~~~ VAX/vax_cis.c:1577:7: note: place parentheses around the assignment to silence this warning 1577 | if (s = sc * 4) { | ^ | ( ) VAX/vax_cis.c:1577:7: note: use '==' to turn this assignment into an equality comparison 1577 | if (s = sc * 4) { | ^ | == 6 warnings generated. In file included from VAX/vax_octa.c:47: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ VAX/vax_octa.c:190:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 190 | if (r = op_tsth (opnd[0])) { /* test for 0 */ | ~~^~~~~~~~~~~~~~~~~~~ VAX/vax_octa.c:190:15: note: place parentheses around the assignment to silence this warning 190 | if (r = op_tsth (opnd[0])) { /* test for 0 */ | ^ | ( ) VAX/vax_octa.c:190:15: note: use '==' to turn this assignment into an equality comparison 190 | if (r = op_tsth (opnd[0])) { /* test for 0 */ | ^ | == VAX/vax_octa.c:201:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 201 | if (r = op_tsth (opnd[0])) { /* test for 0 */ | ~~^~~~~~~~~~~~~~~~~~~ VAX/vax_octa.c:201:15: note: place parentheses around the assignment to silence this warning 201 | if (r = op_tsth (opnd[0])) { /* test for 0 */ | ^ | ( ) VAX/vax_octa.c:201:15: note: use '==' to turn this assignment into an equality comparison 201 | if (r = op_tsth (opnd[0])) { /* test for 0 */ | ^ | == 3 warnings generated. In file included from VAX/vax_cmode.c:40: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ VAX/vax_cmode.c:624:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 624 | if (sign = ((src & WSIGN)? 1: 0)) | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~ VAX/vax_cmode.c:624:22: note: place parentheses around the assignment to silence this warning 624 | if (sign = ((src & WSIGN)? 1: 0)) | ^ | ( ) VAX/vax_cmode.c:624:22: note: use '==' to turn this assignment into an equality comparison 624 | if (sign = ((src & WSIGN)? 1: 0)) | ^ | == 2 warnings generated. In file included from VAX/vax_mmu.c:50: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from VAX/vax_sys.c:47: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ VAX/vax_sys.c:1176:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1176 | if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ VAX/vax_sys.c:1176:10: note: place parentheses around the assignment to silence this warning 1176 | if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ | ^ | ( ) VAX/vax_sys.c:1176:10: note: use '==' to turn this assignment into an equality comparison 1176 | if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ | ^ | == 2 warnings generated. In file included from VAX/vax_syscm.c:34: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from VAX/vax780_stddev.c:59: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from VAX/vax780_sbi.c:36: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ VAX/vax780_sbi.c:224:1: warning: '/*' within block comment [-Wcomment] 224 | /* Find highest priority vectorable interrupt */ | ^ VAX/vax780_sbi.c:645:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 645 | if (slptr = strchr (gbuf, '/')) { /* found slash? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ VAX/vax780_sbi.c:645:11: note: place parentheses around the assignment to silence this warning 645 | if (slptr = strchr (gbuf, '/')) { /* found slash? */ | ^ | ( ) VAX/vax780_sbi.c:645:11: note: use '==' to turn this assignment into an equality comparison 645 | if (slptr = strchr (gbuf, '/')) { /* found slash? */ | ^ | == VAX/vax780_sbi.c:791:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 791 | if (r = build_nexus_tab (dptr, dibp)) /* add to dispatch table */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ VAX/vax780_sbi.c:791:19: note: place parentheses around the assignment to silence this warning 791 | if (r = build_nexus_tab (dptr, dibp)) /* add to dispatch table */ | ^ | ( ) VAX/vax780_sbi.c:791:19: note: use '==' to turn this assignment into an equality comparison 791 | if (r = build_nexus_tab (dptr, dibp)) /* add to dispatch table */ | ^ | == VAX/vax780_sbi.c:795:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 795 | if (r = build_mbus_tab (dptr, dibp)) | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ VAX/vax780_sbi.c:795:19: note: place parentheses around the assignment to silence this warning 795 | if (r = build_mbus_tab (dptr, dibp)) | ^ | ( ) VAX/vax780_sbi.c:795:19: note: use '==' to turn this assignment into an equality comparison 795 | if (r = build_mbus_tab (dptr, dibp)) | ^ | == VAX/vax780_sbi.c:799:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 799 | if (r = build_ubus_tab (dptr, dibp)) /* add to dispatch tab */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ VAX/vax780_sbi.c:799:19: note: place parentheses around the assignment to silence this warning 799 | if (r = build_ubus_tab (dptr, dibp)) /* add to dispatch tab */ | ^ | ( ) VAX/vax780_sbi.c:799:19: note: use '==' to turn this assignment into an equality comparison 799 | if (r = build_ubus_tab (dptr, dibp)) /* add to dispatch tab */ | ^ | == 6 warnings generated. In file included from VAX/vax780_mem.c:31: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from VAX/vax780_uba.c:34: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from VAX/vax780_mba.c:31: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from VAX/vax780_fload.c:44: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from VAX/vax780_syslist.c:30: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from PDP11/pdp11_rl.c:93: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from PDP11/pdp11_rq.c:77: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_rq.c:99: PDP11/pdp11_mscp.h:213:57: warning: '/*' within block comment [-Wcomment] 213 | /* 5 /* reserved */ | ^ PDP11/pdp11_mscp.h:258:57: warning: '/*' within block comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:265:57: warning: '/*' within block comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:401:57: warning: '/*' within block comment [-Wcomment] 401 | /* 14 /* reserved */ | ^ PDP11/pdp11_mscp.h:402:57: warning: '/*' within block comment [-Wcomment] 402 | /* 15 /* reserved */ | ^ PDP11/pdp11_rq.c:1355:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1355:10: note: place parentheses around the assignment to silence this warning 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ^ | ( ) PDP11/pdp11_rq.c:1355:10: note: use '==' to turn this assignment into an equality comparison 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ^ | == PDP11/pdp11_rq.c:1368:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ~~~~^~~~~~~~~~~~ PDP11/pdp11_rq.c:1368:18: note: place parentheses around the assignment to silence this warning 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | ( ) PDP11/pdp11_rq.c:1368:18: note: use '==' to turn this assignment into an equality comparison 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | == PDP11/pdp11_rq.c:1369:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ~~~~~^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1369:21: note: place parentheses around the assignment to silence this warning 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ^ | ( ) PDP11/pdp11_rq.c:1369:21: note: use '==' to turn this assignment into an equality comparison 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ^ | == PDP11/pdp11_rq.c:1396:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1396:10: note: place parentheses around the assignment to silence this warning 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1396:10: note: use '==' to turn this assignment into an equality comparison 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1450:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1450:10: note: place parentheses around the assignment to silence this warning 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1450:10: note: use '==' to turn this assignment into an equality comparison 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1485:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1485:10: note: place parentheses around the assignment to silence this warning 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1485:10: note: use '==' to turn this assignment into an equality comparison 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1523:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1523:18: note: place parentheses around the assignment to silence this warning 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ^ | ( ) PDP11/pdp11_rq.c:1523:18: note: use '==' to turn this assignment into an equality comparison 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ^ | == PDP11/pdp11_rq.c:1550:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1550:10: note: place parentheses around the assignment to silence this warning 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1550:10: note: use '==' to turn this assignment into an equality comparison 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1579:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1579:10: note: place parentheses around the assignment to silence this warning 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1579:10: note: use '==' to turn this assignment into an equality comparison 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1613:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1613:10: note: place parentheses around the assignment to silence this warning 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_rq.c:1613:10: note: use '==' to turn this assignment into an equality comparison 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_rq.c:1657:57: warning: '/*' within block comment [-Wcomment] 1657 | /* if (lbn & 0xF0000000) return (ST_CMD | I_LBN); /* 'reasonable' lbn? */ | ^ PDP11/pdp11_rq.c:1728:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1728 | if (abc = tbc - t) { /* any xfer? */ | ~~~~^~~~~~~~~ PDP11/pdp11_rq.c:1728:13: note: place parentheses around the assignment to silence this warning 1728 | if (abc = tbc - t) { /* any xfer? */ | ^ | ( ) PDP11/pdp11_rq.c:1728:13: note: use '==' to turn this assignment into an equality comparison 1728 | if (abc = tbc - t) { /* any xfer? */ | ^ | == PDP11/pdp11_rq.c:1755:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:1755:15: note: place parentheses around the assignment to silence this warning 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ^ | ( ) PDP11/pdp11_rq.c:1755:15: note: use '==' to turn this assignment into an equality comparison 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ^ | == PDP11/pdp11_rq.c:2589:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2589 | if (pkt = uptr->pktq) { | ~~~~^~~~~~~~~~~~ PDP11/pdp11_rq.c:2589:13: note: place parentheses around the assignment to silence this warning 2589 | if (pkt = uptr->pktq) { | ^ | ( ) PDP11/pdp11_rq.c:2589:13: note: use '==' to turn this assignment into an equality comparison 2589 | if (pkt = uptr->pktq) { | ^ | == PDP11/pdp11_rq.c:2593:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2593 | } while (pkt = cp->pak[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:2593:26: note: place parentheses around the assignment to silence this warning 2593 | } while (pkt = cp->pak[pkt].link); | ^ | ( ) PDP11/pdp11_rq.c:2593:26: note: use '==' to turn this assignment into an equality comparison 2593 | } while (pkt = cp->pak[pkt].link); | ^ | == PDP11/pdp11_rq.c:2620:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2620 | if (pkt = cp->freq) { | ~~~~^~~~~~~~~~ PDP11/pdp11_rq.c:2620:13: note: place parentheses around the assignment to silence this warning 2620 | if (pkt = cp->freq) { | ^ | ( ) PDP11/pdp11_rq.c:2620:13: note: use '==' to turn this assignment into an equality comparison 2620 | if (pkt = cp->freq) { | ^ | == PDP11/pdp11_rq.c:2633:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2633 | if (pkt = cp->rspq) { | ~~~~^~~~~~~~~~ PDP11/pdp11_rq.c:2633:13: note: place parentheses around the assignment to silence this warning 2633 | if (pkt = cp->rspq) { | ^ | ( ) PDP11/pdp11_rq.c:2633:13: note: use '==' to turn this assignment into an equality comparison 2633 | if (pkt = cp->rspq) { | ^ | == PDP11/pdp11_rq.c:2637:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2637 | } while (pkt = cp->pak[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_rq.c:2637:26: note: place parentheses around the assignment to silence this warning 2637 | } while (pkt = cp->pak[pkt].link); | ^ | ( ) PDP11/pdp11_rq.c:2637:26: note: use '==' to turn this assignment into an equality comparison 2637 | } while (pkt = cp->pak[pkt].link); | ^ | == 24 warnings generated. In file included from PDP11/pdp11_ts.c:93: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ PDP11/pdp11_ts.c:493:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:493:12: note: place parentheses around the assignment to silence this warning 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | ( ) PDP11/pdp11_ts.c:493:12: note: use '==' to turn this assignment into an equality comparison 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | == PDP11/pdp11_ts.c:536:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:536:12: note: place parentheses around the assignment to silence this warning 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | ( ) PDP11/pdp11_ts.c:536:12: note: use '==' to turn this assignment into an equality comparison 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | == PDP11/pdp11_ts.c:669:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:669:8: note: place parentheses around the assignment to silence this warning 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ^ | ( ) PDP11/pdp11_ts.c:669:8: note: use '==' to turn this assignment into an equality comparison 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ^ | == PDP11/pdp11_ts.c:682:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_ts.c:682:8: note: place parentheses around the assignment to silence this warning 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP11/pdp11_ts.c:682:8: note: use '==' to turn this assignment into an equality comparison 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == 5 warnings generated. In file included from PDP11/pdp11_dz.c:68: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from PDP11/pdp11_lp.c:45: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from PDP11/pdp11_tq.c:68: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ In file included from PDP11/pdp11_tq.c:85: PDP11/pdp11_mscp.h:213:57: warning: '/*' within block comment [-Wcomment] 213 | /* 5 /* reserved */ | ^ PDP11/pdp11_mscp.h:258:57: warning: '/*' within block comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:265:57: warning: '/*' within block comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | ^ PDP11/pdp11_mscp.h:401:57: warning: '/*' within block comment [-Wcomment] 401 | /* 14 /* reserved */ | ^ PDP11/pdp11_mscp.h:402:57: warning: '/*' within block comment [-Wcomment] 402 | /* 15 /* reserved */ | ^ PDP11/pdp11_tq.c:783:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:783:14: note: place parentheses around the assignment to silence this warning 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ^ | ( ) PDP11/pdp11_tq.c:783:14: note: use '==' to turn this assignment into an equality comparison 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ^ | == PDP11/pdp11_tq.c:789:57: warning: '/*' within block comment [-Wcomment] 789 | /* if (tq_cmf[cmd] & MD_CDL) /* clr cch lost? */ | ^ PDP11/pdp11_tq.c:861:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:861:10: note: place parentheses around the assignment to silence this warning 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ^ | ( ) PDP11/pdp11_tq.c:861:10: note: use '==' to turn this assignment into an equality comparison 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ^ | == PDP11/pdp11_tq.c:874:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ~~~~^~~~~~~~~~~~ PDP11/pdp11_tq.c:874:18: note: place parentheses around the assignment to silence this warning 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | ( ) PDP11/pdp11_tq.c:874:18: note: use '==' to turn this assignment into an equality comparison 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^ | == PDP11/pdp11_tq.c:875:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ~~~~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:875:21: note: place parentheses around the assignment to silence this warning 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ^ | ( ) PDP11/pdp11_tq.c:875:21: note: use '==' to turn this assignment into an equality comparison 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ^ | == PDP11/pdp11_tq.c:903:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:903:10: note: place parentheses around the assignment to silence this warning 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:903:10: note: use '==' to turn this assignment into an equality comparison 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:958:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:958:10: note: place parentheses around the assignment to silence this warning 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:958:10: note: use '==' to turn this assignment into an equality comparison 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:983:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:983:10: note: place parentheses around the assignment to silence this warning 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:983:10: note: use '==' to turn this assignment into an equality comparison 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1012:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1012:17: note: place parentheses around the assignment to silence this warning 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ^ | ( ) PDP11/pdp11_tq.c:1012:17: note: use '==' to turn this assignment into an equality comparison 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ^ | == PDP11/pdp11_tq.c:1036:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1036:10: note: place parentheses around the assignment to silence this warning 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1036:10: note: use '==' to turn this assignment into an equality comparison 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1058:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1058:10: note: place parentheses around the assignment to silence this warning 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1058:10: note: use '==' to turn this assignment into an equality comparison 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1074:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1074:10: note: place parentheses around the assignment to silence this warning 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1074:10: note: use '==' to turn this assignment into an equality comparison 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1095:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1095:10: note: place parentheses around the assignment to silence this warning 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1095:10: note: use '==' to turn this assignment into an equality comparison 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1118:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1118:10: note: place parentheses around the assignment to silence this warning 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1118:10: note: use '==' to turn this assignment into an equality comparison 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1150:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ~~~~~^~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1150:10: note: place parentheses around the assignment to silence this warning 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | ( ) PDP11/pdp11_tq.c:1150:10: note: use '==' to turn this assignment into an equality comparison 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^ | == PDP11/pdp11_tq.c:1254:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1254:19: note: place parentheses around the assignment to silence this warning 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ^ | ( ) PDP11/pdp11_tq.c:1254:19: note: use '==' to turn this assignment into an equality comparison 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ^ | == PDP11/pdp11_tq.c:1291:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:1291:15: note: place parentheses around the assignment to silence this warning 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ^ | ( ) PDP11/pdp11_tq.c:1291:15: note: use '==' to turn this assignment into an equality comparison 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ^ | == PDP11/pdp11_tq.c:2236:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2236 | if (pkt = uptr->pktq) { | ~~~~^~~~~~~~~~~~ PDP11/pdp11_tq.c:2236:13: note: place parentheses around the assignment to silence this warning 2236 | if (pkt = uptr->pktq) { | ^ | ( ) PDP11/pdp11_tq.c:2236:13: note: use '==' to turn this assignment into an equality comparison 2236 | if (pkt = uptr->pktq) { | ^ | == PDP11/pdp11_tq.c:2240:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2240 | } while (pkt = tq_pkt[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:2240:26: note: place parentheses around the assignment to silence this warning 2240 | } while (pkt = tq_pkt[pkt].link); | ^ | ( ) PDP11/pdp11_tq.c:2240:26: note: use '==' to turn this assignment into an equality comparison 2240 | } while (pkt = tq_pkt[pkt].link); | ^ | == PDP11/pdp11_tq.c:2265:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2265 | if (pkt = tq_freq) { | ~~~~^~~~~~~~~ PDP11/pdp11_tq.c:2265:13: note: place parentheses around the assignment to silence this warning 2265 | if (pkt = tq_freq) { | ^ | ( ) PDP11/pdp11_tq.c:2265:13: note: use '==' to turn this assignment into an equality comparison 2265 | if (pkt = tq_freq) { | ^ | == PDP11/pdp11_tq.c:2278:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2278 | if (pkt = tq_rspq) { | ~~~~^~~~~~~~~ PDP11/pdp11_tq.c:2278:13: note: place parentheses around the assignment to silence this warning 2278 | if (pkt = tq_rspq) { | ^ | ( ) PDP11/pdp11_tq.c:2278:13: note: use '==' to turn this assignment into an equality comparison 2278 | if (pkt = tq_rspq) { | ^ | == PDP11/pdp11_tq.c:2282:26: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2282 | } while (pkt = tq_pkt[pkt].link); | ~~~~^~~~~~~~~~~~~~~~~~ PDP11/pdp11_tq.c:2282:26: note: place parentheses around the assignment to silence this warning 2282 | } while (pkt = tq_pkt[pkt].link); | ^ | ( ) PDP11/pdp11_tq.c:2282:26: note: use '==' to turn this assignment into an equality comparison 2282 | } while (pkt = tq_pkt[pkt].link); | ^ | == 28 warnings generated. In file included from PDP11/pdp11_xu.c:100: In file included from PDP11/pdp11_xu.h:55: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ PDP11/pdp11_xu.c:1044:24: warning: '/*' within block comment [-Wcomment] 1044 | /* xu_dump_rxring(xu); /* debug receive ring */ | ^ PDP11/pdp11_xu.c:1216:24: warning: '/*' within block comment [-Wcomment] 1216 | /* xu_dump_txring(xu); /* debug receive ring */ | ^ 3 warnings generated. In file included from PDP11/pdp11_ry.c:50: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from PDP11/pdp11_cr.c:175: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ PDP11/pdp11_cr.c:458:30: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 458 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cr.c:544:34: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 544 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ PDP11/pdp11_cr.c:619:38: warning: implicit conversion from 'const int' to 'char' changes value from 255 to -1 [-Wconstant-conversion] 619 | ccard[col] = h2c_code[PUNCH_EOD]; | ~ ^~~~~~~~~~~~~~~~~~~ 4 warnings generated. In file included from PDP11/pdp11_rp.c:58: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from PDP11/pdp11_tu.c:63: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ PDP11/pdp11_tu.c:650:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 650 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:650:20: note: place parentheses around the assignment to silence this warning 650 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) PDP11/pdp11_tu.c:650:20: note: use '==' to turn this assignment into an equality comparison 650 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == PDP11/pdp11_tu.c:663:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 663 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:663:20: note: place parentheses around the assignment to silence this warning 663 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) PDP11/pdp11_tu.c:663:20: note: use '==' to turn this assignment into an equality comparison 663 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == PDP11/pdp11_tu.c:674:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 674 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:674:16: note: place parentheses around the assignment to silence this warning 674 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) PDP11/pdp11_tu.c:674:16: note: use '==' to turn this assignment into an equality comparison 674 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == PDP11/pdp11_tu.c:690:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 690 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:690:16: note: place parentheses around the assignment to silence this warning 690 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ^ | ( ) PDP11/pdp11_tu.c:690:16: note: use '==' to turn this assignment into an equality comparison 690 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ^ | == PDP11/pdp11_tu.c:742:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 742 | if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:742:16: note: place parentheses around the assignment to silence this warning 742 | if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ | ^ | ( ) PDP11/pdp11_tu.c:742:16: note: use '==' to turn this assignment into an equality comparison 742 | if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ | ^ | == PDP11/pdp11_tu.c:754:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 754 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_tu.c:754:16: note: place parentheses around the assignment to silence this warning 754 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ^ | ( ) PDP11/pdp11_tu.c:754:16: note: use '==' to turn this assignment into an equality comparison 754 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ^ | == 7 warnings generated. In file included from PDP11/pdp11_hk.c:60: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ PDP11/pdp11_hk.c:890:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 890 | if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_hk.c:890:23: note: place parentheses around the assignment to silence this warning 890 | if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ | ^ | ( ) PDP11/pdp11_hk.c:890:23: note: use '==' to turn this assignment into an equality comparison 890 | if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ | ^ | == PDP11/pdp11_hk.c:898:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 898 | if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_hk.c:898:23: note: place parentheses around the assignment to silence this warning 898 | if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ | ^ | ( ) PDP11/pdp11_hk.c:898:23: note: use '==' to turn this assignment into an equality comparison 898 | if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ | ^ | == PDP11/pdp11_hk.c:918:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 918 | if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_hk.c:918:23: note: place parentheses around the assignment to silence this warning 918 | if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { | ^ | ( ) PDP11/pdp11_hk.c:918:23: note: use '==' to turn this assignment into an equality comparison 918 | if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { | ^ | == PDP11/pdp11_hk.c:924:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 924 | if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PDP11/pdp11_hk.c:924:23: note: place parentheses around the assignment to silence this warning 924 | if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ | ^ | ( ) PDP11/pdp11_hk.c:924:23: note: use '==' to turn this assignment into an equality comparison 924 | if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ | ^ | == 5 warnings generated. In file included from PDP11/pdp11_io_lib.c:31: VAX/vax_defs.h:476:57: warning: '/*' within block comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | ^ 1 warning generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_ether.c:1336:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ sim_ether.c:1336:13: note: place parentheses around the assignment to silence this warning 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ^ | ( ) sim_ether.c:1336:13: note: use '==' to turn this assignment into an equality comparison 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ^ | == sim_ether.c:1522:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1522 | while (request = dev->write_requests) { | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ sim_ether.c:1522:18: note: place parentheses around the assignment to silence this warning 1522 | while (request = dev->write_requests) { | ^ | ( ) sim_ether.c:1522:18: note: use '==' to turn this assignment into an equality comparison 1522 | while (request = dev->write_requests) { | ^ | == sim_ether.c:1835:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1835 | while (buffer = dev->write_buffers) { | ~~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_ether.c:1835:18: note: place parentheses around the assignment to silence this warning 1835 | while (buffer = dev->write_buffers) { | ^ | ( ) sim_ether.c:1835:18: note: use '==' to turn this assignment into an equality comparison 1835 | while (buffer = dev->write_buffers) { | ^ | == sim_ether.c:1839:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1839 | while (buffer = dev->write_requests) { | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~ sim_ether.c:1839:17: note: place parentheses around the assignment to silence this warning 1839 | while (buffer = dev->write_requests) { | ^ | ( ) sim_ether.c:1839:17: note: use '==' to turn this assignment into an equality comparison 1839 | while (buffer = dev->write_requests) { | ^ | == sim_ether.c:2092:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2092 | if (request = dev->write_buffers) | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_ether.c:2092:13: note: place parentheses around the assignment to silence this warning 2092 | if (request = dev->write_buffers) | ^ | ( ) sim_ether.c:2092:13: note: use '==' to turn this assignment into an equality comparison 2092 | if (request = dev->write_buffers) | ^ | == 5 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: pdp11_xu.c(/tmp/pdp11_xu-f57369.o:(xu_attach)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: scp.c(/tmp/scp-c530c6.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-53408b.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so NOVA/nova_sys.c NOVA/nova_cpu.c NOVA/nova_dkp.c NOVA/nova_dsk.c NOVA/nova_lp.c NOVA/nova_mta.c NOVA/nova_plt.c NOVA/nova_pt.c NOVA/nova_clk.c NOVA/nova_tt.c NOVA/nova_tt1.c NOVA/nova_qty.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I NOVA -o BIN/nova -lm -lpthread -lpcap NOVA/nova_cpu.c:463:16: warning: add explicit braces to avoid dangling else [-Wdangling-else] 463 | indf = IND_STEP (MA); | ^ NOVA/nova_cpu.c:249:29: note: expanded from macro 'IND_STEP' 249 | else \ | ^ NOVA/nova_cpu.c:468:20: warning: add explicit braces to avoid dangling else [-Wdangling-else] 468 | indf = IND_STEP (MA); /* indirect loop */ | ^ NOVA/nova_cpu.c:249:29: note: expanded from macro 'IND_STEP' 249 | else \ | ^ NOVA/nova_cpu.c:625:24: warning: add explicit braces to avoid dangling else [-Wdangling-else] 625 | indf = IND_STEP (MA); | ^ NOVA/nova_cpu.c:249:29: note: expanded from macro 'IND_STEP' 249 | else \ | ^ NOVA/nova_cpu.c:630:28: warning: add explicit braces to avoid dangling else [-Wdangling-else] 630 | indf = IND_STEP (MA); /* resolve indirect */ | ^ NOVA/nova_cpu.c:249:29: note: expanded from macro 'IND_STEP' 249 | else \ | ^ 4 warnings generated. NOVA/nova_dkp.c:912:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 912 | if (err = ferror (uptr->fileref)) | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_dkp.c:912:21: note: place parentheses around the assignment to silence this warning 912 | if (err = ferror (uptr->fileref)) | ^ | ( ) NOVA/nova_dkp.c:912:21: note: use '==' to turn this assignment into an equality comparison 912 | if (err = ferror (uptr->fileref)) | ^ | == NOVA/nova_dkp.c:928:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 928 | if (err = ferror (uptr->fileref)) | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_dkp.c:928:21: note: place parentheses around the assignment to silence this warning 928 | if (err = ferror (uptr->fileref)) | ^ | ( ) NOVA/nova_dkp.c:928:21: note: use '==' to turn this assignment into an equality comparison 928 | if (err = ferror (uptr->fileref)) | ^ | == 2 warnings generated. NOVA/nova_mta.c:415:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 415 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_mta.c:415:16: note: place parentheses around the assignment to silence this warning 415 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ^ | ( ) NOVA/nova_mta.c:415:16: note: use '==' to turn this assignment into an equality comparison 415 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ^ | == NOVA/nova_mta.c:424:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 424 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_mta.c:424:16: note: place parentheses around the assignment to silence this warning 424 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) NOVA/nova_mta.c:424:16: note: use '==' to turn this assignment into an equality comparison 424 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == NOVA/nova_mta.c:438:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 438 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_mta.c:438:20: note: place parentheses around the assignment to silence this warning 438 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) NOVA/nova_mta.c:438:20: note: use '==' to turn this assignment into an equality comparison 438 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == NOVA/nova_mta.c:450:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 450 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_mta.c:450:20: note: place parentheses around the assignment to silence this warning 450 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) NOVA/nova_mta.c:450:20: note: use '==' to turn this assignment into an equality comparison 450 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == NOVA/nova_mta.c:496:57: warning: '/*' within block comment [-Wcomment] 496 | /* if (mta_ep) { /* if polling */ | ^ NOVA/nova_mta.c:497:57: warning: '/*' within block comment [-Wcomment] 497 | /* u = uptr - mta_dev.units; /* unit num */ | ^ NOVA/nova_mta.c:499:1: warning: '/*' within block comment [-Wcomment] 499 | /* set polling interupt... | ^ NOVA/nova_mta.c:500:1: warning: '/*' within block comment [-Wcomment] 500 | /* } */ | ^ 8 warnings generated. NOVA/nova_tt1.c:187:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 187 | if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_tt1.c:187:14: note: place parentheses around the assignment to silence this warning 187 | if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ | ^ | ( ) NOVA/nova_tt1.c:187:14: note: use '==' to turn this assignment into an equality comparison 187 | if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ | ^ | == 1 warning generated. NOVA/nova_qty.c:611:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 611 | else | ^ NOVA/nova_qty.c:1003:9: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1003 | else | ^ 2 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: nova_cpu.c(/tmp/nova_cpu-4cad63.o:(devBitNames)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: nova_cpu.c(/tmp/nova_cpu-4cad63.o:(devBitNames)): warning: strcat() is almost always misused, please use strlcat() ld: warning: sim_ether.c(/tmp/sim_ether-27de42.o:(eth_mac_fmt)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so NOVA/eclipse_cpu.c NOVA/eclipse_tt.c NOVA/nova_sys.c NOVA/nova_dkp.c NOVA/nova_dsk.c NOVA/nova_lp.c NOVA/nova_mta.c NOVA/nova_plt.c NOVA/nova_pt.c NOVA/nova_clk.c NOVA/nova_tt1.c NOVA/nova_qty.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I NOVA -DECLIPSE -o BIN/eclipse -lm -lpthread -lpcap NOVA/eclipse_cpu.c:747:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 747 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ NOVA/eclipse_cpu.c:747:16: note: place parentheses around the assignment to silence this warning 747 | if (reason = sim_process_event ()) | ^ | ( ) NOVA/eclipse_cpu.c:747:16: note: use '==' to turn this assignment into an equality comparison 747 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. NOVA/nova_dkp.c:912:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 912 | if (err = ferror (uptr->fileref)) | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_dkp.c:912:21: note: place parentheses around the assignment to silence this warning 912 | if (err = ferror (uptr->fileref)) | ^ | ( ) NOVA/nova_dkp.c:912:21: note: use '==' to turn this assignment into an equality comparison 912 | if (err = ferror (uptr->fileref)) | ^ | == NOVA/nova_dkp.c:928:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 928 | if (err = ferror (uptr->fileref)) | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_dkp.c:928:21: note: place parentheses around the assignment to silence this warning 928 | if (err = ferror (uptr->fileref)) | ^ | ( ) NOVA/nova_dkp.c:928:21: note: use '==' to turn this assignment into an equality comparison 928 | if (err = ferror (uptr->fileref)) | ^ | == 2 warnings generated. NOVA/nova_mta.c:415:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 415 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_mta.c:415:16: note: place parentheses around the assignment to silence this warning 415 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ^ | ( ) NOVA/nova_mta.c:415:16: note: use '==' to turn this assignment into an equality comparison 415 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ^ | == NOVA/nova_mta.c:424:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 424 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_mta.c:424:16: note: place parentheses around the assignment to silence this warning 424 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) NOVA/nova_mta.c:424:16: note: use '==' to turn this assignment into an equality comparison 424 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == NOVA/nova_mta.c:438:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 438 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_mta.c:438:20: note: place parentheses around the assignment to silence this warning 438 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | ( ) NOVA/nova_mta.c:438:20: note: use '==' to turn this assignment into an equality comparison 438 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^ | == NOVA/nova_mta.c:450:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 450 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_mta.c:450:20: note: place parentheses around the assignment to silence this warning 450 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | ( ) NOVA/nova_mta.c:450:20: note: use '==' to turn this assignment into an equality comparison 450 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^ | == NOVA/nova_mta.c:496:57: warning: '/*' within block comment [-Wcomment] 496 | /* if (mta_ep) { /* if polling */ | ^ NOVA/nova_mta.c:497:57: warning: '/*' within block comment [-Wcomment] 497 | /* u = uptr - mta_dev.units; /* unit num */ | ^ NOVA/nova_mta.c:499:1: warning: '/*' within block comment [-Wcomment] 499 | /* set polling interupt... | ^ NOVA/nova_mta.c:500:1: warning: '/*' within block comment [-Wcomment] 500 | /* } */ | ^ 8 warnings generated. NOVA/nova_tt1.c:187:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 187 | if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ NOVA/nova_tt1.c:187:14: note: place parentheses around the assignment to silence this warning 187 | if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ | ^ | ( ) NOVA/nova_tt1.c:187:14: note: use '==' to turn this assignment into an equality comparison 187 | if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ | ^ | == 1 warning generated. NOVA/nova_qty.c:611:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 611 | else | ^ NOVA/nova_qty.c:1003:9: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1003 | else | ^ 2 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: sim_ether.c(/tmp/sim_ether-0c1f21.o:(eth_mac_fmt)): warning: sprintf() is often misused, please use snprintf() ld: warning: sim_ether.c(/tmp/sim_ether-0c1f21.o:(eth_getname)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: scp.c(/tmp/scp-d2cbc7.o:(main)): warning: strcat() is almost always misused, please use strlcat() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so HP2100/hp2100_stddev.c HP2100/hp2100_dp.c HP2100/hp2100_dq.c HP2100/hp2100_dr.c HP2100/hp2100_lps.c HP2100/hp2100_ms.c HP2100/hp2100_mt.c HP2100/hp2100_mux.c HP2100/hp2100_cpu.c HP2100/hp2100_fp.c HP2100/hp2100_sys.c HP2100/hp2100_lpt.c HP2100/hp2100_ipl.c HP2100/hp2100_ds.c HP2100/hp2100_cpu0.c HP2100/hp2100_cpu1.c HP2100/hp2100_cpu2.c HP2100/hp2100_cpu3.c HP2100/hp2100_cpu4.c HP2100/hp2100_cpu5.c HP2100/hp2100_cpu6.c HP2100/hp2100_cpu7.c HP2100/hp2100_fp1.c HP2100/hp2100_baci.c HP2100/hp2100_mpx.c HP2100/hp2100_pif.c HP2100/hp2100_di.c HP2100/hp2100_di_da.c HP2100/hp_disclib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DHAVE_INT64 -I HP2100 -o BIN/hp2100 -lm -lpthread -lpcap HP2100/hp2100_stddev.c:945:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 945 | if (r = sim_putchar_s (c)) return r; /* output char */ | ~~^~~~~~~~~~~~~~~~~~~ HP2100/hp2100_stddev.c:945:15: note: place parentheses around the assignment to silence this warning 945 | if (r = sim_putchar_s (c)) return r; /* output char */ | ^ | ( ) HP2100/hp2100_stddev.c:945:15: note: use '==' to turn this assignment into an equality comparison 945 | if (r = sim_putchar_s (c)) return r; /* output char */ | ^ | == HP2100/hp2100_stddev.c:1118:21: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1118 | else | ^ 2 warnings generated. HP2100/hp2100_dp.c:193:57: warning: '/*' within block comment [-Wcomment] 193 | /* 0000200 /* unused */ | ^ HP2100/hp2100_dp.c:697:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 697 | if (t = sim_is_active (&dpc_unit[drv])) { /* still seeking? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_dp.c:697:7: note: place parentheses around the assignment to silence this warning 697 | if (t = sim_is_active (&dpc_unit[drv])) { /* still seeking? */ | ^ | ( ) HP2100/hp2100_dp.c:697:7: note: use '==' to turn this assignment into an equality comparison 697 | if (t = sim_is_active (&dpc_unit[drv])) { /* still seeking? */ | ^ | == HP2100/hp2100_dp.c:909:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 909 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 910 | SEEK_SET)) break; | ~~~~~~~~~ HP2100/hp2100_dp.c:909:21: note: place parentheses around the assignment to silence this warning 909 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^ | ( 910 | SEEK_SET)) break; | | ) HP2100/hp2100_dp.c:909:21: note: use '==' to turn this assignment into an equality comparison 909 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^ | == HP2100/hp2100_dp.c:912:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 912 | if (err = ferror (uptr->fileref)) break; | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_dp.c:912:21: note: place parentheses around the assignment to silence this warning 912 | if (err = ferror (uptr->fileref)) break; | ^ | ( ) HP2100/hp2100_dp.c:912:21: note: use '==' to turn this assignment into an equality comparison 912 | if (err = ferror (uptr->fileref)) break; | ^ | == HP2100/hp2100_dp.c:956:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 956 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 957 | SEEK_SET)) break; | ~~~~~~~~~ HP2100/hp2100_dp.c:956:21: note: place parentheses around the assignment to silence this warning 956 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^ | ( 957 | SEEK_SET)) break; | | ) HP2100/hp2100_dp.c:956:21: note: use '==' to turn this assignment into an equality comparison 956 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^ | == HP2100/hp2100_dp.c:959:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 959 | if (err = ferror (uptr->fileref)) break; /* error? */ | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_dp.c:959:21: note: place parentheses around the assignment to silence this warning 959 | if (err = ferror (uptr->fileref)) break; /* error? */ | ^ | ( ) HP2100/hp2100_dp.c:959:21: note: use '==' to turn this assignment into an equality comparison 959 | if (err = ferror (uptr->fileref)) break; /* error? */ | ^ | == 6 warnings generated. HP2100/hp2100_dq.c:103:57: warning: '/*' within block comment [-Wcomment] 103 | /* 000 /* unused */ | ^ HP2100/hp2100_dq.c:533:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 533 | if (t = sim_is_active (&dqc_unit[drv])) { /* still seeking? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_dq.c:533:7: note: place parentheses around the assignment to silence this warning 533 | if (t = sim_is_active (&dqc_unit[drv])) { /* still seeking? */ | ^ | ( ) HP2100/hp2100_dq.c:533:7: note: use '==' to turn this assignment into an equality comparison 533 | if (t = sim_is_active (&dqc_unit[drv])) { /* still seeking? */ | ^ | == HP2100/hp2100_dq.c:743:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 743 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 744 | SEEK_SET)) break; | ~~~~~~~~~ HP2100/hp2100_dq.c:743:21: note: place parentheses around the assignment to silence this warning 743 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^ | ( 744 | SEEK_SET)) break; | | ) HP2100/hp2100_dq.c:743:21: note: use '==' to turn this assignment into an equality comparison 743 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^ | == HP2100/hp2100_dq.c:746:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 746 | if (err = ferror (uptr->fileref)) break; | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_dq.c:746:21: note: place parentheses around the assignment to silence this warning 746 | if (err = ferror (uptr->fileref)) break; | ^ | ( ) HP2100/hp2100_dq.c:746:21: note: use '==' to turn this assignment into an equality comparison 746 | if (err = ferror (uptr->fileref)) break; | ^ | == HP2100/hp2100_dq.c:789:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 789 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 790 | SEEK_SET)) return TRUE; | ~~~~~~~~~ HP2100/hp2100_dq.c:789:21: note: place parentheses around the assignment to silence this warning 789 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^ | ( 790 | SEEK_SET)) return TRUE; | | ) HP2100/hp2100_dq.c:789:21: note: use '==' to turn this assignment into an equality comparison 789 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^ | == HP2100/hp2100_dq.c:792:21: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 792 | if (err = ferror (uptr->fileref)) break; | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_dq.c:792:21: note: place parentheses around the assignment to silence this warning 792 | if (err = ferror (uptr->fileref)) break; | ^ | ( ) HP2100/hp2100_dq.c:792:21: note: use '==' to turn this assignment into an equality comparison 792 | if (err = ferror (uptr->fileref)) break; | ^ | == 6 warnings generated. HP2100/hp2100_lps.c:378:21: warning: add explicit braces to avoid dangling else [-Wdangling-else] 378 | else /* 2100 or 1000 */ | ^ 1 warning generated. HP2100/hp2100_ms.c:740:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 740 | if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ | ~~~^~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_ms.c:740:20: note: place parentheses around the assignment to silence this warning 740 | if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ | ^ | ( ) HP2100/hp2100_ms.c:740:20: note: use '==' to turn this assignment into an equality comparison 740 | if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ | ^ | == HP2100/hp2100_ms.c:750:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 750 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_ms.c:750:16: note: place parentheses around the assignment to silence this warning 750 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) HP2100/hp2100_ms.c:750:16: note: use '==' to turn this assignment into an equality comparison 750 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == HP2100/hp2100_ms.c:756:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 756 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_ms.c:756:16: note: place parentheses around the assignment to silence this warning 756 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | ( ) HP2100/hp2100_ms.c:756:16: note: use '==' to turn this assignment into an equality comparison 756 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | == HP2100/hp2100_ms.c:764:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 764 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_ms.c:764:16: note: place parentheses around the assignment to silence this warning 764 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | ( ) HP2100/hp2100_ms.c:764:16: note: use '==' to turn this assignment into an equality comparison 764 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | == HP2100/hp2100_ms.c:834:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 834 | if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ | ~~~^~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_ms.c:834:24: note: place parentheses around the assignment to silence this warning 834 | if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ | ^ | ( ) HP2100/hp2100_ms.c:834:24: note: use '==' to turn this assignment into an equality comparison 834 | if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ | ^ | == HP2100/hp2100_ms.c:858:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 858 | if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr)) { /* write, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_ms.c:858:20: note: place parentheses around the assignment to silence this warning 858 | if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr)) { /* write, err? */ | ^ | ( ) HP2100/hp2100_ms.c:858:20: note: use '==' to turn this assignment into an equality comparison 858 | if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr)) { /* write, err? */ | ^ | == HP2100/hp2100_ms.c:897:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 897 | if (st = sim_tape_wrgap (uptr, gap_len, tape_bpi)) /* write gap */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_ms.c:897:8: note: place parentheses around the assignment to silence this warning 897 | if (st = sim_tape_wrgap (uptr, gap_len, tape_bpi)) /* write gap */ | ^ | ( ) HP2100/hp2100_ms.c:897:8: note: use '==' to turn this assignment into an equality comparison 897 | if (st = sim_tape_wrgap (uptr, gap_len, tape_bpi)) /* write gap */ | ^ | == HP2100/hp2100_ms.c:977:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 977 | if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr | MTR_ERF)) | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_ms.c:977:16: note: place parentheses around the assignment to silence this warning 977 | if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr | MTR_ERF)) | ^ | ( ) HP2100/hp2100_ms.c:977:16: note: use '==' to turn this assignment into an equality comparison 977 | if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr | MTR_ERF)) | ^ | == 8 warnings generated. HP2100/hp2100_mt.c:498:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 498 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_mt.c:498:16: note: place parentheses around the assignment to silence this warning 498 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) HP2100/hp2100_mt.c:498:16: note: use '==' to turn this assignment into an equality comparison 498 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == HP2100/hp2100_mt.c:507:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 507 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_mt.c:507:16: note: place parentheses around the assignment to silence this warning 507 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | ( ) HP2100/hp2100_mt.c:507:16: note: use '==' to turn this assignment into an equality comparison 507 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^ | == HP2100/hp2100_mt.c:512:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 512 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_mt.c:512:16: note: place parentheses around the assignment to silence this warning 512 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | ( ) HP2100/hp2100_mt.c:512:16: note: use '==' to turn this assignment into an equality comparison 512 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^ | == HP2100/hp2100_mt.c:561:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 561 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) { /* write, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_mt.c:561:20: note: place parentheses around the assignment to silence this warning 561 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) { /* write, err? */ | ^ | ( ) HP2100/hp2100_mt.c:561:20: note: use '==' to turn this assignment into an equality comparison 561 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) { /* write, err? */ | ^ | == HP2100/hp2100_mt.c:630:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 630 | if (st = sim_tape_wrrecf (&mtc_unit, mtxb, mt_ptr | MTR_ERF)) | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_mt.c:630:12: note: place parentheses around the assignment to silence this warning 630 | if (st = sim_tape_wrrecf (&mtc_unit, mtxb, mt_ptr | MTR_ERF)) | ^ | ( ) HP2100/hp2100_mt.c:630:12: note: use '==' to turn this assignment into an equality comparison 630 | if (st = sim_tape_wrrecf (&mtc_unit, mtxb, mt_ptr | MTR_ERF)) | ^ | == 5 warnings generated. HP2100/hp2100_mux.c:656:17: warning: add explicit braces to avoid dangling else [-Wdangling-else] 656 | else | ^ HP2100/hp2100_mux.c:1113:13: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1113 | else | ^ 2 warnings generated. HP2100/hp2100_cpu.c:1057:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1057 | for (i = 0; dptr = sim_devices [i]; i++) { /* loop thru dev */ | ~~~~~^~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu.c:1057:18: note: place parentheses around the assignment to silence this warning 1057 | for (i = 0; dptr = sim_devices [i]; i++) { /* loop thru dev */ | ^ | ( ) HP2100/hp2100_cpu.c:1057:18: note: use '==' to turn this assignment into an equality comparison 1057 | for (i = 0; dptr = sim_devices [i]; i++) { /* loop thru dev */ | ^ | == HP2100/hp2100_cpu.c:2160:9: warning: add explicit braces to avoid dangling else [-Wdangling-else] 2160 | else /* not this one */ | ^ HP2100/hp2100_cpu.c:3614:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3614 | for (i = 0; dptr = sim_devices[i]; i++) { | ~~~~~^~~~~~~~~~~~~~~~ HP2100/hp2100_cpu.c:3614:18: note: place parentheses around the assignment to silence this warning 3614 | for (i = 0; dptr = sim_devices[i]; i++) { | ^ | ( ) HP2100/hp2100_cpu.c:3614:18: note: use '==' to turn this assignment into an equality comparison 3614 | for (i = 0; dptr = sim_devices[i]; i++) { | ^ | == HP2100/hp2100_cpu.c:3632:30: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3632 | for (j = 0; dptr = sim_devices[j]; j++) { | ~~~~~^~~~~~~~~~~~~~~~ HP2100/hp2100_cpu.c:3632:30: note: place parentheses around the assignment to silence this warning 3632 | for (j = 0; dptr = sim_devices[j]; j++) { | ^ | ( ) HP2100/hp2100_cpu.c:3632:30: note: use '==' to turn this assignment into an equality comparison 3632 | for (j = 0; dptr = sim_devices[j]; j++) { | ^ | == HP2100/hp2100_cpu.c:3797:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 3797 | else | ^ HP2100/hp2100_cpu.c:3816:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 3816 | else | ^ HP2100/hp2100_cpu.c:3852:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 3852 | else if (option == UNIT_IOP) | ^ 7 warnings generated. HP2100/hp2100_sys.c:611:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 611 | if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_sys.c:611:15: note: place parentheses around the assignment to silence this warning 611 | if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ | ^ | ( ) HP2100/hp2100_sys.c:611:15: note: use '==' to turn this assignment into an equality comparison 611 | if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ | ^ | == HP2100/hp2100_sys.c:615:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 615 | else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_sys.c:615:20: note: place parentheses around the assignment to silence this warning 615 | else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ | ^ | ( ) HP2100/hp2100_sys.c:615:20: note: use '==' to turn this assignment into an equality comparison 615 | else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ | ^ | == 2 warnings generated. HP2100/hp2100_ipl.c:626:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 626 | if (t = ipl_check_conn (uptr)) /* established? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_ipl.c:626:15: note: place parentheses around the assignment to silence this warning 626 | if (t = ipl_check_conn (uptr)) /* established? */ | ^ | ( ) HP2100/hp2100_ipl.c:626:15: note: use '==' to turn this assignment into an equality comparison 626 | if (t = ipl_check_conn (uptr)) /* established? */ | ^ | == 1 warning generated. HP2100/hp2100_cpu0.c:133:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 133 | if (reason = cpu_ops (op_ds[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu0.c:133:16: note: place parentheses around the assignment to silence this warning 133 | if (reason = cpu_ops (op_ds[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu0.c:133:16: note: use '==' to turn this assignment into an equality comparison 133 | if (reason = cpu_ops (op_ds[entry], op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu0.c:194:57: warning: '/*' within block comment [-Wcomment] 194 | /* case 000: /* 105000-105017 */ | ^ HP2100/hp2100_cpu0.c:195:57: warning: '/*' within block comment [-Wcomment] 195 | /* return cpu_user_00 (IR, intrq); /* uncomment to handle instruction */ | ^ HP2100/hp2100_cpu0.c:197:57: warning: '/*' within block comment [-Wcomment] 197 | /* case 001: /* 105020-105037 */ | ^ HP2100/hp2100_cpu0.c:198:57: warning: '/*' within block comment [-Wcomment] 198 | /* return cpu_user_01 (IR, intrq); /* uncomment to handle instruction */ | ^ HP2100/hp2100_cpu0.c:200:57: warning: '/*' within block comment [-Wcomment] 200 | /* case 0nn: /* other cases as needed */ | ^ HP2100/hp2100_cpu0.c:201:57: warning: '/*' within block comment [-Wcomment] 201 | /* return cpu_user_nn (IR, intrq); /* uncomment to handle instruction */ | ^ HP2100/hp2100_cpu0.c:206:57: warning: '/*' within block comment [-Wcomment] 206 | /* case 021: /* 10x420-10x437 */ | ^ HP2100/hp2100_cpu0.c:207:57: warning: '/*' within block comment [-Wcomment] 207 | /* return cpu_user_21 (IR, intrq); /* uncomment to handle instruction */ | ^ HP2100/hp2100_cpu0.c:209:57: warning: '/*' within block comment [-Wcomment] 209 | /* case 0nn: /* other cases as needed */ | ^ HP2100/hp2100_cpu0.c:210:57: warning: '/*' within block comment [-Wcomment] 210 | /* return cpu_user_nn (IR, intrq); /* uncomment to handle instruction */ | ^ HP2100/hp2100_cpu0.c:247:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 247 | if (reason = cpu_ops (op_user_20 [entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu0.c:247:16: note: place parentheses around the assignment to silence this warning 247 | if (reason = cpu_ops (op_user_20 [entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu0.c:247:16: note: use '==' to turn this assignment into an equality comparison 247 | if (reason = cpu_ops (op_user_20 [entry], op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu0.c:253:57: warning: '/*' within block comment [-Wcomment] 253 | /* break; /* uncomment to handle instruction */ | ^ HP2100/hp2100_cpu0.c:256:57: warning: '/*' within block comment [-Wcomment] 256 | /* break; /* uncomment to handle instruction */ | ^ HP2100/hp2100_cpu0.c:258:57: warning: '/*' within block comment [-Wcomment] 258 | /* case 0nn: /* other cases as needed */ | ^ HP2100/hp2100_cpu0.c:259:57: warning: '/*' within block comment [-Wcomment] 259 | /* break; /* uncomment to handle instruction */ | ^ 16 warnings generated. HP2100/hp2100_cpu1.c:199:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 199 | else | ^ HP2100/hp2100_cpu1.c:248:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 248 | if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu1.c:248:24: note: place parentheses around the assignment to silence this warning 248 | if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ | ^ | ( ) HP2100/hp2100_cpu1.c:248:24: note: use '==' to turn this assignment into an equality comparison 248 | if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ | ^ | == HP2100/hp2100_cpu1.c:265:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 265 | if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu1.c:265:20: note: place parentheses around the assignment to silence this warning 265 | if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ | ^ | ( ) HP2100/hp2100_cpu1.c:265:20: note: use '==' to turn this assignment into an equality comparison 265 | if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ | ^ | == HP2100/hp2100_cpu1.c:267:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 267 | if (rs = qs = BR & SIGN) { /* save divd sign, neg? */ | ~~~^~~~~~~~~~~~~~~~ HP2100/hp2100_cpu1.c:267:16: note: place parentheses around the assignment to silence this warning 267 | if (rs = qs = BR & SIGN) { /* save divd sign, neg? */ | ^ | ( ) HP2100/hp2100_cpu1.c:267:16: note: use '==' to turn this assignment into an equality comparison 267 | if (rs = qs = BR & SIGN) { /* save divd sign, neg? */ | ^ | == HP2100/hp2100_cpu1.c:320:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 320 | if (reason = cpu_ops (OP_D, op, intrq)) /* get operand */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu1.c:320:20: note: place parentheses around the assignment to silence this warning 320 | if (reason = cpu_ops (OP_D, op, intrq)) /* get operand */ | ^ | ( ) HP2100/hp2100_cpu1.c:320:20: note: use '==' to turn this assignment into an equality comparison 320 | if (reason = cpu_ops (OP_D, op, intrq)) /* get operand */ | ^ | == HP2100/hp2100_cpu1.c:327:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 327 | if (reason = cpu_ops (OP_A, op, intrq)) /* get operand */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu1.c:327:20: note: place parentheses around the assignment to silence this warning 327 | if (reason = cpu_ops (OP_A, op, intrq)) /* get operand */ | ^ | ( ) HP2100/hp2100_cpu1.c:327:20: note: use '==' to turn this assignment into an equality comparison 327 | if (reason = cpu_ops (OP_A, op, intrq)) /* get operand */ | ^ | == HP2100/hp2100_cpu1.c:737:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 737 | if (reason = resolve (ReadW (PC), &MA, irq)) /* resolve indirects */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu1.c:737:20: note: place parentheses around the assignment to silence this warning 737 | if (reason = resolve (ReadW (PC), &MA, irq)) /* resolve indirects */ | ^ | ( ) HP2100/hp2100_cpu1.c:737:20: note: use '==' to turn this assignment into an equality comparison 737 | if (reason = resolve (ReadW (PC), &MA, irq)) /* resolve indirects */ | ^ | == 7 warnings generated. HP2100/hp2100_cpu2.c:247:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 247 | if (reason = cpu_ops (op_dms[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu2.c:247:16: note: place parentheses around the assignment to silence this warning 247 | if (reason = cpu_ops (op_dms[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu2.c:247:16: note: use '==' to turn this assignment into an equality comparison 247 | if (reason = cpu_ops (op_dms[entry], op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu2.c:613:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 613 | if (reason = cpu_ops (op_eig[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu2.c:613:16: note: place parentheses around the assignment to silence this warning 613 | if (reason = cpu_ops (op_eig[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu2.c:613:16: note: use '==' to turn this assignment into an equality comparison 613 | if (reason = cpu_ops (op_eig[entry], op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu2.c:992:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 992 | if (reason = cpu_ops (op_iop[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu2.c:992:16: note: place parentheses around the assignment to silence this warning 992 | if (reason = cpu_ops (op_iop[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu2.c:992:16: note: use '==' to turn this assignment into an equality comparison 992 | if (reason = cpu_ops (op_iop[entry], op, intrq)) /* get instruction operands */ | ^ | == 3 warnings generated. HP2100/hp2100_cpu3.c:189:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 189 | if (reason = cpu_ops (op_ffp_e[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu3.c:189:20: note: place parentheses around the assignment to silence this warning 189 | if (reason = cpu_ops (op_ffp_e[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu3.c:189:20: note: use '==' to turn this assignment into an equality comparison 189 | if (reason = cpu_ops (op_ffp_e[entry], op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu3.c:197:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 197 | if (reason = cpu_ops (op_ffp_f[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu3.c:197:20: note: place parentheses around the assignment to silence this warning 197 | if (reason = cpu_ops (op_ffp_f[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu3.c:197:20: note: use '==' to turn this assignment into an equality comparison 197 | if (reason = cpu_ops (op_ffp_f[entry], op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu3.c:420:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 420 | if (reason = resolve (da, &MA, intrq)) { /* resolve indirects */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu3.c:420:20: note: place parentheses around the assignment to silence this warning 420 | if (reason = resolve (da, &MA, intrq)) { /* resolve indirects */ | ^ | ( ) HP2100/hp2100_cpu3.c:420:20: note: use '==' to turn this assignment into an equality comparison 420 | if (reason = resolve (da, &MA, intrq)) { /* resolve indirects */ | ^ | == HP2100/hp2100_cpu3.c:438:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 438 | if (reason = cpu_ops (OP_KK, op2, intrq)) { /* get 1st, 2nd ranges */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu3.c:438:24: note: place parentheses around the assignment to silence this warning 438 | if (reason = cpu_ops (OP_KK, op2, intrq)) { /* get 1st, 2nd ranges */ | ^ | ( ) HP2100/hp2100_cpu3.c:438:24: note: use '==' to turn this assignment into an equality comparison 438 | if (reason = cpu_ops (OP_KK, op2, intrq)) { /* get 1st, 2nd ranges */ | ^ | == HP2100/hp2100_cpu3.c:464:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 464 | if (reason = resolve (MA, &MA, intrq)) { /* resolve indirect */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu3.c:464:24: note: place parentheses around the assignment to silence this warning 464 | if (reason = resolve (MA, &MA, intrq)) { /* resolve indirect */ | ^ | ( ) HP2100/hp2100_cpu3.c:464:24: note: use '==' to turn this assignment into an equality comparison 464 | if (reason = resolve (MA, &MA, intrq)) { /* resolve indirect */ | ^ | == HP2100/hp2100_cpu3.c:647:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 647 | if (reason = cpu_ops (op_dbi[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu3.c:647:16: note: place parentheses around the assignment to silence this warning 647 | if (reason = cpu_ops (op_dbi[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu3.c:647:16: note: use '==' to turn this assignment into an equality comparison 647 | if (reason = cpu_ops (op_dbi[entry], op, intrq)) /* get instruction operands */ | ^ | == 6 warnings generated. HP2100/hp2100_cpu4.c:264:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 264 | if (reason = cpu_ops (op_fpp[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu4.c:264:16: note: place parentheses around the assignment to silence this warning 264 | if (reason = cpu_ops (op_fpp[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu4.c:264:16: note: use '==' to turn this assignment into an equality comparison 264 | if (reason = cpu_ops (op_fpp[entry], op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu4.c:603:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 603 | if (reason = cpu_ops (op_sis[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu4.c:603:16: note: place parentheses around the assignment to silence this warning 603 | if (reason = cpu_ops (op_sis[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu4.c:603:16: note: use '==' to turn this assignment into an equality comparison 603 | if (reason = cpu_ops (op_sis[entry], op, intrq)) /* get instruction operands */ | ^ | == 2 warnings generated. HP2100/hp2100_cpu5.c:653:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 653 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu5.c:653:16: note: place parentheses around the assignment to silence this warning 653 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu5.c:653:16: note: use '==' to turn this assignment into an equality comparison 653 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu5.c:1364:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1364 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu5.c:1364:16: note: place parentheses around the assignment to silence this warning 1364 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu5.c:1364:16: note: use '==' to turn this assignment into an equality comparison 1364 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^ | == 2 warnings generated. HP2100/hp2100_cpu6.c:397:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 397 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu6.c:397:16: note: place parentheses around the assignment to silence this warning 397 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu6.c:397:16: note: use '==' to turn this assignment into an equality comparison 397 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu6.c:547:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 547 | if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu6.c:547:24: note: place parentheses around the assignment to silence this warning 547 | if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ | ^ | ( ) HP2100/hp2100_cpu6.c:547:24: note: use '==' to turn this assignment into an equality comparison 547 | if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ | ^ | == HP2100/hp2100_cpu6.c:713:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 713 | if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu6.c:713:28: note: place parentheses around the assignment to silence this warning 713 | if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ | ^ | ( ) HP2100/hp2100_cpu6.c:713:28: note: use '==' to turn this assignment into an equality comparison 713 | if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ | ^ | == 3 warnings generated. HP2100/hp2100_cpu7.c:394:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 394 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu7.c:394:16: note: place parentheses around the assignment to silence this warning 394 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu7.c:394:16: note: use '==' to turn this assignment into an equality comparison 394 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^ | == HP2100/hp2100_cpu7.c:656:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 656 | if (reason = cpu_ops (op_signal[entry], op, intrq)) /* get instruction operands */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu7.c:656:16: note: place parentheses around the assignment to silence this warning 656 | if (reason = cpu_ops (op_signal[entry], op, intrq)) /* get instruction operands */ | ^ | ( ) HP2100/hp2100_cpu7.c:656:16: note: use '==' to turn this assignment into an equality comparison 656 | if (reason = cpu_ops (op_signal[entry], op, intrq)) /* get instruction operands */ | ^ | == 2 warnings generated. HP2100/hp2100_fp1.c:1151:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1151 | else /* all others */ | ^ 1 warning generated. HP2100/hp2100_baci.c:683:29: warning: add explicit braces to avoid dangling else [-Wdangling-else] 683 | else { /* external rate */ | ^ HP2100/hp2100_baci.c:1388:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1388 | else | ^ HP2100/hp2100_baci.c:1453:9: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1453 | else /* receive? */ | ^ 3 warnings generated. HP2100/hp2100_mpx.c:1160:13: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1160 | else { | ^ HP2100/hp2100_mpx.c:1262:13: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1262 | else { /* buffer is empty */ | ^ HP2100/hp2100_mpx.c:1804:13: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1804 | else if (ch == DEL) { /* delete line? */ | ^ HP2100/hp2100_mpx.c:2480:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 2480 | else | ^ 4 warnings generated. HP2100/hp2100_pif.c:309:46: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] 309 | setIRQ (dibptr->select_code, !pif.control & pif.flag & pif.flagbuf); | ^ ~ HP2100/hp2100_defs.h:424:77: note: expanded from macro 'setIRQ' 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_pif.c:309:46: note: add parentheses after the '!' to evaluate the bitwise operator first HP2100/hp2100_pif.c:309:46: note: add parentheses around left hand side expression to silence this warning 1 warning generated. HP2100/hp2100_di.c:614:21: warning: add explicit braces to avoid dangling else [-Wdangling-else] 614 | else if (di_card->cntl_register & CNTL_LSTN) /* was card a listener but is not now? */ | ^ HP2100/hp2100_di.c:1460:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1460 | else /* otherwise the card is ready for data */ | ^ HP2100/hp2100_di.c:1867:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1867 | else { /* the card is in the unpacked mode */ | ^ 3 warnings generated. HP2100/hp2100_di_da.c:1745:17: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1745 | else { /* the parameter count is wrong */ | ^ HP2100/hp2100_di_da.c:1794:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1794 | else | ^ 2 warnings generated. HP2100/hp_disclib.c:1575:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1575 | else { /* we are unloading the heads */ | ^ HP2100/hp_disclib.c:2047:13: warning: add explicit braces to avoid dangling else [-Wdangling-else] 2047 | else /* it is a MAC controller */ | ^ HP2100/hp_disclib.c:2198:13: warning: taking the absolute value of unsigned type 'uint32' (aka 'unsigned int') has no effect [-Wabsolute-value] 2198 | delta = abs (uptr->CYL - target_cylinder); /* calculate the relative movement */ | ^ HP2100/hp_disclib.c:2198:13: note: remove the call to 'abs' since unsigned values cannot be negative 2198 | delta = abs (uptr->CYL - target_cylinder); /* calculate the relative movement */ | ^~~ HP2100/hp_disclib.c:2298:5: warning: add explicit braces to avoid dangling else [-Wdangling-else] 2298 | else /* we stop the timer */ | ^ 4 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: hp2100_cpu.c(/tmp/hp2100_cpu-2c6677.o:(iogrp)): warning: sprintf() is often misused, please use snprintf() ld: warning: hp2100_ipl.c(/tmp/hp2100_ipl-87360d.o:(ipl_attach)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: scp.c(/tmp/scp-0face7.o:(main)): warning: strcat() is almost always misused, please use strlcat() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so I1401/i1401_lp.c I1401/i1401_cpu.c I1401/i1401_iq.c I1401/i1401_cd.c I1401/i1401_mt.c I1401/i1401_dp.c I1401/i1401_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I I1401 -o BIN/i1401 -lm -lpthread -lpcap I1401/i1401_cpu.c:550:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 550 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:550:20: note: place parentheses around the assignment to silence this warning 550 | if (reason = sim_process_event ()) | ^ | ( ) I1401/i1401_cpu.c:550:20: note: use '==' to turn this assignment into an equality comparison 550 | if (reason = sim_process_event ()) | ^ | == I1401/i1401_cpu.c:1042:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1042 | if (reason = iomod (ilnt, D, r_mod)) /* valid modifier? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1042:20: note: place parentheses around the assignment to silence this warning 1042 | if (reason = iomod (ilnt, D, r_mod)) /* valid modifier? */ | ^ | ( ) I1401/i1401_cpu.c:1042:20: note: use '==' to turn this assignment into an equality comparison 1042 | if (reason = iomod (ilnt, D, r_mod)) /* valid modifier? */ | ^ | == I1401/i1401_cpu.c:1052:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1052 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1052:20: note: place parentheses around the assignment to silence this warning 1052 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^ | ( ) I1401/i1401_cpu.c:1052:20: note: use '==' to turn this assignment into an equality comparison 1052 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^ | == I1401/i1401_cpu.c:1062:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1062 | if (reason = iomod (ilnt, D, p_mod)) /* valid modifier? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1062:20: note: place parentheses around the assignment to silence this warning 1062 | if (reason = iomod (ilnt, D, p_mod)) /* valid modifier? */ | ^ | ( ) I1401/i1401_cpu.c:1062:20: note: use '==' to turn this assignment into an equality comparison 1062 | if (reason = iomod (ilnt, D, p_mod)) /* valid modifier? */ | ^ | == I1401/i1401_cpu.c:1072:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1072 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1072:20: note: place parentheses around the assignment to silence this warning 1072 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^ | ( ) I1401/i1401_cpu.c:1072:20: note: use '==' to turn this assignment into an equality comparison 1072 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^ | == I1401/i1401_cpu.c:1085:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1085 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1085:20: note: place parentheses around the assignment to silence this warning 1085 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^ | ( ) I1401/i1401_cpu.c:1085:20: note: use '==' to turn this assignment into an equality comparison 1085 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^ | == I1401/i1401_cpu.c:1098:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1098 | if (reason = iomod (ilnt, D, NULL)) /* valid modifier? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1098:20: note: place parentheses around the assignment to silence this warning 1098 | if (reason = iomod (ilnt, D, NULL)) /* valid modifier? */ | ^ | ( ) I1401/i1401_cpu.c:1098:20: note: use '==' to turn this assignment into an equality comparison 1098 | if (reason = iomod (ilnt, D, NULL)) /* valid modifier? */ | ^ | == I1401/i1401_cpu.c:1111:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1111:20: note: place parentheses around the assignment to silence this warning 1111 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^ | ( ) I1401/i1401_cpu.c:1111:20: note: use '==' to turn this assignment into an equality comparison 1111 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^ | == I1401/i1401_cpu.c:1125:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1125 | if (reason = iomod (ilnt, D, ss_mod)) /* valid modifier? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1125:20: note: place parentheses around the assignment to silence this warning 1125 | if (reason = iomod (ilnt, D, ss_mod)) /* valid modifier? */ | ^ | ( ) I1401/i1401_cpu.c:1125:20: note: use '==' to turn this assignment into an equality comparison 1125 | if (reason = iomod (ilnt, D, ss_mod)) /* valid modifier? */ | ^ | == I1401/i1401_cpu.c:1127:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1127 | if (reason = select_stack (D)) /* sel stack, error? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1127:20: note: place parentheses around the assignment to silence this warning 1127 | if (reason = select_stack (D)) /* sel stack, error? */ | ^ | ( ) I1401/i1401_cpu.c:1127:20: note: use '==' to turn this assignment into an equality comparison 1127 | if (reason = select_stack (D)) /* sel stack, error? */ | ^ | == I1401/i1401_cpu.c:1135:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1135 | if (reason = carriage_control (D)) /* car ctrl, error? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1135:20: note: place parentheses around the assignment to silence this warning 1135 | if (reason = carriage_control (D)) /* car ctrl, error? */ | ^ | ( ) I1401/i1401_cpu.c:1135:20: note: use '==' to turn this assignment into an equality comparison 1135 | if (reason = carriage_control (D)) /* car ctrl, error? */ | ^ | == I1401/i1401_cpu.c:1157:25: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1157 | else if (reason = iomod (ilnt, D, mtf_mod)) /* valid modifier? */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cpu.c:1157:25: note: place parentheses around the assignment to silence this warning 1157 | else if (reason = iomod (ilnt, D, mtf_mod)) /* valid modifier? */ | ^ | ( ) I1401/i1401_cpu.c:1157:25: note: use '==' to turn this assignment into an equality comparison 1157 | else if (reason = iomod (ilnt, D, mtf_mod)) /* valid modifier? */ | ^ | == 12 warnings generated. I1401/i1401_iq.c:97:1: warning: '/*' within block comment [-Wcomment] 97 | /* return SCPE_OK; /* return if no req */ | ^ I1401/i1401_iq.c:97:57: warning: '/*' within block comment [-Wcomment] 97 | /* return SCPE_OK; /* return if no req */ | ^ 2 warnings generated. I1401/i1401_cd.c:187:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 187 | if (r = cdr_svc (&cdr_unit)) /* process */ | ~~^~~~~~~~~~~~~~~~~~~~~ I1401/i1401_cd.c:187:11: note: place parentheses around the assignment to silence this warning 187 | if (r = cdr_svc (&cdr_unit)) /* process */ | ^ | ( ) I1401/i1401_cd.c:187:11: note: use '==' to turn this assignment into an equality comparison 187 | if (r = cdr_svc (&cdr_unit)) /* process */ | ^ | == 1 warning generated. I1401/i1401_mt.c:454:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 454 | if (uptr = mt_sel_unit (i)) { | ~~~~~^~~~~~~~~~~~~~~~~ I1401/i1401_mt.c:454:14: note: place parentheses around the assignment to silence this warning 454 | if (uptr = mt_sel_unit (i)) { | ^ | ( ) I1401/i1401_mt.c:454:14: note: use '==' to turn this assignment into an equality comparison 454 | if (uptr = mt_sel_unit (i)) { | ^ | == 1 warning generated. I1401/i1401_dp.c:272:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 272 | if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read sector */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_dp.c:272:19: note: place parentheses around the assignment to silence this warning 272 | if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read sector */ | ^ | ( ) I1401/i1401_dp.c:272:19: note: use '==' to turn this assignment into an equality comparison 272 | if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read sector */ | ^ | == I1401/i1401_dp.c:281:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 281 | if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_dp.c:281:19: note: place parentheses around the assignment to silence this warning 281 | if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ | ^ | ( ) I1401/i1401_dp.c:281:19: note: use '==' to turn this assignment into an equality comparison 281 | if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ | ^ | == I1401/i1401_dp.c:292:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 292 | if (r = dp_rdadr (uptr, psec, flg, qwc)) /* read addr */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_dp.c:292:19: note: place parentheses around the assignment to silence this warning 292 | if (r = dp_rdadr (uptr, psec, flg, qwc)) /* read addr */ | ^ | ( ) I1401/i1401_dp.c:292:19: note: use '==' to turn this assignment into an equality comparison 292 | if (r = dp_rdadr (uptr, psec, flg, qwc)) /* read addr */ | ^ | == I1401/i1401_dp.c:294:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 294 | if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read data */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_dp.c:294:19: note: place parentheses around the assignment to silence this warning 294 | if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read data */ | ^ | ( ) I1401/i1401_dp.c:294:19: note: use '==' to turn this assignment into an equality comparison 294 | if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read data */ | ^ | == I1401/i1401_dp.c:315:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 315 | if (r = dp_wrsec (uptr, psec, flg)) /* write data */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_dp.c:315:19: note: place parentheses around the assignment to silence this warning 315 | if (r = dp_wrsec (uptr, psec, flg)) /* write data */ | ^ | ( ) I1401/i1401_dp.c:315:19: note: use '==' to turn this assignment into an equality comparison 315 | if (r = dp_wrsec (uptr, psec, flg)) /* write data */ | ^ | == I1401/i1401_dp.c:321:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 321 | if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_dp.c:321:19: note: place parentheses around the assignment to silence this warning 321 | if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ | ^ | ( ) I1401/i1401_dp.c:321:19: note: use '==' to turn this assignment into an equality comparison 321 | if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ | ^ | == I1401/i1401_dp.c:334:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 334 | if (r = dp_wradr (uptr, psec, flg)) /* write addr */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_dp.c:334:19: note: place parentheses around the assignment to silence this warning 334 | if (r = dp_wradr (uptr, psec, flg)) /* write addr */ | ^ | ( ) I1401/i1401_dp.c:334:19: note: use '==' to turn this assignment into an equality comparison 334 | if (r = dp_wradr (uptr, psec, flg)) /* write addr */ | ^ | == I1401/i1401_dp.c:336:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 336 | if (r = dp_wrsec (uptr, psec, flg)) /* write data */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1401/i1401_dp.c:336:19: note: place parentheses around the assignment to silence this warning 336 | if (r = dp_wrsec (uptr, psec, flg)) /* write data */ | ^ | ( ) I1401/i1401_dp.c:336:19: note: use '==' to turn this assignment into an equality comparison 336 | if (r = dp_wrsec (uptr, psec, flg)) /* write data */ | ^ | == 8 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-542108.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-542108.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-639277.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so I1620/i1620_cd.c I1620/i1620_dp.c I1620/i1620_pt.c I1620/i1620_tty.c I1620/i1620_cpu.c I1620/i1620_lp.c I1620/i1620_fp.c I1620/i1620_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I I1620 -o BIN/i1620 -lm -lpthread -lpcap I1620/i1620_cd.c:113:1: warning: '/*' within block comment [-Wcomment] 113 | /* Card reader (ASCII) to numeric (one digit) */ | ^ 1 warning generated. I1620/i1620_dp.c:209:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 209 | if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read sector */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_dp.c:209:19: note: place parentheses around the assignment to silence this warning 209 | if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read sector */ | ^ | ( ) I1620/i1620_dp.c:209:19: note: use '==' to turn this assignment into an equality comparison 209 | if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read sector */ | ^ | == I1620/i1620_dp.c:219:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 219 | if (r = dp_rdadr (uptr, psec, qnr, qwc)) /* read addr */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_dp.c:219:19: note: place parentheses around the assignment to silence this warning 219 | if (r = dp_rdadr (uptr, psec, qnr, qwc)) /* read addr */ | ^ | ( ) I1620/i1620_dp.c:219:19: note: use '==' to turn this assignment into an equality comparison 219 | if (r = dp_rdadr (uptr, psec, qnr, qwc)) /* read addr */ | ^ | == I1620/i1620_dp.c:221:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 221 | if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read data */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_dp.c:221:19: note: place parentheses around the assignment to silence this warning 221 | if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read data */ | ^ | ( ) I1620/i1620_dp.c:221:19: note: use '==' to turn this assignment into an equality comparison 221 | if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read data */ | ^ | == I1620/i1620_dp.c:234:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 234 | if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_dp.c:234:19: note: place parentheses around the assignment to silence this warning 234 | if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ | ^ | ( ) I1620/i1620_dp.c:234:19: note: use '==' to turn this assignment into an equality comparison 234 | if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ | ^ | == I1620/i1620_dp.c:236:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 236 | if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_dp.c:236:19: note: place parentheses around the assignment to silence this warning 236 | if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ | ^ | ( ) I1620/i1620_dp.c:236:19: note: use '==' to turn this assignment into an equality comparison 236 | if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ | ^ | == I1620/i1620_dp.c:248:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 248 | if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_dp.c:248:19: note: place parentheses around the assignment to silence this warning 248 | if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ | ^ | ( ) I1620/i1620_dp.c:248:19: note: use '==' to turn this assignment into an equality comparison 248 | if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ | ^ | == I1620/i1620_dp.c:250:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 250 | if (r = dp_wradr (uptr, psec, qnr)) /* write addr */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_dp.c:250:19: note: place parentheses around the assignment to silence this warning 250 | if (r = dp_wradr (uptr, psec, qnr)) /* write addr */ | ^ | ( ) I1620/i1620_dp.c:250:19: note: use '==' to turn this assignment into an equality comparison 250 | if (r = dp_wradr (uptr, psec, qnr)) /* write addr */ | ^ | == I1620/i1620_dp.c:252:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 252 | if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_dp.c:252:19: note: place parentheses around the assignment to silence this warning 252 | if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ | ^ | ( ) I1620/i1620_dp.c:252:19: note: use '==' to turn this assignment into an equality comparison 252 | if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ | ^ | == 8 warnings generated. I1620/i1620_tty.c:263:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 263 | else if (cp = strchr (tti_to_num, raw)) /* legal? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_tty.c:263:17: note: place parentheses around the assignment to silence this warning 263 | else if (cp = strchr (tti_to_num, raw)) /* legal? */ | ^ | ( ) I1620/i1620_tty.c:263:17: note: use '==' to turn this assignment into an equality comparison 263 | else if (cp = strchr (tti_to_num, raw)) /* legal? */ | ^ | == 1 warning generated. I1620/i1620_cpu.c:479:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 479 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ I1620/i1620_cpu.c:479:20: note: place parentheses around the assignment to silence this warning 479 | if (reason = sim_process_event ()) | ^ | ( ) I1620/i1620_cpu.c:479:20: note: use '==' to turn this assignment into an equality comparison 479 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. I1620/i1620_sys.c:555:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 555 | while (t = *fptr++) { /* loop through */ | ~~^~~~~~~~~ I1620/i1620_sys.c:555:10: note: place parentheses around the assignment to silence this warning 555 | while (t = *fptr++) { /* loop through */ | ^ | ( ) I1620/i1620_sys.c:555:10: note: use '==' to turn this assignment into an equality comparison 555 | while (t = *fptr++) { /* loop through */ | ^ | == 1 warning generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-6611b2.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-6611b2.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-b8d5c3.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so S3/s3_cd.c S3/s3_cpu.c S3/s3_disk.c S3/s3_lp.c S3/s3_pkb.c S3/s3_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I S3 -o BIN/s3 -lm -lpthread -lpcap S3/s3_cd.c:283:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 283 | if (r = cdr_svc (&cdr_unit)) return r; /* process */ | ~~^~~~~~~~~~~~~~~~~~~~~ S3/s3_cd.c:283:11: note: place parentheses around the assignment to silence this warning 283 | if (r = cdr_svc (&cdr_unit)) return r; /* process */ | ^ | ( ) S3/s3_cd.c:283:11: note: use '==' to turn this assignment into an equality comparison 283 | if (r = cdr_svc (&cdr_unit)) return r; /* process */ | ^ | == 1 warning generated. S3/s3_cpu.c:530:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 530 | if (reason = sim_process_event ()) break; | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ S3/s3_cpu.c:530:16: note: place parentheses around the assignment to silence this warning 530 | if (reason = sim_process_event ()) break; | ^ | ( ) S3/s3_cpu.c:530:16: note: use '==' to turn this assignment into an equality comparison 530 | if (reason = sim_process_event ()) break; | ^ | == 1 warning generated. S3/s3_disk.c:301:43: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] 301 | if ((sect == 55) ) { /* HJS MODS */ | ~~~~~^~~~~ S3/s3_disk.c:301:43: note: remove extraneous parentheses around the comparison to silence this warning 301 | if ((sect == 55) ) { /* HJS MODS */ | ~ ^ ~ S3/s3_disk.c:301:43: note: use '=' to turn this equality comparison into an assignment 301 | if ((sect == 55) ) { /* HJS MODS */ | ^~ | = S3/s3_disk.c:352:43: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] 352 | if ((sect == 55) ) { /* HJS MODS */ | ~~~~~^~~~~ S3/s3_disk.c:352:43: note: remove extraneous parentheses around the comparison to silence this warning 352 | if ((sect == 55) ) { /* HJS MODS */ | ~ ^ ~ S3/s3_disk.c:352:43: note: use '=' to turn this equality comparison into an assignment 352 | if ((sect == 55) ) { /* HJS MODS */ | ^~ | = S3/s3_disk.c:395:43: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] 395 | if ((sect == 55) ) { /* HJS MODS */ | ~~~~~^~~~~ S3/s3_disk.c:395:43: note: remove extraneous parentheses around the comparison to silence this warning 395 | if ((sect == 55) ) { /* HJS MODS */ | ~ ^ ~ S3/s3_disk.c:395:43: note: use '=' to turn this equality comparison into an assignment 395 | if ((sect == 55) ) { /* HJS MODS */ | ^~ | = S3/s3_disk.c:437:43: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] 437 | if ((sect == 55) ) { | ~~~~~^~~~~ S3/s3_disk.c:437:43: note: remove extraneous parentheses around the comparison to silence this warning 437 | if ((sect == 55) ) { | ~ ^ ~ S3/s3_disk.c:437:43: note: use '=' to turn this equality comparison into an assignment 437 | if ((sect == 55) ) { | ^~ | = S3/s3_disk.c:489:35: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] 489 | if ((sect == 55) ) { /* HJS MODS */ | ~~~~~^~~~~ S3/s3_disk.c:489:35: note: remove extraneous parentheses around the comparison to silence this warning 489 | if ((sect == 55) ) { /* HJS MODS */ | ~ ^ ~ S3/s3_disk.c:489:35: note: use '=' to turn this equality comparison into an assignment 489 | if ((sect == 55) ) { /* HJS MODS */ | ^~ | = 5 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: s3_sys.c(/tmp/s3_sys-2c9479.o:(printf_sym)): warning: sprintf() is often misused, please use snprintf() ld: warning: s3_sys.c(/tmp/s3_sys-2c9479.o:(printf_sym)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: scp.c(/tmp/scp-766fe0.o:(main)): warning: strcat() is almost always misused, please use strlcat() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so ALTAIR/altair_sio.c ALTAIR/altair_cpu.c ALTAIR/altair_dsk.c ALTAIR/altair_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I ALTAIR -o BIN/altair -lm -lpthread -lpcap ALTAIR/altair_cpu.c:316:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 316 | if (reason = sim_process_event ()) break; | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ ALTAIR/altair_cpu.c:316:24: note: place parentheses around the assignment to silence this warning 316 | if (reason = sim_process_event ()) break; | ^ | ( ) ALTAIR/altair_cpu.c:316:24: note: use '==' to turn this assignment into an equality comparison 316 | if (reason = sim_process_event ()) break; | ^ | == 1 warning generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-b6f5a8.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-b6f5a8.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-a94c48.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so AltairZ80/altairz80_cpu.c AltairZ80/altairz80_cpu_nommu.c AltairZ80/altairz80_dsk.c AltairZ80/disasm.c AltairZ80/altairz80_sio.c AltairZ80/altairz80_sys.c AltairZ80/altairz80_hdsk.c AltairZ80/altairz80_net.c AltairZ80/flashwriter2.c AltairZ80/i86_decode.c AltairZ80/i86_ops.c AltairZ80/i86_prim_ops.c AltairZ80/i8272.c AltairZ80/insnsd.c AltairZ80/mfdc.c AltairZ80/n8vem.c AltairZ80/vfdhd.c AltairZ80/s100_disk1a.c AltairZ80/s100_disk2.c AltairZ80/s100_disk3.c AltairZ80/s100_fif.c AltairZ80/s100_mdriveh.c AltairZ80/s100_mdsad.c AltairZ80/s100_selchan.c AltairZ80/s100_ss1.c AltairZ80/s100_64fdc.c AltairZ80/s100_scp300f.c AltairZ80/sim_imd.c AltairZ80/wd179x.c AltairZ80/s100_hdc1001.c AltairZ80/s100_if3.c AltairZ80/s100_adcs6.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I AltairZ80 -D HAVE_VM_INIT -o BIN/altairz80 -lm -lpthread -lpcap AltairZ80/i86_decode.c:270:65: warning: operator '?:' has lower precedence than '|'; '|' will be evaluated first [-Wbitwise-conditional-parentheses] 270 | PCX_S = (reason == STOP_HALT) | (reason == STOP_OPCODE) ? PCX : getFullPC(); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ AltairZ80/i86_decode.c:270:65: note: place parentheses around the '|' expression to silence this warning 270 | PCX_S = (reason == STOP_HALT) | (reason == STOP_OPCODE) ? PCX : getFullPC(); | ^ | ( ) AltairZ80/i86_decode.c:270:65: note: place parentheses around the '?:' expression to evaluate it first 270 | PCX_S = (reason == STOP_HALT) | (reason == STOP_OPCODE) ? PCX : getFullPC(); | ^ | ( ) 1 warning generated. AltairZ80/i86_prim_ops.c:1491:9: warning: taking the absolute value of unsigned type 'uint32' (aka 'unsigned int') has no effect [-Wabsolute-value] 1491 | if (abs(div) > 0xff) | ^ AltairZ80/i86_prim_ops.c:1491:9: note: remove the call to 'abs' since unsigned values cannot be negative 1491 | if (abs(div) > 0xff) | ^~~ AltairZ80/i86_prim_ops.c:1517:9: warning: taking the absolute value of unsigned type 'uint32' (aka 'unsigned int') has no effect [-Wabsolute-value] 1517 | if (abs(div) > 0xffff) | ^ AltairZ80/i86_prim_ops.c:1517:9: note: remove the call to 'abs' since unsigned values cannot be negative 1517 | if (abs(div) > 0xffff) | ^~~ 2 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: sim_tmxr.c(/tmp/sim_tmxr-4e1ef7.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-4e1ef7.o:(tmxr_attach)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: scp.c(/tmp/scp-6200b6.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: disasm.c(/tmp/disasm-357dd3.o:(disasm)): warning: stpcpy() is dangerous; do not use it cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so GRI/gri_cpu.c GRI/gri_stddev.c GRI/gri_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I GRI -o BIN/gri -lm -lpthread -lpcap GRI/gri_cpu.c:424:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 424 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ GRI/gri_cpu.c:424:20: note: place parentheses around the assignment to silence this warning 424 | if (reason = sim_process_event ()) | ^ | ( ) GRI/gri_cpu.c:424:20: note: use '==' to turn this assignment into an equality comparison 424 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-8baaf6.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-8baaf6.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_ether.c(/tmp/sim_ether-0e80da.o:(eth_mac_fmt)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so I7094/i7094_cpu.c I7094/i7094_cpu1.c I7094/i7094_io.c I7094/i7094_cd.c I7094/i7094_clk.c I7094/i7094_com.c I7094/i7094_drm.c I7094/i7094_dsk.c I7094/i7094_sys.c I7094/i7094_lp.c I7094/i7094_mt.c I7094/i7094_binloader.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DUSE_INT64 -I I7094 -o BIN/i7094 -lm -lpthread -lpcap I7094/i7094_cpu.c:667:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 667 | if (reason = sim_process_event ()) /* process events */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_cpu.c:667:20: note: place parentheses around the assignment to silence this warning 667 | if (reason = sim_process_event ()) /* process events */ | ^ | ( ) I7094/i7094_cpu.c:667:20: note: use '==' to turn this assignment into an equality comparison 667 | if (reason = sim_process_event ()) /* process events */ | ^ | == I7094/i7094_cpu.c:674:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 674 | if (reason = ch_proc (i)) | ~~~~~~~^~~~~~~~~~~~~ I7094/i7094_cpu.c:674:24: note: place parentheses around the assignment to silence this warning 674 | if (reason = ch_proc (i)) | ^ | ( ) I7094/i7094_cpu.c:674:24: note: use '==' to turn this assignment into an equality comparison 674 | if (reason = ch_proc (i)) | ^ | == I7094/i7094_cpu.c:1976:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1976 | if (r = sim_process_event ()) /* process events */ | ~~^~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_cpu.c:1976:23: note: place parentheses around the assignment to silence this warning 1976 | if (r = sim_process_event ()) /* process events */ | ^ | ( ) I7094/i7094_cpu.c:1976:23: note: use '==' to turn this assignment into an equality comparison 1976 | if (r = sim_process_event ()) /* process events */ | ^ | == I7094/i7094_cpu.c:1982:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1982 | if (r = ch_proc (j)) | ~~^~~~~~~~~~~~~ I7094/i7094_cpu.c:1982:35: note: place parentheses around the assignment to silence this warning 1982 | if (r = ch_proc (j)) | ^ | ( ) I7094/i7094_cpu.c:1982:35: note: use '==' to turn this assignment into an equality comparison 1982 | if (r = ch_proc (j)) | ^ | == I7094/i7094_cpu.c:2441:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 2441 | else if (ch = HIST_CH (pc)) { /* channel? */ | ~~~^~~~~~~~~~~~~~ I7094/i7094_cpu.c:2441:13: note: place parentheses around the assignment to silence this warning 2441 | else if (ch = HIST_CH (pc)) { /* channel? */ | ^ | ( ) I7094/i7094_cpu.c:2441:13: note: use '==' to turn this assignment into an equality comparison 2441 | else if (ch = HIST_CH (pc)) { /* channel? */ | ^ | == 5 warnings generated. I7094/i7094_io.c:798:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 798 | if (r = ch9_wr (ch, ir, 0)) /* write to dev */ | ~~^~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:798:19: note: place parentheses around the assignment to silence this warning 798 | if (r = ch9_wr (ch, ir, 0)) /* write to dev */ | ^ | ( ) I7094/i7094_io.c:798:19: note: use '==' to turn this assignment into an equality comparison 798 | if (r = ch9_wr (ch, ir, 0)) /* write to dev */ | ^ | == I7094/i7094_io.c:1006:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1006 | if (r = ch9_sel (ch, CHSL_SNS)) /* send sense to dev */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1006:15: note: place parentheses around the assignment to silence this warning 1006 | if (r = ch9_sel (ch, CHSL_SNS)) /* send sense to dev */ | ^ | ( ) I7094/i7094_io.c:1006:15: note: use '==' to turn this assignment into an equality comparison 1006 | if (r = ch9_sel (ch, CHSL_SNS)) /* send sense to dev */ | ^ | == I7094/i7094_io.c:1022:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1022 | if (r = ch9_sel (ch, CHSL_RDS)) /* send read sel */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1022:19: note: place parentheses around the assignment to silence this warning 1022 | if (r = ch9_sel (ch, CHSL_RDS)) /* send read sel */ | ^ | ( ) I7094/i7094_io.c:1022:19: note: use '==' to turn this assignment into an equality comparison 1022 | if (r = ch9_sel (ch, CHSL_RDS)) /* send read sel */ | ^ | == I7094/i7094_io.c:1028:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1028 | if (r = ch9_sel (ch, CHSL_WRS)) /* end write sel */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1028:19: note: place parentheses around the assignment to silence this warning 1028 | if (r = ch9_sel (ch, CHSL_WRS)) /* end write sel */ | ^ | ( ) I7094/i7094_io.c:1028:19: note: use '==' to turn this assignment into an equality comparison 1028 | if (r = ch9_sel (ch, CHSL_WRS)) /* end write sel */ | ^ | == I7094/i7094_io.c:1038:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1038 | if (r = ch9_wr (ch, 0, CH9DF_STOP)) /* send stop */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1038:23: note: place parentheses around the assignment to silence this warning 1038 | if (r = ch9_wr (ch, 0, CH9DF_STOP)) /* send stop */ | ^ | ( ) I7094/i7094_io.c:1038:23: note: use '==' to turn this assignment into an equality comparison 1038 | if (r = ch9_wr (ch, 0, CH9DF_STOP)) /* send stop */ | ^ | == I7094/i7094_io.c:1058:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1058 | else if (r = ch9_wr_getw (ch)) /* no, write */ | ~~^~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1058:20: note: place parentheses around the assignment to silence this warning 1058 | else if (r = ch9_wr_getw (ch)) /* no, write */ | ^ | ( ) I7094/i7094_io.c:1058:20: note: use '==' to turn this assignment into an equality comparison 1058 | else if (r = ch9_wr_getw (ch)) /* no, write */ | ^ | == I7094/i7094_io.c:1167:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1167 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1167:19: note: place parentheses around the assignment to silence this warning 1167 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ^ | ( ) I7094/i7094_io.c:1167:19: note: use '==' to turn this assignment into an equality comparison 1167 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ^ | == I7094/i7094_io.c:1177:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1177 | if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1177:19: note: place parentheses around the assignment to silence this warning 1177 | if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ | ^ | ( ) I7094/i7094_io.c:1177:19: note: use '==' to turn this assignment into an equality comparison 1177 | if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ | ^ | == I7094/i7094_io.c:1187:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1187 | if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1187:19: note: place parentheses around the assignment to silence this warning 1187 | if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ | ^ | ( ) I7094/i7094_io.c:1187:19: note: use '==' to turn this assignment into an equality comparison 1187 | if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ | ^ | == I7094/i7094_io.c:1196:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1196 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1196:19: note: place parentheses around the assignment to silence this warning 1196 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ^ | ( ) I7094/i7094_io.c:1196:19: note: use '==' to turn this assignment into an equality comparison 1196 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ^ | == I7094/i7094_io.c:1206:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1206 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_io.c:1206:19: note: place parentheses around the assignment to silence this warning 1206 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ^ | ( ) I7094/i7094_io.c:1206:19: note: use '==' to turn this assignment into an equality comparison 1206 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ^ | == 11 warnings generated. I7094/i7094_com.c:1178:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1178 | if (entc = com_show_qsumm (st, lh, name)) { | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_com.c:1178:10: note: place parentheses around the assignment to silence this warning 1178 | if (entc = com_show_qsumm (st, lh, name)) { | ^ | ( ) I7094/i7094_com.c:1178:10: note: use '==' to turn this assignment into an equality comparison 1178 | if (entc = com_show_qsumm (st, lh, name)) { | ^ | == 1 warning generated. I7094/i7094_dsk.c:696:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 696 | if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_dsk.c:696:15: note: place parentheses around the assignment to silence this warning 696 | if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ | ^ | ( ) I7094/i7094_dsk.c:696:15: note: use '==' to turn this assignment into an equality comparison 696 | if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ | ^ | == I7094/i7094_dsk.c:703:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 703 | if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_dsk.c:703:15: note: place parentheses around the assignment to silence this warning 703 | if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ | ^ | ( ) I7094/i7094_dsk.c:703:15: note: use '==' to turn this assignment into an equality comparison 703 | if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ | ^ | == I7094/i7094_dsk.c:724:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 724 | if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_dsk.c:724:15: note: place parentheses around the assignment to silence this warning 724 | if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ | ^ | ( ) I7094/i7094_dsk.c:724:15: note: use '==' to turn this assignment into an equality comparison 724 | if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ | ^ | == I7094/i7094_dsk.c:745:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 745 | if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_dsk.c:745:15: note: place parentheses around the assignment to silence this warning 745 | if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ | ^ | ( ) I7094/i7094_dsk.c:745:15: note: use '==' to turn this assignment into an equality comparison 745 | if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ | ^ | == I7094/i7094_dsk.c:758:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 758 | if (r = dsk_wr_trk (udptr, trk)) /* write track; err? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_dsk.c:758:19: note: place parentheses around the assignment to silence this warning 758 | if (r = dsk_wr_trk (udptr, trk)) /* write track; err? */ | ^ | ( ) I7094/i7094_dsk.c:758:19: note: use '==' to turn this assignment into an equality comparison 758 | if (r = dsk_wr_trk (udptr, trk)) /* write track; err? */ | ^ | == I7094/i7094_dsk.c:849:27: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 849 | if (r = dsk_wr_trk (udptr, trk + i)) /* wr track; err? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_dsk.c:849:27: note: place parentheses around the assignment to silence this warning 849 | if (r = dsk_wr_trk (udptr, trk + i)) /* wr track; err? */ | ^ | ( ) I7094/i7094_dsk.c:849:27: note: use '==' to turn this assignment into an equality comparison 849 | if (r = dsk_wr_trk (udptr, trk + i)) /* wr track; err? */ | ^ | == 6 warnings generated. I7094/i7094_mt.c:567:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 567 | if (r = mt_map_err (uptr, r)) /* map status */ | ~~^~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_mt.c:567:19: note: place parentheses around the assignment to silence this warning 567 | if (r = mt_map_err (uptr, r)) /* map status */ | ^ | ( ) I7094/i7094_mt.c:567:19: note: use '==' to turn this assignment into an equality comparison 567 | if (r = mt_map_err (uptr, r)) /* map status */ | ^ | == I7094/i7094_mt.c:739:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 739 | if (r = mt_map_err (uptr, r)) /* map error */ | ~~^~~~~~~~~~~~~~~~~~~~~~ I7094/i7094_mt.c:739:11: note: place parentheses around the assignment to silence this warning 739 | if (r = mt_map_err (uptr, r)) /* map error */ | ^ | ( ) I7094/i7094_mt.c:739:11: note: use '==' to turn this assignment into an equality comparison 739 | if (r = mt_map_err (uptr, r)) /* map error */ | ^ | == 2 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: i7094_com.c(/tmp/i7094_com-5b126a.o:(com_show_oneq)): warning: sprintf() is often misused, please use snprintf() ld: warning: scp.c(/tmp/scp-e76277.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-e76277.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so Ibm1130/ibm1130_cpu.c Ibm1130/ibm1130_cr.c Ibm1130/ibm1130_disk.c Ibm1130/ibm1130_stddev.c Ibm1130/ibm1130_sys.c Ibm1130/ibm1130_gdu.c Ibm1130/ibm1130_gui.c Ibm1130/ibm1130_prt.c Ibm1130/ibm1130_fmt.c Ibm1130/ibm1130_ptrp.c Ibm1130/ibm1130_plot.c Ibm1130/ibm1130_sca.c Ibm1130/ibm1130_t2741.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I Ibm1130 -D HAVE_VM_INIT -o BIN/ibm1130 -lm -lpthread -lpcap In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: ibm1130_cpu.c(/tmp/ibm1130_cpu-d1b5e6.o:(cpu_attach)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: ibm1130_cpu.c(/tmp/ibm1130_cpu-d1b5e6.o:(sim_instr)): warning: sprintf() is often misused, please use snprintf() ld: warning: scp.c(/tmp/scp-10ccc2.o:(main)): warning: strcat() is almost always misused, please use strlcat() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so Interdata/id16_cpu.c Interdata/id16_sys.c Interdata/id_dp.c Interdata/id_fd.c Interdata/id_fp.c Interdata/id_idc.c Interdata/id_io.c Interdata/id_lp.c Interdata/id_mt.c Interdata/id_pas.c Interdata/id_pt.c Interdata/id_tt.c Interdata/id_uvc.c Interdata/id16_dboot.c Interdata/id_ttp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I Interdata -o BIN/id16 -lm -lpthread -lpcap Interdata/id16_cpu.c:607:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 607 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ Interdata/id16_cpu.c:607:20: note: place parentheses around the assignment to silence this warning 607 | if (reason = sim_process_event ()) | ^ | ( ) Interdata/id16_cpu.c:607:20: note: use '==' to turn this assignment into an equality comparison 607 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. Interdata/id_dp.c:422:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 422 | if (r = dp_rds (uptr)) /* read sec, err? */ | ~~^~~~~~~~~~~~~~~ Interdata/id_dp.c:422:19: note: place parentheses around the assignment to silence this warning 422 | if (r = dp_rds (uptr)) /* read sec, err? */ | ^ | ( ) Interdata/id_dp.c:422:19: note: use '==' to turn this assignment into an equality comparison 422 | if (r = dp_rds (uptr)) /* read sec, err? */ | ^ | == Interdata/id_dp.c:441:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 441 | if (r = dp_wds (uptr)) /* write sec, err? */ | ~~^~~~~~~~~~~~~~~ Interdata/id_dp.c:441:19: note: place parentheses around the assignment to silence this warning 441 | if (r = dp_wds (uptr)) /* write sec, err? */ | ^ | ( ) Interdata/id_dp.c:441:19: note: use '==' to turn this assignment into an equality comparison 441 | if (r = dp_wds (uptr)) /* write sec, err? */ | ^ | == 2 warnings generated. Interdata/id_idc.c:99:57: warning: '/*' within block comment [-Wcomment] 99 | /* 0x40 /* unused */ | ^ Interdata/id_idc.c:579:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 579 | if (r = idc_rds (uptr)) /* read sec, err? */ | ~~^~~~~~~~~~~~~~~~ Interdata/id_idc.c:579:19: note: place parentheses around the assignment to silence this warning 579 | if (r = idc_rds (uptr)) /* read sec, err? */ | ^ | ( ) Interdata/id_idc.c:579:19: note: use '==' to turn this assignment into an equality comparison 579 | if (r = idc_rds (uptr)) /* read sec, err? */ | ^ | == Interdata/id_idc.c:598:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 598 | if (r = idc_wds (uptr)) /* write sec, err? */ | ~~^~~~~~~~~~~~~~~~ Interdata/id_idc.c:598:19: note: place parentheses around the assignment to silence this warning 598 | if (r = idc_wds (uptr)) /* write sec, err? */ | ^ | ( ) Interdata/id_idc.c:598:19: note: use '==' to turn this assignment into an equality comparison 598 | if (r = idc_wds (uptr)) /* write sec, err? */ | ^ | == 3 warnings generated. Interdata/id_io.c:361:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 361 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ | ~~~~~^~~~~~~~~~~~~~~~ Interdata/id_io.c:361:22: note: place parentheses around the assignment to silence this warning 361 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ | ^ | ( ) Interdata/id_io.c:361:22: note: use '==' to turn this assignment into an equality comparison 361 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ | ^ | == Interdata/id_io.c:442:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 442 | if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_io.c:442:11: note: place parentheses around the assignment to silence this warning 442 | if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ | ^ | ( ) Interdata/id_io.c:442:11: note: use '==' to turn this assignment into an equality comparison 442 | if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ | ^ | == Interdata/id_io.c:633:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 633 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ~~~~~^~~~~~~~~~~~~~~~ Interdata/id_io.c:633:18: note: place parentheses around the assignment to silence this warning 633 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^ | ( ) Interdata/id_io.c:633:18: note: use '==' to turn this assignment into an equality comparison 633 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^ | == 3 warnings generated. Interdata/id_mt.c:371:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 371 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_mt.c:371:20: note: place parentheses around the assignment to silence this warning 371 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ | ^ | ( ) Interdata/id_mt.c:371:20: note: use '==' to turn this assignment into an equality comparison 371 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ | ^ | == Interdata/id_mt.c:377:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 377 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_mt.c:377:16: note: place parentheses around the assignment to silence this warning 377 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) Interdata/id_mt.c:377:16: note: use '==' to turn this assignment into an equality comparison 377 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == Interdata/id_mt.c:405:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 405 | if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_mt.c:405:16: note: place parentheses around the assignment to silence this warning 405 | if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ | ^ | ( ) Interdata/id_mt.c:405:16: note: use '==' to turn this assignment into an equality comparison 405 | if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ | ^ | == 3 warnings generated. Interdata/id_pas.c:337:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 337 | if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_pas.c:337:15: note: place parentheses around the assignment to silence this warning 337 | if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ | ^ | ( ) Interdata/id_pas.c:337:15: note: use '==' to turn this assignment into an equality comparison 337 | if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ | ^ | == 1 warning generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-7c6a79.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-7c6a79.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-e93df9.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so Interdata/id32_cpu.c Interdata/id32_sys.c Interdata/id_dp.c Interdata/id_fd.c Interdata/id_fp.c Interdata/id_idc.c Interdata/id_io.c Interdata/id_lp.c Interdata/id_mt.c Interdata/id_pas.c Interdata/id_pt.c Interdata/id_tt.c Interdata/id_uvc.c Interdata/id32_dboot.c Interdata/id_ttp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I Interdata -o BIN/id32 -lm -lpthread -lpcap Interdata/id32_cpu.c:667:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 667 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ Interdata/id32_cpu.c:667:20: note: place parentheses around the assignment to silence this warning 667 | if (reason = sim_process_event ()) | ^ | ( ) Interdata/id32_cpu.c:667:20: note: use '==' to turn this assignment into an equality comparison 667 | if (reason = sim_process_event ()) | ^ | == 1 warning generated. Interdata/id_dp.c:422:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 422 | if (r = dp_rds (uptr)) /* read sec, err? */ | ~~^~~~~~~~~~~~~~~ Interdata/id_dp.c:422:19: note: place parentheses around the assignment to silence this warning 422 | if (r = dp_rds (uptr)) /* read sec, err? */ | ^ | ( ) Interdata/id_dp.c:422:19: note: use '==' to turn this assignment into an equality comparison 422 | if (r = dp_rds (uptr)) /* read sec, err? */ | ^ | == Interdata/id_dp.c:441:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 441 | if (r = dp_wds (uptr)) /* write sec, err? */ | ~~^~~~~~~~~~~~~~~ Interdata/id_dp.c:441:19: note: place parentheses around the assignment to silence this warning 441 | if (r = dp_wds (uptr)) /* write sec, err? */ | ^ | ( ) Interdata/id_dp.c:441:19: note: use '==' to turn this assignment into an equality comparison 441 | if (r = dp_wds (uptr)) /* write sec, err? */ | ^ | == 2 warnings generated. Interdata/id_idc.c:99:57: warning: '/*' within block comment [-Wcomment] 99 | /* 0x40 /* unused */ | ^ Interdata/id_idc.c:579:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 579 | if (r = idc_rds (uptr)) /* read sec, err? */ | ~~^~~~~~~~~~~~~~~~ Interdata/id_idc.c:579:19: note: place parentheses around the assignment to silence this warning 579 | if (r = idc_rds (uptr)) /* read sec, err? */ | ^ | ( ) Interdata/id_idc.c:579:19: note: use '==' to turn this assignment into an equality comparison 579 | if (r = idc_rds (uptr)) /* read sec, err? */ | ^ | == Interdata/id_idc.c:598:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 598 | if (r = idc_wds (uptr)) /* write sec, err? */ | ~~^~~~~~~~~~~~~~~~ Interdata/id_idc.c:598:19: note: place parentheses around the assignment to silence this warning 598 | if (r = idc_wds (uptr)) /* write sec, err? */ | ^ | ( ) Interdata/id_idc.c:598:19: note: use '==' to turn this assignment into an equality comparison 598 | if (r = idc_wds (uptr)) /* write sec, err? */ | ^ | == 3 warnings generated. Interdata/id_io.c:361:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 361 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ | ~~~~~^~~~~~~~~~~~~~~~ Interdata/id_io.c:361:22: note: place parentheses around the assignment to silence this warning 361 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ | ^ | ( ) Interdata/id_io.c:361:22: note: use '==' to turn this assignment into an equality comparison 361 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ | ^ | == Interdata/id_io.c:442:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 442 | if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_io.c:442:11: note: place parentheses around the assignment to silence this warning 442 | if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ | ^ | ( ) Interdata/id_io.c:442:11: note: use '==' to turn this assignment into an equality comparison 442 | if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ | ^ | == Interdata/id_io.c:633:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 633 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ~~~~~^~~~~~~~~~~~~~~~ Interdata/id_io.c:633:18: note: place parentheses around the assignment to silence this warning 633 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^ | ( ) Interdata/id_io.c:633:18: note: use '==' to turn this assignment into an equality comparison 633 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^ | == 3 warnings generated. Interdata/id_mt.c:371:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 371 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_mt.c:371:20: note: place parentheses around the assignment to silence this warning 371 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ | ^ | ( ) Interdata/id_mt.c:371:20: note: use '==' to turn this assignment into an equality comparison 371 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ | ^ | == Interdata/id_mt.c:377:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 377 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_mt.c:377:16: note: place parentheses around the assignment to silence this warning 377 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) Interdata/id_mt.c:377:16: note: use '==' to turn this assignment into an equality comparison 377 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == Interdata/id_mt.c:405:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 405 | if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_mt.c:405:16: note: place parentheses around the assignment to silence this warning 405 | if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ | ^ | ( ) Interdata/id_mt.c:405:16: note: use '==' to turn this assignment into an equality comparison 405 | if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ | ^ | == 3 warnings generated. Interdata/id_pas.c:337:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 337 | if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Interdata/id_pas.c:337:15: note: place parentheses around the assignment to silence this warning 337 | if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ | ^ | ( ) Interdata/id_pas.c:337:15: note: use '==' to turn this assignment into an equality comparison 337 | if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ | ^ | == 1 warning generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: sim_ether.c(/tmp/sim_ether-e88f77.o:(eth_mac_fmt)): warning: sprintf() is often misused, please use snprintf() ld: warning: sim_ether.c(/tmp/sim_ether-e88f77.o:(eth_getname)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: scp.c(/tmp/scp-dea2f6.o:(main)): warning: strcat() is almost always misused, please use strlcat() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so SDS/sds_cpu.c SDS/sds_drm.c SDS/sds_dsk.c SDS/sds_io.c SDS/sds_lp.c SDS/sds_mt.c SDS/sds_mux.c SDS/sds_rad.c SDS/sds_stddev.c SDS/sds_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I SDS -o BIN/sds -lm -lpthread -lpcap SDS/sds_cpu.c:388:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 388 | if (reason = sim_process_event ()) /* process */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:388:20: note: place parentheses around the assignment to silence this warning 388 | if (reason = sim_process_event ()) /* process */ | ^ | ( ) SDS/sds_cpu.c:388:20: note: use '==' to turn this assignment into an equality comparison 388 | if (reason = sim_process_event ()) /* process */ | ^ | == SDS/sds_cpu.c:395:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 395 | if (reason = chan_process ()) /* process */ | ~~~~~~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:395:20: note: place parentheses around the assignment to silence this warning 395 | if (reason = chan_process ()) /* process */ | ^ | ( ) SDS/sds_cpu.c:395:20: note: use '==' to turn this assignment into an equality comparison 395 | if (reason = chan_process ()) /* process */ | ^ | == SDS/sds_cpu.c:509:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 509 | if (r = Write (0, dat)) | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:509:19: note: place parentheses around the assignment to silence this warning 509 | if (r = Write (0, dat)) | ^ | ( ) SDS/sds_cpu.c:509:19: note: use '==' to turn this assignment into an equality comparison 509 | if (r = Write (0, dat)) | ^ | == SDS/sds_cpu.c:528:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 528 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:528:15: note: place parentheses around the assignment to silence this warning 528 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:528:15: note: use '==' to turn this assignment into an equality comparison 528 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:530:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 530 | if (r = Read (va, &A)) /* get operand */ | ~~^~~~~~~~~~~~~~~ SDS/sds_cpu.c:530:15: note: place parentheses around the assignment to silence this warning 530 | if (r = Read (va, &A)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:530:15: note: use '==' to turn this assignment into an equality comparison 530 | if (r = Read (va, &A)) /* get operand */ | ^ | == SDS/sds_cpu.c:535:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 535 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:535:15: note: place parentheses around the assignment to silence this warning 535 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:535:15: note: use '==' to turn this assignment into an equality comparison 535 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:537:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 537 | if (r = Read (va, &B)) /* get operand */ | ~~^~~~~~~~~~~~~~~ SDS/sds_cpu.c:537:15: note: place parentheses around the assignment to silence this warning 537 | if (r = Read (va, &B)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:537:15: note: use '==' to turn this assignment into an equality comparison 537 | if (r = Read (va, &B)) /* get operand */ | ^ | == SDS/sds_cpu.c:542:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 542 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:542:15: note: place parentheses around the assignment to silence this warning 542 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:542:15: note: use '==' to turn this assignment into an equality comparison 542 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:544:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 544 | if (r = Read (va, &X)) /* get operand */ | ~~^~~~~~~~~~~~~~~ SDS/sds_cpu.c:544:15: note: place parentheses around the assignment to silence this warning 544 | if (r = Read (va, &X)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:544:15: note: use '==' to turn this assignment into an equality comparison 544 | if (r = Read (va, &X)) /* get operand */ | ^ | == SDS/sds_cpu.c:549:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 549 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:549:15: note: place parentheses around the assignment to silence this warning 549 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:549:15: note: use '==' to turn this assignment into an equality comparison 549 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:551:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 551 | if (r = Write (va, A)) /* write operand */ | ~~^~~~~~~~~~~~~~~ SDS/sds_cpu.c:551:15: note: place parentheses around the assignment to silence this warning 551 | if (r = Write (va, A)) /* write operand */ | ^ | ( ) SDS/sds_cpu.c:551:15: note: use '==' to turn this assignment into an equality comparison 551 | if (r = Write (va, A)) /* write operand */ | ^ | == SDS/sds_cpu.c:556:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 556 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:556:15: note: place parentheses around the assignment to silence this warning 556 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:556:15: note: use '==' to turn this assignment into an equality comparison 556 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:558:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 558 | if (r = Write (va, B)) /* write operand */ | ~~^~~~~~~~~~~~~~~ SDS/sds_cpu.c:558:15: note: place parentheses around the assignment to silence this warning 558 | if (r = Write (va, B)) /* write operand */ | ^ | ( ) SDS/sds_cpu.c:558:15: note: use '==' to turn this assignment into an equality comparison 558 | if (r = Write (va, B)) /* write operand */ | ^ | == SDS/sds_cpu.c:563:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 563 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:563:15: note: place parentheses around the assignment to silence this warning 563 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:563:15: note: use '==' to turn this assignment into an equality comparison 563 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:565:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 565 | if (r = Write (va, X)) /* write operand */ | ~~^~~~~~~~~~~~~~~ SDS/sds_cpu.c:565:15: note: place parentheses around the assignment to silence this warning 565 | if (r = Write (va, X)) /* write operand */ | ^ | ( ) SDS/sds_cpu.c:565:15: note: use '==' to turn this assignment into an equality comparison 565 | if (r = Write (va, X)) /* write operand */ | ^ | == SDS/sds_cpu.c:570:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 570 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:570:15: note: place parentheses around the assignment to silence this warning 570 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:570:15: note: use '==' to turn this assignment into an equality comparison 570 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:578:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 578 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:578:15: note: place parentheses around the assignment to silence this warning 578 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:578:15: note: use '==' to turn this assignment into an equality comparison 578 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:580:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 580 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:580:15: note: place parentheses around the assignment to silence this warning 580 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:580:15: note: use '==' to turn this assignment into an equality comparison 580 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:582:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 582 | if (r = Write (va, A)) /* write A */ | ~~^~~~~~~~~~~~~~~ SDS/sds_cpu.c:582:15: note: place parentheses around the assignment to silence this warning 582 | if (r = Write (va, A)) /* write A */ | ^ | ( ) SDS/sds_cpu.c:582:15: note: use '==' to turn this assignment into an equality comparison 582 | if (r = Write (va, A)) /* write A */ | ^ | == SDS/sds_cpu.c:590:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 590 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:590:15: note: place parentheses around the assignment to silence this warning 590 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:590:15: note: use '==' to turn this assignment into an equality comparison 590 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:592:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 592 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:592:15: note: place parentheses around the assignment to silence this warning 592 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:592:15: note: use '==' to turn this assignment into an equality comparison 592 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:598:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 598 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:598:15: note: place parentheses around the assignment to silence this warning 598 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:598:15: note: use '==' to turn this assignment into an equality comparison 598 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:600:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 600 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:600:15: note: place parentheses around the assignment to silence this warning 600 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:600:15: note: use '==' to turn this assignment into an equality comparison 600 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:607:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 607 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:607:15: note: place parentheses around the assignment to silence this warning 607 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:607:15: note: use '==' to turn this assignment into an equality comparison 607 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:609:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 609 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:609:15: note: place parentheses around the assignment to silence this warning 609 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:609:15: note: use '==' to turn this assignment into an equality comparison 609 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:615:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 615 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:615:15: note: place parentheses around the assignment to silence this warning 615 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:615:15: note: use '==' to turn this assignment into an equality comparison 615 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:617:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 617 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:617:15: note: place parentheses around the assignment to silence this warning 617 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:617:15: note: use '==' to turn this assignment into an equality comparison 617 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:624:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 624 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:624:15: note: place parentheses around the assignment to silence this warning 624 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:624:15: note: use '==' to turn this assignment into an equality comparison 624 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:626:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 626 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:626:15: note: place parentheses around the assignment to silence this warning 626 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:626:15: note: use '==' to turn this assignment into an equality comparison 626 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:629:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 629 | if (r = Write (va, dat)) /* rewrite */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:629:15: note: place parentheses around the assignment to silence this warning 629 | if (r = Write (va, dat)) /* rewrite */ | ^ | ( ) SDS/sds_cpu.c:629:15: note: use '==' to turn this assignment into an equality comparison 629 | if (r = Write (va, dat)) /* rewrite */ | ^ | == SDS/sds_cpu.c:634:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 634 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:634:15: note: place parentheses around the assignment to silence this warning 634 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:634:15: note: use '==' to turn this assignment into an equality comparison 634 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:636:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 636 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:636:15: note: place parentheses around the assignment to silence this warning 636 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:636:15: note: use '==' to turn this assignment into an equality comparison 636 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:639:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 639 | if (r = Write (va, dat)) /* rewrite */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:639:15: note: place parentheses around the assignment to silence this warning 639 | if (r = Write (va, dat)) /* rewrite */ | ^ | ( ) SDS/sds_cpu.c:639:15: note: use '==' to turn this assignment into an equality comparison 639 | if (r = Write (va, dat)) /* rewrite */ | ^ | == SDS/sds_cpu.c:644:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 644 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:644:15: note: place parentheses around the assignment to silence this warning 644 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:644:15: note: use '==' to turn this assignment into an equality comparison 644 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:646:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 646 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:646:15: note: place parentheses around the assignment to silence this warning 646 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:646:15: note: use '==' to turn this assignment into an equality comparison 646 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:652:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 652 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:652:15: note: place parentheses around the assignment to silence this warning 652 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:652:15: note: use '==' to turn this assignment into an equality comparison 652 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:654:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 654 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:654:15: note: place parentheses around the assignment to silence this warning 654 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:654:15: note: use '==' to turn this assignment into an equality comparison 654 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:660:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 660 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:660:15: note: place parentheses around the assignment to silence this warning 660 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:660:15: note: use '==' to turn this assignment into an equality comparison 660 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:662:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 662 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:662:15: note: place parentheses around the assignment to silence this warning 662 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:662:15: note: use '==' to turn this assignment into an equality comparison 662 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:668:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 668 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:668:15: note: place parentheses around the assignment to silence this warning 668 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:668:15: note: use '==' to turn this assignment into an equality comparison 668 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:670:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 670 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:670:15: note: place parentheses around the assignment to silence this warning 670 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:670:15: note: use '==' to turn this assignment into an equality comparison 670 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:676:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 676 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:676:15: note: place parentheses around the assignment to silence this warning 676 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:676:15: note: use '==' to turn this assignment into an equality comparison 676 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:678:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 678 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:678:15: note: place parentheses around the assignment to silence this warning 678 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:678:15: note: use '==' to turn this assignment into an equality comparison 678 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:686:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 686 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:686:15: note: place parentheses around the assignment to silence this warning 686 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:686:15: note: use '==' to turn this assignment into an equality comparison 686 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:688:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 688 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:688:15: note: place parentheses around the assignment to silence this warning 688 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:688:15: note: use '==' to turn this assignment into an equality comparison 688 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:695:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 695 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:695:15: note: place parentheses around the assignment to silence this warning 695 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:695:15: note: use '==' to turn this assignment into an equality comparison 695 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:697:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 697 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:697:15: note: place parentheses around the assignment to silence this warning 697 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:697:15: note: use '==' to turn this assignment into an equality comparison 697 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:704:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 704 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:704:15: note: place parentheses around the assignment to silence this warning 704 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:704:15: note: use '==' to turn this assignment into an equality comparison 704 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:706:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 706 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:706:15: note: place parentheses around the assignment to silence this warning 706 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:706:15: note: use '==' to turn this assignment into an equality comparison 706 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:713:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 713 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:713:15: note: place parentheses around the assignment to silence this warning 713 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:713:15: note: use '==' to turn this assignment into an equality comparison 713 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:715:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 715 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:715:15: note: place parentheses around the assignment to silence this warning 715 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:715:15: note: use '==' to turn this assignment into an equality comparison 715 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:722:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 722 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:722:15: note: place parentheses around the assignment to silence this warning 722 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:722:15: note: use '==' to turn this assignment into an equality comparison 722 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:724:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 724 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:724:15: note: place parentheses around the assignment to silence this warning 724 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:724:15: note: use '==' to turn this assignment into an equality comparison 724 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:731:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 731 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:731:15: note: place parentheses around the assignment to silence this warning 731 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:731:15: note: use '==' to turn this assignment into an equality comparison 731 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:733:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 733 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:733:15: note: place parentheses around the assignment to silence this warning 733 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:733:15: note: use '==' to turn this assignment into an equality comparison 733 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:740:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 740 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:740:15: note: place parentheses around the assignment to silence this warning 740 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:740:15: note: use '==' to turn this assignment into an equality comparison 740 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:742:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 742 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:742:15: note: place parentheses around the assignment to silence this warning 742 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:742:15: note: use '==' to turn this assignment into an equality comparison 742 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:745:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 745 | if (r = Write (va, dat)) /* rewrite */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:745:15: note: place parentheses around the assignment to silence this warning 745 | if (r = Write (va, dat)) /* rewrite */ | ^ | ( ) SDS/sds_cpu.c:745:15: note: use '==' to turn this assignment into an equality comparison 745 | if (r = Write (va, dat)) /* rewrite */ | ^ | == SDS/sds_cpu.c:752:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 752 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:752:15: note: place parentheses around the assignment to silence this warning 752 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:752:15: note: use '==' to turn this assignment into an equality comparison 752 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:754:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 754 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:754:15: note: place parentheses around the assignment to silence this warning 754 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:754:15: note: use '==' to turn this assignment into an equality comparison 754 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:777:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 777 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:777:15: note: place parentheses around the assignment to silence this warning 777 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:777:15: note: use '==' to turn this assignment into an equality comparison 777 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:779:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 779 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:779:15: note: place parentheses around the assignment to silence this warning 779 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:779:15: note: use '==' to turn this assignment into an equality comparison 779 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:786:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 786 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:786:15: note: place parentheses around the assignment to silence this warning 786 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:786:15: note: use '==' to turn this assignment into an equality comparison 786 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:788:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 788 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:788:15: note: place parentheses around the assignment to silence this warning 788 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:788:15: note: use '==' to turn this assignment into an equality comparison 788 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:795:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 795 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:795:15: note: place parentheses around the assignment to silence this warning 795 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:795:15: note: use '==' to turn this assignment into an equality comparison 795 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:799:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 799 | if (r = Read (va, &dat)) /* test dest access */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:799:19: note: place parentheses around the assignment to silence this warning 799 | if (r = Read (va, &dat)) /* test dest access */ | ^ | ( ) SDS/sds_cpu.c:799:19: note: use '==' to turn this assignment into an equality comparison 799 | if (r = Read (va, &dat)) /* test dest access */ | ^ | == SDS/sds_cpu.c:807:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 807 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:807:15: note: place parentheses around the assignment to silence this warning 807 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:807:15: note: use '==' to turn this assignment into an equality comparison 807 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:813:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 813 | if (r = Write (va, dat)) /* write ret word */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:813:15: note: place parentheses around the assignment to silence this warning 813 | if (r = Write (va, dat)) /* write ret word */ | ^ | ( ) SDS/sds_cpu.c:813:15: note: use '==' to turn this assignment into an equality comparison 813 | if (r = Write (va, dat)) /* write ret word */ | ^ | == SDS/sds_cpu.c:820:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 820 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:820:15: note: place parentheses around the assignment to silence this warning 820 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:820:15: note: use '==' to turn this assignment into an equality comparison 820 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:822:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 822 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:822:15: note: place parentheses around the assignment to silence this warning 822 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:822:15: note: use '==' to turn this assignment into an equality comparison 822 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:840:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 840 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:840:15: note: place parentheses around the assignment to silence this warning 840 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:840:15: note: use '==' to turn this assignment into an equality comparison 840 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:842:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 842 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:842:15: note: place parentheses around the assignment to silence this warning 842 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:842:15: note: use '==' to turn this assignment into an equality comparison 842 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:912:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 912 | if (r = EaSh (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:912:15: note: place parentheses around the assignment to silence this warning 912 | if (r = EaSh (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:912:15: note: use '==' to turn this assignment into an equality comparison 912 | if (r = EaSh (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:937:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 937 | if (r = EaSh (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:937:15: note: place parentheses around the assignment to silence this warning 937 | if (r = EaSh (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:937:15: note: use '==' to turn this assignment into an equality comparison 937 | if (r = EaSh (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:992:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 992 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:992:15: note: place parentheses around the assignment to silence this warning 992 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:992:15: note: use '==' to turn this assignment into an equality comparison 992 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:994:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 994 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:994:15: note: place parentheses around the assignment to silence this warning 994 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:994:15: note: use '==' to turn this assignment into an equality comparison 994 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:996:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 996 | if (r = op_miwy (inst, dat)) /* process inst */ | ~~^~~~~~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:996:15: note: place parentheses around the assignment to silence this warning 996 | if (r = op_miwy (inst, dat)) /* process inst */ | ^ | ( ) SDS/sds_cpu.c:996:15: note: use '==' to turn this assignment into an equality comparison 996 | if (r = op_miwy (inst, dat)) /* process inst */ | ^ | == SDS/sds_cpu.c:1005:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1005 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1005:15: note: place parentheses around the assignment to silence this warning 1005 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:1005:15: note: use '==' to turn this assignment into an equality comparison 1005 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:1007:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1007 | if (r = op_wyim (inst, &dat)) /* process inst */ | ~~^~~~~~~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1007:15: note: place parentheses around the assignment to silence this warning 1007 | if (r = op_wyim (inst, &dat)) /* process inst */ | ^ | ( ) SDS/sds_cpu.c:1007:15: note: use '==' to turn this assignment into an equality comparison 1007 | if (r = op_wyim (inst, &dat)) /* process inst */ | ^ | == SDS/sds_cpu.c:1009:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1009 | if (r = Write (va, dat)) | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1009:15: note: place parentheses around the assignment to silence this warning 1009 | if (r = Write (va, dat)) | ^ | ( ) SDS/sds_cpu.c:1009:15: note: use '==' to turn this assignment into an equality comparison 1009 | if (r = Write (va, dat)) | ^ | == SDS/sds_cpu.c:1018:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1018 | if (r = op_eomd (inst)) /* process inst */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1018:15: note: place parentheses around the assignment to silence this warning 1018 | if (r = op_eomd (inst)) /* process inst */ | ^ | ( ) SDS/sds_cpu.c:1018:15: note: use '==' to turn this assignment into an equality comparison 1018 | if (r = op_eomd (inst)) /* process inst */ | ^ | == SDS/sds_cpu.c:1028:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1028 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1028:15: note: place parentheses around the assignment to silence this warning 1028 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:1028:15: note: use '==' to turn this assignment into an equality comparison 1028 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:1030:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1030 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1030:15: note: place parentheses around the assignment to silence this warning 1030 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:1030:15: note: use '==' to turn this assignment into an equality comparison 1030 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:1032:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1032 | if (r = op_pot (dat)) /* process inst */ | ~~^~~~~~~~~~~~~~ SDS/sds_cpu.c:1032:15: note: place parentheses around the assignment to silence this warning 1032 | if (r = op_pot (dat)) /* process inst */ | ^ | ( ) SDS/sds_cpu.c:1032:15: note: use '==' to turn this assignment into an equality comparison 1032 | if (r = op_pot (dat)) /* process inst */ | ^ | == SDS/sds_cpu.c:1041:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1041 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1041:15: note: place parentheses around the assignment to silence this warning 1041 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:1041:15: note: use '==' to turn this assignment into an equality comparison 1041 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:1043:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1043 | if (r = op_pin (&dat)) /* process inst */ | ~~^~~~~~~~~~~~~~~ SDS/sds_cpu.c:1043:15: note: place parentheses around the assignment to silence this warning 1043 | if (r = op_pin (&dat)) /* process inst */ | ^ | ( ) SDS/sds_cpu.c:1043:15: note: use '==' to turn this assignment into an equality comparison 1043 | if (r = op_pin (&dat)) /* process inst */ | ^ | == SDS/sds_cpu.c:1045:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1045 | if (r = Write (va, dat)) /* write result */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1045:15: note: place parentheses around the assignment to silence this warning 1045 | if (r = Write (va, dat)) /* write result */ | ^ | ( ) SDS/sds_cpu.c:1045:15: note: use '==' to turn this assignment into an equality comparison 1045 | if (r = Write (va, dat)) /* write result */ | ^ | == SDS/sds_cpu.c:1054:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1054 | if (r = op_sks (inst, &dat)) /* process inst */ | ~~^~~~~~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1054:15: note: place parentheses around the assignment to silence this warning 1054 | if (r = op_sks (inst, &dat)) /* process inst */ | ^ | ( ) SDS/sds_cpu.c:1054:15: note: use '==' to turn this assignment into an equality comparison 1054 | if (r = op_sks (inst, &dat)) /* process inst */ | ^ | == SDS/sds_cpu.c:1088:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1088 | if (r = Read (va, &wd)) /* read ind; fails? */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1088:11: note: place parentheses around the assignment to silence this warning 1088 | if (r = Read (va, &wd)) /* read ind; fails? */ | ^ | ( ) SDS/sds_cpu.c:1088:11: note: use '==' to turn this assignment into an equality comparison 1088 | if (r = Read (va, &wd)) /* read ind; fails? */ | ^ | == SDS/sds_cpu.c:1115:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1115 | if (r = Read (va, &wd)) /* read ind; fails? */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1115:11: note: place parentheses around the assignment to silence this warning 1115 | if (r = Read (va, &wd)) /* read ind; fails? */ | ^ | ( ) SDS/sds_cpu.c:1115:11: note: use '==' to turn this assignment into an equality comparison 1115 | if (r = Read (va, &wd)) /* read ind; fails? */ | ^ | == SDS/sds_cpu.c:1572:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1572 | if (r = Ea (inst, &va)) /* decode eff addr */ | ~~^~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1572:7: note: place parentheses around the assignment to silence this warning 1572 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | ( ) SDS/sds_cpu.c:1572:7: note: use '==' to turn this assignment into an equality comparison 1572 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ | == SDS/sds_cpu.c:1574:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1574 | if (r = Read (va, &dat)) /* get operand */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1574:7: note: place parentheses around the assignment to silence this warning 1574 | if (r = Read (va, &dat)) /* get operand */ | ^ | ( ) SDS/sds_cpu.c:1574:7: note: use '==' to turn this assignment into an equality comparison 1574 | if (r = Read (va, &dat)) /* get operand */ | ^ | == SDS/sds_cpu.c:1577:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1577 | if (r = Write (va, dat)) /* rewrite */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_cpu.c:1577:7: note: place parentheses around the assignment to silence this warning 1577 | if (r = Write (va, dat)) /* rewrite */ | ^ | ( ) SDS/sds_cpu.c:1577:7: note: use '==' to turn this assignment into an equality comparison 1577 | if (r = Write (va, dat)) /* rewrite */ | ^ | == 93 warnings generated. SDS/sds_dsk.c:207:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 207 | if (r = dsk_read_buf (inst)) /* read sector */ | ~~^~~~~~~~~~~~~~~~~~~~~ SDS/sds_dsk.c:207:19: note: place parentheses around the assignment to silence this warning 207 | if (r = dsk_read_buf (inst)) /* read sector */ | ^ | ( ) SDS/sds_dsk.c:207:19: note: use '==' to turn this assignment into an equality comparison 207 | if (r = dsk_read_buf (inst)) /* read sector */ | ^ | == SDS/sds_dsk.c:222:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 222 | if (r = dsk_write_buf (inst)) /* write sector */ | ~~^~~~~~~~~~~~~~~~~~~~~~ SDS/sds_dsk.c:222:19: note: place parentheses around the assignment to silence this warning 222 | if (r = dsk_write_buf (inst)) /* write sector */ | ^ | ( ) SDS/sds_dsk.c:222:19: note: use '==' to turn this assignment into an equality comparison 222 | if (r = dsk_write_buf (inst)) /* write sector */ | ^ | == 2 warnings generated. SDS/sds_io.c:339:38: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 339 | if (r = dev_dsp[dev][ch] (IO_CONN, inst, NULL)) /* connect */ | ^ SDS/sds_io.c:339:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 339 | if (r = dev_dsp[dev][ch] (IO_CONN, inst, NULL)) /* connect */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ SDS/sds_io.c:339:19: note: place parentheses around the assignment to silence this warning 339 | if (r = dev_dsp[dev][ch] (IO_CONN, inst, NULL)) /* connect */ | ^ | ( ) SDS/sds_io.c:339:19: note: use '==' to turn this assignment into an equality comparison 339 | if (r = dev_dsp[dev][ch] (IO_CONN, inst, NULL)) /* connect */ | ^ | == SDS/sds_io.c:371:37: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 371 | return dev_dsp[dev][ch] (IO_EOM1, inst, NULL); | ^ SDS/sds_io.c:438:34: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 438 | return dev3_dsp[dev] (IO_CONN, inst, NULL); | ^ SDS/sds_io.c:466:30: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 466 | dev_dsp[dev][ch] (IO_SKS, inst, dat); /* do test */ | ^ SDS/sds_io.c:499:27: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 499 | dev3_dsp[dev] (IO_SKS, inst, dat); | ^ SDS/sds_io.c:583:26: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 583 | r = dev_dsp[dev][ch] (IO_READ, dev, &dat); /* read data */ | ^ SDS/sds_io.c:709:26: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 709 | r = dev_dsp[dev][ch] (IO_WRITE, dev, &dat); /* write */ | ^ SDS/sds_io.c:786:29: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 786 | return dev_dsp[dev][ch] (IO_DISC, dev, NULL); | ^ SDS/sds_io.c:793:29: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 793 | return dev_dsp[dev][ch] (IO_WREOR, dev, NULL); | ^ SDS/sds_io.c:961:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 961 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ~~~~~^~~~~~~~~~~~~~~~ SDS/sds_io.c:961:18: note: place parentheses around the assignment to silence this warning 961 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^ | ( ) SDS/sds_io.c:961:18: note: use '==' to turn this assignment into an equality comparison 961 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^ | == 11 warnings generated. SDS/sds_mt.c:238:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 238 | if (r = mt_wrend (inst)) /* end record */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_mt.c:238:19: note: place parentheses around the assignment to silence this warning 238 | if (r = mt_wrend (inst)) /* end record */ | ^ | ( ) SDS/sds_mt.c:238:19: note: use '==' to turn this assignment into an equality comparison 238 | if (r = mt_wrend (inst)) /* end record */ | ^ | == SDS/sds_mt.c:245:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 245 | if (r = mt_wrend (inst)) /* end record */ | ~~^~~~~~~~~~~~~~~~~ SDS/sds_mt.c:245:15: note: place parentheses around the assignment to silence this warning 245 | if (r = mt_wrend (inst)) /* end record */ | ^ | ( ) SDS/sds_mt.c:245:15: note: use '==' to turn this assignment into an equality comparison 245 | if (r = mt_wrend (inst)) /* end record */ | ^ | == 2 warnings generated. SDS/sds_mux.c:366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 366 | if (c = tmxr_getc_ln (&mux_ldsc[ln])) { /* get char */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ SDS/sds_mux.c:366:15: note: place parentheses around the assignment to silence this warning 366 | if (c = tmxr_getc_ln (&mux_ldsc[ln])) { /* get char */ | ^ | ( ) SDS/sds_mux.c:366:15: note: use '==' to turn this assignment into an equality comparison 366 | if (c = tmxr_getc_ln (&mux_ldsc[ln])) { /* get char */ | ^ | == 1 warning generated. SDS/sds_stddev.c:398:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 398 | if (r = ptp_out (0)) | ~~^~~~~~~~~~~~~ SDS/sds_stddev.c:398:15: note: place parentheses around the assignment to silence this warning 398 | if (r = ptp_out (0)) | ^ | ( ) SDS/sds_stddev.c:398:15: note: use '==' to turn this assignment into an equality comparison 398 | if (r = ptp_out (0)) | ^ | == 1 warning generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-54a597.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-54a597.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_ether.c(/tmp/sim_ether-cc7ddb.o:(eth_mac_fmt)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so LGP/lgp_cpu.c LGP/lgp_stddev.c LGP/lgp_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I LGP -o BIN/lgp -lm -lpthread -lpcap LGP/lgp_cpu.c:291:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 291 | if (r = sim_process_event ()) | ~~^~~~~~~~~~~~~~~~~~~~~~ LGP/lgp_cpu.c:291:15: note: place parentheses around the assignment to silence this warning 291 | if (r = sim_process_event ()) | ^ | ( ) LGP/lgp_cpu.c:291:15: note: use '==' to turn this assignment into an equality comparison 291 | if (r = sim_process_event ()) | ^ | == LGP/lgp_cpu.c:311:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 311 | if (r = cpu_one_inst (oPC, IR)) { /* one instr; error? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~ LGP/lgp_cpu.c:311:11: note: place parentheses around the assignment to silence this warning 311 | if (r = cpu_one_inst (oPC, IR)) { /* one instr; error? */ | ^ | ( ) LGP/lgp_cpu.c:311:11: note: use '==' to turn this assignment into an equality comparison 311 | if (r = cpu_one_inst (oPC, IR)) { /* one instr; error? */ | ^ | == LGP/lgp_cpu.c:747:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 747 | if (r = sim_process_event ()) | ~~^~~~~~~~~~~~~~~~~~~~~~ LGP/lgp_cpu.c:747:11: note: place parentheses around the assignment to silence this warning 747 | if (r = sim_process_event ()) | ^ | ( ) LGP/lgp_cpu.c:747:11: note: use '==' to turn this assignment into an equality comparison 747 | if (r = sim_process_event ()) | ^ | == 3 warnings generated. LGP/lgp_stddev.c:397:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 397 | if (r = read_reader (uptr, ttr_stopioe, (int32 *) &tti_buf)) | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LGP/lgp_stddev.c:397:7: note: place parentheses around the assignment to silence this warning 397 | if (r = read_reader (uptr, ttr_stopioe, (int32 *) &tti_buf)) | ^ | ( ) LGP/lgp_stddev.c:397:7: note: use '==' to turn this assignment into an equality comparison 397 | if (r = read_reader (uptr, ttr_stopioe, (int32 *) &tti_buf)) | ^ | == LGP/lgp_stddev.c:418:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 418 | if (r = read_reader (uptr, ptr_stopioe, &uptr->buf)) | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LGP/lgp_stddev.c:418:7: note: place parentheses around the assignment to silence this warning 418 | if (r = read_reader (uptr, ptr_stopioe, &uptr->buf)) | ^ | ( ) LGP/lgp_stddev.c:418:7: note: use '==' to turn this assignment into an equality comparison 418 | if (r = read_reader (uptr, ptr_stopioe, &uptr->buf)) | ^ | == LGP/lgp_stddev.c:551:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 551 | if (r = sim_putchar_s (ch)) /* write char */ | ~~^~~~~~~~~~~~~~~~~~~~ LGP/lgp_stddev.c:551:15: note: place parentheses around the assignment to silence this warning 551 | if (r = sim_putchar_s (ch)) /* write char */ | ^ | ( ) LGP/lgp_stddev.c:551:15: note: use '==' to turn this assignment into an equality comparison 551 | if (r = sim_putchar_s (ch)) /* write char */ | ^ | == 3 warnings generated. LGP/lgp_sys.c:366:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 366 | if (tptr = strchr (hex_decode, c)) | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ LGP/lgp_sys.c:366:18: note: place parentheses around the assignment to silence this warning 366 | if (tptr = strchr (hex_decode, c)) | ^ | ( ) LGP/lgp_sys.c:366:18: note: use '==' to turn this assignment into an equality comparison 366 | if (tptr = strchr (hex_decode, c)) | ^ | == LGP/lgp_sys.c:391:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 391 | if (tptr = strchr (opcode, gbuf[0])) | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ LGP/lgp_sys.c:391:10: note: place parentheses around the assignment to silence this warning 391 | if (tptr = strchr (opcode, gbuf[0])) | ^ | ( ) LGP/lgp_sys.c:391:10: note: use '==' to turn this assignment into an equality comparison 391 | if (tptr = strchr (opcode, gbuf[0])) | ^ | == 2 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-30dd8d.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-30dd8d.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-c1074c.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so H316/h316_stddev.c H316/h316_lp.c H316/h316_cpu.c H316/h316_sys.c H316/h316_mt.c H316/h316_fhd.c H316/h316_dp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I H316 -o BIN/h316 -lm -lpthread -lpcap H316/h316_stddev.c:393:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 393 | if (r = attach_unit (uptr, cptr)) | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_stddev.c:393:7: note: place parentheses around the assignment to silence this warning 393 | if (r = attach_unit (uptr, cptr)) | ^ | ( ) H316/h316_stddev.c:393:7: note: use '==' to turn this assignment into an equality comparison 393 | if (r = attach_unit (uptr, cptr)) | ^ | == 1 warning generated. H316/h316_cpu.c:427:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 427 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ H316/h316_cpu.c:427:16: note: place parentheses around the assignment to silence this warning 427 | if (reason = sim_process_event ()) | ^ | ( ) H316/h316_cpu.c:427:16: note: use '==' to turn this assignment into an equality comparison 427 | if (reason = sim_process_event ()) | ^ | == H316/h316_cpu.c:461:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 461 | if (r = (t >> IOT_V_REASON)) | ~~^~~~~~~~~~~~~~~~~~~~~ H316/h316_cpu.c:461:23: note: place parentheses around the assignment to silence this warning 461 | if (r = (t >> IOT_V_REASON)) | ^ | ( ) H316/h316_cpu.c:461:23: note: use '==' to turn this assignment into an equality comparison 461 | if (r = (t >> IOT_V_REASON)) | ^ | == H316/h316_cpu.c:531:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 531 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:531:20: note: place parentheses around the assignment to silence this warning 531 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:531:20: note: use '==' to turn this assignment into an equality comparison 531 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:540:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 540 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:540:20: note: place parentheses around the assignment to silence this warning 540 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:540:20: note: use '==' to turn this assignment into an equality comparison 540 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:551:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 551 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:551:20: note: place parentheses around the assignment to silence this warning 551 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:551:20: note: use '==' to turn this assignment into an equality comparison 551 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:557:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 557 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:557:20: note: place parentheses around the assignment to silence this warning 557 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:557:20: note: use '==' to turn this assignment into an equality comparison 557 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:567:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 567 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:567:20: note: place parentheses around the assignment to silence this warning 567 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:567:20: note: use '==' to turn this assignment into an equality comparison 567 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:573:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 573 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:573:20: note: place parentheses around the assignment to silence this warning 573 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:573:20: note: use '==' to turn this assignment into an equality comparison 573 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:586:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 586 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:586:20: note: place parentheses around the assignment to silence this warning 586 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:586:20: note: use '==' to turn this assignment into an equality comparison 586 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:599:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 599 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:599:20: note: place parentheses around the assignment to silence this warning 599 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:599:20: note: use '==' to turn this assignment into an equality comparison 599 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:608:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 608 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:608:20: note: place parentheses around the assignment to silence this warning 608 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:608:20: note: use '==' to turn this assignment into an equality comparison 608 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:618:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 618 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:618:20: note: place parentheses around the assignment to silence this warning 618 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:618:20: note: use '==' to turn this assignment into an equality comparison 618 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:627:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 627 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:627:20: note: place parentheses around the assignment to silence this warning 627 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:627:20: note: use '==' to turn this assignment into an equality comparison 627 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:635:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 635 | if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~ H316/h316_cpu.c:635:20: note: place parentheses around the assignment to silence this warning 635 | if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:635:20: note: use '==' to turn this assignment into an equality comparison 635 | if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:641:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 641 | if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~~~~~~~~ H316/h316_cpu.c:641:20: note: place parentheses around the assignment to silence this warning 641 | if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:641:20: note: use '==' to turn this assignment into an equality comparison 641 | if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:649:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 649 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:649:24: note: place parentheses around the assignment to silence this warning 649 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:649:24: note: use '==' to turn this assignment into an equality comparison 649 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:660:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 660 | if (reason = Ea (MB, &Y)) /* eff addr */ | ~~~~~~~^~~~~~~~~~~~~ H316/h316_cpu.c:660:24: note: place parentheses around the assignment to silence this warning 660 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | ( ) H316/h316_cpu.c:660:24: note: use '==' to turn this assignment into an equality comparison 660 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^ | == H316/h316_cpu.c:829:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 829 | if (reason = stop_inst) /* stop on undef? */ | ~~~~~~~^~~~~~~~~~~ H316/h316_cpu.c:829:24: note: place parentheses around the assignment to silence this warning 829 | if (reason = stop_inst) /* stop on undef? */ | ^ | ( ) H316/h316_cpu.c:829:24: note: use '==' to turn this assignment into an equality comparison 829 | if (reason = stop_inst) /* stop on undef? */ | ^ | == H316/h316_cpu.c:862:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 862 | if (reason = stop_inst) /* stop on undef? */ | ~~~~~~~^~~~~~~~~~~ H316/h316_cpu.c:862:24: note: place parentheses around the assignment to silence this warning 862 | if (reason = stop_inst) /* stop on undef? */ | ^ | ( ) H316/h316_cpu.c:862:24: note: use '==' to turn this assignment into an equality comparison 862 | if (reason = stop_inst) /* stop on undef? */ | ^ | == H316/h316_cpu.c:902:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 902 | if (reason = stop_inst) /* stop on undef? */ | ~~~~~~~^~~~~~~~~~~ H316/h316_cpu.c:902:24: note: place parentheses around the assignment to silence this warning 902 | if (reason = stop_inst) /* stop on undef? */ | ^ | ( ) H316/h316_cpu.c:902:24: note: use '==' to turn this assignment into an equality comparison 902 | if (reason = stop_inst) /* stop on undef? */ | ^ | == H316/h316_cpu.c:938:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 938 | if (reason = stop_inst) /* stop on undef? */ | ~~~~~~~^~~~~~~~~~~ H316/h316_cpu.c:938:24: note: place parentheses around the assignment to silence this warning 938 | if (reason = stop_inst) /* stop on undef? */ | ^ | ( ) H316/h316_cpu.c:938:24: note: use '==' to turn this assignment into an equality comparison 938 | if (reason = stop_inst) /* stop on undef? */ | ^ | == H316/h316_cpu.c:1006:25: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1006 | else if (reason = stop_inst) | ~~~~~~~^~~~~~~~~~~ H316/h316_cpu.c:1006:25: note: place parentheses around the assignment to silence this warning 1006 | else if (reason = stop_inst) | ^ | ( ) H316/h316_cpu.c:1006:25: note: use '==' to turn this assignment into an equality comparison 1006 | else if (reason = stop_inst) | ^ | == H316/h316_cpu.c:1503:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1503 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ~~~~~^~~~~~~~~~~~~~~~ H316/h316_cpu.c:1503:18: note: place parentheses around the assignment to silence this warning 1503 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^ | ( ) H316/h316_cpu.c:1503:18: note: use '==' to turn this assignment into an equality comparison 1503 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^ | == 23 warnings generated. H316/h316_sys.c:367:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 367 | if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_sys.c:367:15: note: place parentheses around the assignment to silence this warning 367 | if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ | ^ | ( ) H316/h316_sys.c:367:15: note: use '==' to turn this assignment into an equality comparison 367 | if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ | ^ | == H316/h316_sys.c:371:20: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 371 | else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_sys.c:371:20: note: place parentheses around the assignment to silence this warning 371 | else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ | ^ | ( ) H316/h316_sys.c:371:20: note: use '==' to turn this assignment into an equality comparison 371 | else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ | ^ | == 2 warnings generated. H316/h316_mt.c:374:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 374 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~ H316/h316_mt.c:374:16: note: place parentheses around the assignment to silence this warning 374 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | ( ) H316/h316_mt.c:374:16: note: use '==' to turn this assignment into an equality comparison 374 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^ | == H316/h316_mt.c:379:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 379 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space fwd, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_mt.c:379:16: note: place parentheses around the assignment to silence this warning 379 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space fwd, err? */ | ^ | ( ) H316/h316_mt.c:379:16: note: use '==' to turn this assignment into an equality comparison 379 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space fwd, err? */ | ^ | == H316/h316_mt.c:384:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 384 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_mt.c:384:16: note: place parentheses around the assignment to silence this warning 384 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ^ | ( ) H316/h316_mt.c:384:16: note: use '==' to turn this assignment into an equality comparison 384 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ^ | == H316/h316_mt.c:458:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 458 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) /* write, err? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_mt.c:458:24: note: place parentheses around the assignment to silence this warning 458 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) /* write, err? */ | ^ | ( ) H316/h316_mt.c:458:24: note: use '==' to turn this assignment into an equality comparison 458 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) /* write, err? */ | ^ | == 4 warnings generated. H316/h316_dp.c:620:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 620 | if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_dp.c:620:15: note: place parentheses around the assignment to silence this warning 620 | if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ | ^ | ( ) H316/h316_dp.c:620:15: note: use '==' to turn this assignment into an equality comparison 620 | if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ | ^ | == H316/h316_dp.c:725:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 725 | if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_dp.c:725:15: note: place parentheses around the assignment to silence this warning 725 | if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ | ^ | ( ) H316/h316_dp.c:725:15: note: use '==' to turn this assignment into an equality comparison 725 | if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ | ^ | == H316/h316_dp.c:753:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 753 | if (r = dp_wrwd (uptr, dp_buf)) /* wr word, error? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_dp.c:753:19: note: place parentheses around the assignment to silence this warning 753 | if (r = dp_wrwd (uptr, dp_buf)) /* wr word, error? */ | ^ | ( ) H316/h316_dp.c:753:19: note: use '==' to turn this assignment into an equality comparison 753 | if (r = dp_wrwd (uptr, dp_buf)) /* wr word, error? */ | ^ | == H316/h316_dp.c:858:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 858 | if (r = dp_wrdone (uptr, STA_UNSER)) /* dump track */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_dp.c:858:7: note: place parentheses around the assignment to silence this warning 858 | if (r = dp_wrdone (uptr, STA_UNSER)) /* dump track */ | ^ | ( ) H316/h316_dp.c:858:7: note: use '==' to turn this assignment into an equality comparison 858 | if (r = dp_wrdone (uptr, STA_UNSER)) /* dump track */ | ^ | == H316/h316_dp.c:1020:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1020 | if (r = dp_wrtrk (uptr, tbuf, c, h)) | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_dp.c:1020:15: note: place parentheses around the assignment to silence this warning 1020 | if (r = dp_wrtrk (uptr, tbuf, c, h)) | ^ | ( ) H316/h316_dp.c:1020:15: note: use '==' to turn this assignment into an equality comparison 1020 | if (r = dp_wrtrk (uptr, tbuf, c, h)) | ^ | == H316/h316_dp.c:1046:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1046 | if (r = dp_rdtrk (uptr, tbuf, c, h)) | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ H316/h316_dp.c:1046:15: note: place parentheses around the assignment to silence this warning 1046 | if (r = dp_rdtrk (uptr, tbuf, c, h)) | ^ | ( ) H316/h316_dp.c:1046:15: note: use '==' to turn this assignment into an equality comparison 1046 | if (r = dp_rdtrk (uptr, tbuf, c, h)) | ^ | == 6 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-cb591c.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-cb591c.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-49dd6d.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so swtp6800/common/mp-a.c swtp6800/common/m6800.c swtp6800/common/m6810.c swtp6800/common/bootrom.c swtp6800/common/dc-4.c swtp6800/common/mp-s.c swtp6800/swtp6800/mp-a_sys.c swtp6800/common/mp-b2.c swtp6800/common/mp-8m.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I swtp6800/swtp6800 -o BIN/swtp6800mp-a -lm -lpthread -lpcap swtp6800/common/m6800.c:319:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 319 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ swtp6800/common/m6800.c:319:24: note: place parentheses around the assignment to silence this warning 319 | if (reason = sim_process_event ()) | ^ | ( ) swtp6800/common/m6800.c:319:24: note: use '==' to turn this assignment into an equality comparison 319 | if (reason = sim_process_event ()) | ^ | == swtp6800/common/m6800.c:1895:18: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^~~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:18: note: place parentheses around the '==' expression to silence this warning 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^ ~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:18: note: place parentheses around the & expression to evaluate it first 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ~~~~^~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:39: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^~~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:39: note: place parentheses around the '==' expression to silence this warning 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^ ~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:39: note: place parentheses around the & expression to evaluate it first 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ~~~~^~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1894:9: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1894 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80)) || ( | ^ swtp6800/common/m6800.c:106:29: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^ swtp6800/common/m6800.c:1903:47: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ^~~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1903:47: note: place parentheses around the '==' expression to silence this warning 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ^ ~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1903:47: note: place parentheses around the & expression to evaluate it first 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ~~~~^~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1904:19: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] 1904 | ((op1 & 0x80 == 0) && (op2 & 0x80))); | ^~~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1904:19: note: place parentheses around the '==' expression to silence this warning 1904 | ((op1 & 0x80 == 0) && (op2 & 0x80))); | ^ ~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1904:19: note: place parentheses around the & expression to evaluate it first 1904 | ((op1 & 0x80 == 0) && (op2 & 0x80))); | ~~~~^~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1903:9: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ^ swtp6800/common/m6800.c:106:29: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^ 7 warnings generated. swtp6800/common/bootrom.c:147:61: warning: operator '<<' has lower precedence than '-'; '-' will be evaluated first [-Wshift-op-parentheses] 147 | BOOTROM_unit.capac = 0x200 << (val >> UNIT_V_MSIZE) - 1; /* set EPROM size */ | ~~ ~~~~~~~~~~~~~~~~~~~~~~^~~ swtp6800/common/bootrom.c:147:61: note: place parentheses around the '-' expression to silence this warning 147 | BOOTROM_unit.capac = 0x200 << (val >> UNIT_V_MSIZE) - 1; /* set EPROM size */ | ^ | ( ) 1 warning generated. swtp6800/common/mp-b2.c:217:52: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 217 | val = (dev_table[addr - 0x8000].routine(0, 0)) & 0xFF; | ^ swtp6800/common/mp-b2.c:293:45: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 293 | dev_table[addr - 0x8000].routine(1, val); | ^ 2 warnings generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-125319.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-125319.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_tmxr.c(/tmp/sim_tmxr-33de27.o:(tmxr_poll_conn)): warning: sprintf() is often misused, please use snprintf() cc -std=c99 -U__STRICT_ANSI__ -O2 -pipe -DPATH_KA655X_BIN=\"/usr/local/lib/simh/vax/ka655x.bin\" -DPATH_VMB_EXE=\"/usr/local/lib/simh/vax/vmb.exe\" -finline-functions -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so swtp6800/common/mp-a2.c swtp6800/common/m6800.c swtp6800/common/m6810.c swtp6800/common/bootrom.c swtp6800/common/dc-4.c swtp6800/common/mp-s.c swtp6800/swtp6800/mp-a2_sys.c swtp6800/common/mp-b2.c swtp6800/common/mp-8m.c swtp6800/common/i2716.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I swtp6800/swtp6800 -o BIN/swtp6800mp-a2 -lm -lpthread -lpcap swtp6800/common/m6800.c:319:24: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 319 | if (reason = sim_process_event ()) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ swtp6800/common/m6800.c:319:24: note: place parentheses around the assignment to silence this warning 319 | if (reason = sim_process_event ()) | ^ | ( ) swtp6800/common/m6800.c:319:24: note: use '==' to turn this assignment into an equality comparison 319 | if (reason = sim_process_event ()) | ^ | == swtp6800/common/m6800.c:1895:18: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^~~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:18: note: place parentheses around the '==' expression to silence this warning 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^ ~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:18: note: place parentheses around the & expression to evaluate it first 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ~~~~^~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:39: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^~~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:39: note: place parentheses around the '==' expression to silence this warning 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^ ~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:39: note: place parentheses around the & expression to evaluate it first 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ~~~~^~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1894:9: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1894 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80)) || ( | ^ swtp6800/common/m6800.c:106:29: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^ swtp6800/common/m6800.c:1903:47: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ^~~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1903:47: note: place parentheses around the '==' expression to silence this warning 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ^ ~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1903:47: note: place parentheses around the & expression to evaluate it first 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ~~~~^~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1904:19: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] 1904 | ((op1 & 0x80 == 0) && (op2 & 0x80))); | ^~~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1904:19: note: place parentheses around the '==' expression to silence this warning 1904 | ((op1 & 0x80 == 0) && (op2 & 0x80))); | ^ ~~~~~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1904:19: note: place parentheses around the & expression to evaluate it first 1904 | ((op1 & 0x80 == 0) && (op2 & 0x80))); | ~~~~^~~~~~ swtp6800/common/m6800.c:106:9: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1903:9: warning: add explicit braces to avoid dangling else [-Wdangling-else] 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ^ swtp6800/common/m6800.c:106:29: note: expanded from macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^ 7 warnings generated. swtp6800/common/bootrom.c:147:61: warning: operator '<<' has lower precedence than '-'; '-' will be evaluated first [-Wshift-op-parentheses] 147 | BOOTROM_unit.capac = 0x200 << (val >> UNIT_V_MSIZE) - 1; /* set EPROM size */ | ~~ ~~~~~~~~~~~~~~~~~~~~~~^~~ swtp6800/common/bootrom.c:147:61: note: place parentheses around the '-' expression to silence this warning 147 | BOOTROM_unit.capac = 0x200 << (val >> UNIT_V_MSIZE) - 1; /* set EPROM size */ | ^ | ( ) 1 warning generated. swtp6800/common/mp-b2.c:217:52: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 217 | val = (dev_table[addr - 0x8000].routine(0, 0)) & 0xFF; | ^ swtp6800/common/mp-b2.c:293:45: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] 293 | dev_table[addr - 0x8000].routine(1, val); | ^ 2 warnings generated. swtp6800/common/i2716.c:124:57: warning: format specifies type 'int' but the argument has type 'long' [-Wformat] 124 | printf("i2716%d: Unable to open ROM file %s\n", uptr - i2716_dev.units, uptr->filename); | ~~ ^~~~~~~~~~~~~~~~~~~~~~ | %ld 1 warning generated. In file included from scp.c:189: ./sim_rev.h:363:1: warning: '/*' within block comment [-Wcomment] 363 | /* V3.8 revision history | ^ ./sim_rev.h:716:1: warning: '/*' within block comment [-Wcomment] 716 | /* V3.7 revision history | ^ ./sim_rev.h:988:1: warning: '/*' within block comment [-Wcomment] 988 | /* V3.6 revision history | ^ ./sim_rev.h:1162:1: warning: '/*' within block comment [-Wcomment] 1162 | /* V3.5 revision history | ^ ./sim_rev.h:1298:1: warning: '/*' within block comment [-Wcomment] 1298 | /* V3.4 revision history | ^ ./sim_rev.h:1336:1: warning: '/*' within block comment [-Wcomment] 1336 | /* V3.3 revision history | ^ ./sim_rev.h:1588:1: warning: '/*' within block comment [-Wcomment] 1588 | /* V3.2 revision history | ^ ./sim_rev.h:1787:1: warning: '/*' within block comment [-Wcomment] 1787 | /* V3.1 revision history | ^ ./sim_rev.h:1900:1: warning: '/*' within block comment [-Wcomment] 1900 | /* V3.0 revision history | ^ ./sim_rev.h:2066:1: warning: '/*' within block comment [-Wcomment] 2066 | /* V2.10 revision history | ^ ./sim_rev.h:2364:1: warning: '/*' within block comment [-Wcomment] 2364 | /* V2.9 revision history | ^ scp.c:685:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:685:12: note: place parentheses around the assignment to silence this warning 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | ( ) scp.c:685:12: note: use '==' to turn this assignment into an equality comparison 685 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^ | == scp.c:692:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:692:14: note: place parentheses around the assignment to silence this warning 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | ( ) scp.c:692:14: note: use '==' to turn this assignment into an equality comparison 692 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^ | == scp.c:709:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:709:14: note: place parentheses around the assignment to silence this warning 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | ( ) scp.c:709:14: note: use '==' to turn this assignment into an equality comparison 709 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^ | == scp.c:776:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 776 | if (cmdp = find_cmd (gbuf)) { | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:776:14: note: place parentheses around the assignment to silence this warning 776 | if (cmdp = find_cmd (gbuf)) { | ^ | ( ) scp.c:776:14: note: use '==' to turn this assignment into an equality comparison 776 | if (cmdp = find_cmd (gbuf)) { | ^ | == scp.c:920:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:920:14: note: place parentheses around the assignment to silence this warning 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | ( ) scp.c:920:14: note: use '==' to turn this assignment into an equality comparison 920 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^ | == scp.c:1100:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1100:10: note: place parentheses around the assignment to silence this warning 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1100:10: note: use '==' to turn this assignment into an equality comparison 1100 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1105:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1105:15: note: place parentheses around the assignment to silence this warning 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1105:15: note: use '==' to turn this assignment into an equality comparison 1105 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1111:16: note: place parentheses around the assignment to silence this warning 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1111:16: note: use '==' to turn this assignment into an equality comparison 1111 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1119:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1119:15: note: place parentheses around the assignment to silence this warning 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1119:15: note: use '==' to turn this assignment into an equality comparison 1119 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1132:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1132 | if (cvptr = strchr (gbuf, '=')) | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1132:35: note: place parentheses around the assignment to silence this warning 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | ( ) scp.c:1132:35: note: use '==' to turn this assignment into an equality comparison 1132 | if (cvptr = strchr (gbuf, '=')) | ^ | == scp.c:1165:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1165:18: note: place parentheses around the assignment to silence this warning 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | ( ) scp.c:1165:18: note: use '==' to turn this assignment into an equality comparison 1165 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^ | == scp.c:1358:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1358:11: note: place parentheses around the assignment to silence this warning 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | ( ) scp.c:1358:11: note: use '==' to turn this assignment into an equality comparison 1358 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^ | == scp.c:1361:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:1361:10: note: place parentheses around the assignment to silence this warning 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | ( ) scp.c:1361:10: note: use '==' to turn this assignment into an equality comparison 1361 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^ | == scp.c:1366:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1366:15: note: place parentheses around the assignment to silence this warning 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | ( ) scp.c:1366:15: note: use '==' to turn this assignment into an equality comparison 1366 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^ | == scp.c:1386:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1386:15: note: place parentheses around the assignment to silence this warning 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) scp.c:1386:15: note: use '==' to turn this assignment into an equality comparison 1386 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == scp.c:1405:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:1405:19: note: place parentheses around the assignment to silence this warning 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | ( ) scp.c:1405:19: note: use '==' to turn this assignment into an equality comparison 1405 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^ | == scp.c:1809:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:1809:10: note: place parentheses around the assignment to silence this warning 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | ( ) scp.c:1809:10: note: use '==' to turn this assignment into an equality comparison 1809 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^ | == scp.c:3708:11: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:3708:11: note: place parentheses around the assignment to silence this warning 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | ( ) scp.c:3708:11: note: use '==' to turn this assignment into an equality comparison 3708 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^ | == scp.c:3791:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ~~~~~^~~~~~~~~~~~~~~~~ scp.c:3791:10: note: place parentheses around the assignment to silence this warning 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | ( ) scp.c:3791:10: note: use '==' to turn this assignment into an equality comparison 3791 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^ | == scp.c:3871:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:3871:14: note: place parentheses around the assignment to silence this warning 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | ( ) scp.c:3871:14: note: use '==' to turn this assignment into an equality comparison 3871 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^ | == scp.c:4089:28: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ~~^~~~~~~~~ scp.c:4089:28: note: place parentheses around the assignment to silence this warning 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | ( ) scp.c:4089:28: note: use '==' to turn this assignment into an equality comparison 4089 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ | == scp.c:4090:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4090:14: note: place parentheses around the assignment to silence this warning 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | ( ) scp.c:4090:14: note: use '==' to turn this assignment into an equality comparison 4090 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^ | == scp.c:4097:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ~~~~~^~~~~~~~~~~~~~~~~~~~ scp.c:4097:19: note: place parentheses around the assignment to silence this warning 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | ( ) scp.c:4097:19: note: use '==' to turn this assignment into an equality comparison 4097 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^ | == scp.c:4762:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ scp.c:4762:8: note: place parentheses around the assignment to silence this warning 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | ( ) scp.c:4762:8: note: use '==' to turn this assignment into an equality comparison 4762 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^ | == 35 warnings generated. sim_console.c:165:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~ sim_console.c:165:15: note: place parentheses around the assignment to silence this warning 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | ( ) sim_console.c:165:15: note: use '==' to turn this assignment into an equality comparison 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^ | == sim_console.c:168:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:168:15: note: place parentheses around the assignment to silence this warning 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | ( ) sim_console.c:168:15: note: use '==' to turn this assignment into an equality comparison 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^ | == sim_console.c:193:15: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:193:15: note: place parentheses around the assignment to silence this warning 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | ( ) sim_console.c:193:15: note: use '==' to turn this assignment into an equality comparison 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^ | == sim_console.c:462:7: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_console.c:462:7: note: place parentheses around the assignment to silence this warning 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | ( ) sim_console.c:462:7: note: use '==' to turn this assignment into an equality comparison 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ | == 4 warnings generated. sim_tape.c:407:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:407:8: note: place parentheses around the assignment to silence this warning 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:407:8: note: use '==' to turn this assignment into an equality comparison 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^ | == sim_tape.c:456:8: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c:456:8: note: place parentheses around the assignment to silence this warning 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | ( ) sim_tape.c:456:8: note: use '==' to turn this assignment into an equality comparison 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^ | == 2 warnings generated. ld: warning: scp.c(/tmp/scp-f52a9b.o:(main)): warning: strcat() is almost always misused, please use strlcat() ld: warning: scp.c(/tmp/scp-f52a9b.o:(do_cmd)): warning: strcpy() is almost always misused, please use strlcpy() ld: warning: sim_ether.c(/tmp/sim_ether-afec71.o:(eth_mac_fmt)): warning: sprintf() is often misused, please use snprintf() >>> Running fake in emulators/simh at 1764801705.73 ===> emulators/simh ===> Faking installation for simh-3.9.0p3 /exopi-obj/pobj/simh-3.9.0/bin/install -d -m 755 /exopi-obj/pobj/simh-3.9.0/fake-amd64/usr/local/lib/simh/vax /exopi-obj/pobj/simh-3.9.0/bin/install -d -m 755 /exopi-obj/pobj/simh-3.9.0/fake-amd64/usr/local/share/doc/simh /exopi-obj/pobj/simh-3.9.0/bin/install -c -m 644 /exopi-obj/pobj/simh-3.9.0/VAX/ka655x.bin /exopi-obj/pobj/simh-3.9.0/fake-amd64/usr/local/lib/simh/vax /exopi-obj/pobj/simh-3.9.0/bin/install -c -m 644 /exopi-obj/pobj/simh-3.9.0/VAX/vmb.exe /exopi-obj/pobj/simh-3.9.0/fake-amd64/usr/local/lib/simh/vax /exopi-obj/pobj/simh-3.9.0/bin/install -c -m 644 /exopi-obj/pobj/simh-3.9.0/*.txt /exopi-obj/pobj/simh-3.9.0/*/*.txt /exopi-obj/pobj/simh-3.9.0/fake-amd64/usr/local/share/doc/simh >>> Running package in emulators/simh at 1764801708.82 ===> emulators/simh `/exopi-obj/pobj/simh-3.9.0/fake-amd64/.fake_done' is up to date. ===> Building package for simh-3.9.0p3 Create /exopi-cvs/ports/packages/amd64/all/simh-3.9.0p3.tgz Creating package simh-3.9.0p3 reading plist| checking dependencies| checksumming| checksumming| | 0% checksumming|* | 2% checksumming|** | 3% checksumming|*** | 5% checksumming|**** | 6% checksumming|***** | 8% checksumming|****** | 10% checksumming|******* | 11% checksumming|******** | 13% checksumming|********* | 15% checksumming|********** | 16% checksumming|*********** | 18% checksumming|************ | 19% checksumming|************* | 21% checksumming|************** | 23% checksumming|*************** | 24% checksumming|**************** | 26% checksumming|***************** | 27% checksumming|****************** | 29% checksumming|******************* | 31% checksumming|******************** | 32% checksumming|********************* | 34% checksumming|********************** | 35% checksumming|*********************** | 37% checksumming|************************ | 39% checksumming|************************* | 40% checksumming|************************** | 42% checksumming|*************************** | 44% checksumming|**************************** | 45% checksumming|***************************** | 47% checksumming|****************************** | 48% checksumming|******************************* | 50% checksumming|******************************* | 52% checksumming|******************************** | 53% checksumming|********************************* | 55% checksumming|********************************** | 56% checksumming|*********************************** | 58% checksumming|************************************ | 60% checksumming|************************************* | 61% checksumming|************************************** | 63% checksumming|*************************************** | 65% checksumming|**************************************** | 66% checksumming|***************************************** | 68% checksumming|****************************************** | 69% checksumming|******************************************* | 71% checksumming|******************************************** | 73% checksumming|********************************************* | 74% checksumming|********************************************** | 76% checksumming|*********************************************** | 77% checksumming|************************************************ | 79% checksumming|************************************************* | 81% checksumming|************************************************** | 82% checksumming|*************************************************** | 84% checksumming|**************************************************** | 85% checksumming|***************************************************** | 87% checksumming|****************************************************** | 89% checksumming|******************************************************* | 90% checksumming|******************************************************** | 92% checksumming|********************************************************* | 94% checksumming|********************************************************** | 95% checksumming|*********************************************************** | 97% checksumming|************************************************************ | 98% checksumming|*************************************************************|100% archiving| archiving| | 0% archiving|****** | 9% archiving|******* | 11% archiving|********* | 14% archiving|********** | 16% archiving|*********** | 18% archiving|*************** | 23% archiving|**************** | 25% archiving|***************** | 27% archiving|******************** | 30% archiving|********************* | 33% archiving|*********************** | 36% archiving|************************* | 39% archiving|************************** | 40% archiving|*************************** | 43% archiving|***************************** | 45% archiving|******************************* | 49% archiving|************************************ | 57% archiving|************************************** | 60% archiving|**************************************** | 62% archiving|****************************************** | 65% archiving|******************************************** | 68% archiving|********************************************** | 71% archiving|*********************************************** | 73% archiving|************************************************ | 76% archiving|************************************************** | 78% archiving|*************************************************** | 80% archiving|******************************************************* | 86% archiving|*********************************************************** | 93% archiving|************************************************************ | 94% archiving|************************************************************* | 95% archiving|*************************************************************** | 98% archiving|****************************************************************| 99% archiving|****************************************************************|100% Link to /exopi-cvs/ports/packages/amd64/ftp/simh-3.9.0p3.tgz >>> Running clean in emulators/simh at 1764801710.82 ===> emulators/simh ===> Cleaning for simh-3.9.0p3 >>> Ended at 1764801711.08 max_stuck=2.54/depends=2.50/show-prepare-results=0.68/patch=0.92/configure=0.25/build=207.28/fake=3.09/package=2.01/clean=0.30